weatherreporter/internal/generatedtext/hourly_test.go

package generatedtext

import (
	"strings"
	"testing"
)

func TestValidateHourlyNormalizesFields(t *testing.T) {
	value, err := ValidateHourly([]byte(`{
		"summary": " Storm chances increase. ",
		"forecast_discussion": " A front will keep the region unsettled. ",
		"precipitation_timing": " Showers are most likely early this afternoon. "
	}`))
	if err != nil {
		t.Fatalf("ValidateHourly() error = %v", err)
	}
	if value.Summary != "Storm chances increase." {
		t.Fatalf("Summary = %q, want trimmed summary", value.Summary)
	}
	if value.ForecastDiscussion != "A front will keep the region unsettled." {
		t.Fatalf("ForecastDiscussion = %q, want trimmed discussion", value.ForecastDiscussion)
	}
	if value.PrecipitationTiming != "Showers are most likely early this afternoon." {
		t.Fatalf("PrecipitationTiming = %q, want trimmed precipitation timing", value.PrecipitationTiming)
	}
}

func TestValidateHourlyPreservesRequiredEmptyPrecipitationTiming(t *testing.T) {
	value, err := ValidateHourly([]byte(`{
		"summary": "Storm chances increase.",
		"forecast_discussion": "A front will keep the region unsettled.",
		"precipitation_timing": "   "
	}`))
	if err != nil {
		t.Fatalf("ValidateHourly() error = %v", err)
	}
	if value.PrecipitationTiming != "" {
		t.Fatalf("PrecipitationTiming = %q, want required empty value", value.PrecipitationTiming)
	}
}

func TestValidateHourlyRejectsInvalidInput(t *testing.T) {
	tests := []struct {
		name string
		in   string
		want string
	}{
		{
			name: "malformed",
			in:   `{`,
			want: "decode hourly generated text",
		},
		{
			name: "unknown field",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled.","extra":"value"}`,
			want: "unsupported field",
		},
		{
			name: "missing summary",
			in:   `{"forecast_discussion":"A front will keep the region unsettled."}`,
			want: "summary is required",
		},
		{
			name: "blank forecast discussion",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"  "}`,
			want: "forecast discussion is required",
		},
		{
			name: "missing precipitation timing",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled."}`,
			want: "precipitation timing is required",
		},
		{
			name: "null precipitation timing",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled.","precipitation_timing":null}`,
			want: "precipitation timing must be a string",
		},
		{
			name: "retired confidence field rejected",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled.","precipitation_timing":"","confidence":"Medium"}`,
			want: "unsupported field",
		},
		{
			name: "old timing field rejected",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled.","timing":"Late morning."}`,
			want: "unsupported field",
		},
		{
			name: "old impacts field rejected",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled.","impacts":"Brief downpours."}`,
			want: "unsupported field",
		},
		{
			name: "multiple values",
			in:   `{"summary":"Storm chances increase.","forecast_discussion":"A front will keep the region unsettled."} {}`,
			want: "multiple JSON values",
		},
	}
	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			_, err := ValidateHourly([]byte(test.in))
			if err == nil {
				t.Fatal("ValidateHourly() error = nil, want error")
			}
			if !strings.Contains(err.Error(), test.want) {
				t.Fatalf("ValidateHourly() error = %v, want %q", err, test.want)
			}
		})
	}
}