Verify the complete native CLI cutover and record roadmap completion
This commit is contained in:
@@ -2,8 +2,9 @@
|
||||
|
||||
## Status And Intent
|
||||
|
||||
Initial roadmap, prepared 2026-11-19. The product direction is agreed;
|
||||
implementation is underway. This document owns the target and product intent,
|
||||
Implementation and assembled acceptance verification are complete; see the
|
||||
[implementation plan](implementation.md) for evidence and selected releases.
|
||||
Initial roadmap prepared 2026-11-19. This document owns the target and product intent,
|
||||
incorporating the decisions in the [migration notepad](commandkit-notepad.md).
|
||||
The notepad remains the discussion
|
||||
record. The [Narratio proposal](narratio-feature-request.md) supplies consumer
|
||||
@@ -26,13 +27,13 @@ report shapes, and exit conventions are not compatibility constraints. Release
|
||||
migration guidance replaces a compatibility layer. Implementation may proceed
|
||||
in reviewable increments; this does not require shipping both interfaces.
|
||||
|
||||
## Current Baseline And Upstream References
|
||||
## Planning Baseline And Upstream References
|
||||
|
||||
Reviewed Scriptorium baseline: `5f32a4f2adb2d382a6cfce3a787ada4576be7705`.
|
||||
The module uses Go 1.27.0, PromptKit v0.23.3, and ConfigKit v1.2.1. CommandKit
|
||||
is not yet a dependency.
|
||||
At that baseline the module used Go 1.27.0, PromptKit v0.23.3, and ConfigKit
|
||||
v1.2.1, without CommandKit. The following table records the starting point.
|
||||
|
||||
| Current implementation | Migration work |
|
||||
| Baseline implementation | Migration work |
|
||||
| --- | --- |
|
||||
| `internal/adapter/cli` dispatches and parses commands, resolves configuration, builds engines and requests, writes diagnostics, and returns integer statuses. | Replace dispatch and shared CLI mechanics with CommandKit; retain application loading, request mapping, and effects through its extension points. |
|
||||
| `run` uses flag-based prompt selection and writes generated content; `--execution-report` writes an observer-derived Scriptorium report. | Adopt positional prompt selection, native request flags, and native result reporting. |
|
||||
@@ -44,8 +45,8 @@ is not yet a dependency.
|
||||
|
||||
The [current CLI](../cli.md), [configuration contract](../config.md),
|
||||
[adapter internals](../internal/adapters.md), and
|
||||
[subprocess contract](../integrations/subprocess.md) describe the starting
|
||||
behavior, not a compatibility checklist for this migration.
|
||||
[subprocess contract](../integrations/subprocess.md) now describe the implemented
|
||||
native interface, not the historical starting point or a compatibility layer.
|
||||
|
||||
The reviewed upstream combination is CommandKit v0.7.0, ckconfig v0.9.0,
|
||||
and ckprompt v0.10.0, documented at revision
|
||||
|
||||
@@ -723,6 +723,44 @@ current documentation links resolve. Migration examples match the built CLI.
|
||||
|
||||
## Stage 9: Verify The Complete Native Cutover
|
||||
|
||||
**Status: Complete.** Verified the assembled native CLI on Go 1.27.4 with
|
||||
`go test ./... -count=1`, `go test -race ./... -count=1`, `go vet ./...`,
|
||||
and `go build ./cmd/scriptorium`. Formatting, diff whitespace, module tidiness,
|
||||
shell syntax, maintained examples, and local Markdown links/anchors pass.
|
||||
The maintained discovery configuration now has an end-to-end controlled-provider
|
||||
test covering support/review inventories, requirements before artifacts exist,
|
||||
concrete validation, preview/run context agreement, and independent native app
|
||||
and framework comparisons. Existing checkout tests verify both optional entry
|
||||
spellings and discovery on later invocations. Additional checks cover rejected
|
||||
legacy surfaces, partial output, diagnostic delivery failure, and real child
|
||||
process interrupt/SIGTERM cancellation reaching a provider request.
|
||||
|
||||
Built Linux amd64 and arm64 with Go 1.27.4, `CGO_ENABLED=0`, `-trimpath`,
|
||||
and `-s -w` plus version/revision linker metadata. The amd64 binary reports
|
||||
the injected `verification` identity and full source revision
|
||||
`bd7136ceebbdc7498e9a768ce8abbe0cbb00318f`; arm64 was cross-built, not executed.
|
||||
The binary also exposes help, native scope discovery, and Bash/Zsh/Fish
|
||||
completion without loading configuration or contacting a provider.
|
||||
|
||||
Selected releases remain CommandKit v0.7.0
|
||||
(`b57bfe176cff05a892e6cb07ebb5f350239e55d4`), ckconfig v0.9.0
|
||||
(`9962368f0c1ea1f6ad010638e94621091105d745`), ckprompt v0.10.0
|
||||
(`c9a56e1b15f2169881a91fca4e1f4a1c475e057a`), ConfigKit v1.2.1
|
||||
(`51ef3144158db1a09fabdbd1c7ae59908c84923b`), and PromptKit v0.23.3
|
||||
(`804a4d32b23aa2e7973400bb0a322a7016574c9f`). Module and linked-runtime
|
||||
inspection confirms no replacements, workspace, vendoring, or linked maintainer
|
||||
tools; attribution follows the linked dependencies, including conditional
|
||||
Windows mousetrap. Public native adapters, request bindings, reporters,
|
||||
`RenderReport`, and typed outcomes remain the selected integration APIs.
|
||||
|
||||
The final implementation audit against this plan and ADRs 0004–0006 found no
|
||||
remaining required work. HTTP/report implementation and accepted ADRs remain
|
||||
unchanged; no compatibility surface, post-resolution config rewriting, extra
|
||||
readiness gate, workflow state, snapshot promise, or transactional delivery was
|
||||
added. Embedded framework configuration, dynamic-resource completion, the
|
||||
optional format accessor, and HTTP redesign remain outside this migration.
|
||||
No release was published and no commits were pushed.
|
||||
|
||||
1. Finish any deferred stage checks against the complete application. Use real
|
||||
ConfigKit, PromptKit, and CommandKit with deterministic provider substitutes
|
||||
at the external boundary. Tests remain offline and independent of real keys.
|
||||
|
||||
@@ -1,7 +1,8 @@
|
||||
# Prompt input requirements for Narratio
|
||||
|
||||
Status: the native interface and focused consumer scenarios are implemented.
|
||||
The [implementation plan](implementation.md) tracks final assembled verification.
|
||||
Status: the native interface and consumer acceptance scenarios are implemented
|
||||
and verified, including the assembled collection workflow. The
|
||||
[implementation plan](implementation.md) records the verification evidence.
|
||||
This proposal records Narratio's consumer needs and their mapping to the native
|
||||
interface; the [CLI contract](../cli.md) owns current behavior.
|
||||
The [CommandKit notepad](commandkit-notepad.md) records the migration decisions.
|
||||
|
||||
Reference in New Issue
Block a user