Protect PromptKit source and definition semantics

This commit is contained in:
2026-10-04 12:30:38 +00:00
parent 9ea9d0706d
commit c2e2b74f83
2 changed files with 391 additions and 3 deletions

View File

@@ -3,8 +3,8 @@
## Status, Baseline, And Authority
Planned on 2026-10-04 against Scriptorium
`82b0f231b6ba71328f65f9a501143b2eedbe5d9c`. Stages 1–7 are complete; stages
8–13 are pending.
`82b0f231b6ba71328f65f9a501143b2eedbe5d9c`. Stages 1–8 are complete; stages
9–13 are pending.
This plan is for a Luna coding agent: implement the stages in sequential order,
normally one stage per implementation prompt. The
[feature roadmap](promptkit.md) owns the target state, scope, and confirmed
@@ -466,7 +466,17 @@ contracts and shared operational state preserved.
## Stage 8: Protect Native Source And Definition Semantics At The App Boundary
Status: Pending. Depends on Stage 7.
Status: Complete. Focused CLI-boundary tests now protect same-group conflicts,
ordered overlays, empty sources, invalid lower values replaced before final
validation, malformed and invalid unused definitions, and combined framework
documents. Imported prompt content retains its source-relative resource origin
and construction-time capture while schema and request artifacts remain
preparation-time reads. Native backend/profile inheritance, null and empty-map
semantics, explicit numeric presence at the injected-client boundary, partial
profiles completed by request overrides, and literal whitespace/slash IDs are
covered. Existing full-feature adoption fixtures remain in place. Focused
adoption tests, `go test ./...`, `go test -race ./...`, `go vet ./...`, the CLI
build, `gofmt`, and `git diff --check` pass.
Files: a focused `internal/adapter/cli/framework_sources_test.go` and existing
adoption tests where they already own the behavior. Reuse migrated helpers.