From a2205db1526cf2629fa680979db2a98f2c006df7 Mon Sep 17 00:00:00 2001 From: Eric Rakestraw Date: Wed, 18 Nov 2026 19:20:55 +0000 Subject: [PATCH] Demonstrate independent collection discovery --- docs/roadmap/implementation.md | 2 + examples/config.discovery.yml | 2 + .../collections/review-repo/collection.yaml | 12 +++ .../review-repo/profiles/base.yaml | 3 + .../review-repo/prompts/answer.yaml | 8 ++ .../collections/support-repo/collection.yml | 20 +++++ .../collections/support-repo/other.yml | 2 + .../support-repo/profiles/base.yml | 4 + .../support-repo/profiles/fast.yml | 3 + .../support-repo/prompts/answer.md | 3 + .../support-repo/prompts/answer.yml | 12 +++ .../support-repo/prompts/summarize.yml | 8 ++ examples/discovery/framework.yml | 4 + internal/adapter/cli/discovery_test.go | 82 +++++++++++++++++++ 14 files changed, 165 insertions(+) create mode 100644 examples/config.discovery.yml create mode 100644 examples/discovery/collections/review-repo/collection.yaml create mode 100644 examples/discovery/collections/review-repo/profiles/base.yaml create mode 100644 examples/discovery/collections/review-repo/prompts/answer.yaml create mode 100644 examples/discovery/collections/support-repo/collection.yml create mode 100644 examples/discovery/collections/support-repo/other.yml create mode 100644 examples/discovery/collections/support-repo/profiles/base.yml create mode 100644 examples/discovery/collections/support-repo/profiles/fast.yml create mode 100644 examples/discovery/collections/support-repo/prompts/answer.md create mode 100644 examples/discovery/collections/support-repo/prompts/answer.yml create mode 100644 examples/discovery/collections/support-repo/prompts/summarize.yml create mode 100644 examples/discovery/framework.yml create mode 100644 internal/adapter/cli/discovery_test.go diff --git a/docs/roadmap/implementation.md b/docs/roadmap/implementation.md index aa2fc3c..5f79043 100644 --- a/docs/roadmap/implementation.md +++ b/docs/roadmap/implementation.md @@ -252,6 +252,8 @@ scaffolding, or conversation and coordination features. ## Stage 6: Demonstrate discovery of independent collection checkouts +**Status: Complete.** + 1. Add `examples/config.discovery.yml` selecting `./examples/discovery/framework.yml` as a file under `promptkit_sources`. The framework file declares two **optional** diff --git a/examples/config.discovery.yml b/examples/config.discovery.yml new file mode 100644 index 0000000..8aa2994 --- /dev/null +++ b/examples/config.discovery.yml @@ -0,0 +1,2 @@ +promptkit_sources: + - file: ./examples/discovery/framework.yml diff --git a/examples/discovery/collections/review-repo/collection.yaml b/examples/discovery/collections/review-repo/collection.yaml new file mode 100644 index 0000000..4c83504 --- /dev/null +++ b/examples/discovery/collections/review-repo/collection.yaml @@ -0,0 +1,12 @@ +config: + imports: + - path: profiles/base.yaml + destination: [collections, review, profiles] + placement: sequence-item + required: true + - path: prompts/answer.yaml + destination: [collections, review, prompts] + placement: sequence-item + required: true +collections: + review: {} diff --git a/examples/discovery/collections/review-repo/profiles/base.yaml b/examples/discovery/collections/review-repo/profiles/base.yaml new file mode 100644 index 0000000..a4fb592 --- /dev/null +++ b/examples/discovery/collections/review-repo/profiles/base.yaml @@ -0,0 +1,3 @@ +id: base +endpoint: https://example.invalid/v1 +model: review-example diff --git a/examples/discovery/collections/review-repo/prompts/answer.yaml b/examples/discovery/collections/review-repo/prompts/answer.yaml new file mode 100644 index 0000000..fedd771 --- /dev/null +++ b/examples/discovery/collections/review-repo/prompts/answer.yaml @@ -0,0 +1,8 @@ +id: answer +default_profile: review/base +messages: + - role: user + content: Review this material and report your findings. +output: + format: text + validation_mode: none diff --git a/examples/discovery/collections/support-repo/collection.yml b/examples/discovery/collections/support-repo/collection.yml new file mode 100644 index 0000000..ccd42d5 --- /dev/null +++ b/examples/discovery/collections/support-repo/collection.yml @@ -0,0 +1,20 @@ +config: + imports: + - path: profiles/base.yml + destination: [collections, support, profiles] + placement: sequence-item + required: true + - path: profiles/fast.yml + destination: [collections, support, profiles] + placement: sequence-item + required: true + - path: prompts/answer.yml + destination: [collections, support, prompts] + placement: sequence-item + required: true + - path: prompts/summarize.yml + destination: [collections, support, prompts] + placement: sequence-item + required: true +collections: + support: {} diff --git a/examples/discovery/collections/support-repo/other.yml b/examples/discovery/collections/support-repo/other.yml new file mode 100644 index 0000000..58748df --- /dev/null +++ b/examples/discovery/collections/support-repo/other.yml @@ -0,0 +1,2 @@ +repository_metadata: + purpose: This file is not a PromptKit framework input. diff --git a/examples/discovery/collections/support-repo/profiles/base.yml b/examples/discovery/collections/support-repo/profiles/base.yml new file mode 100644 index 0000000..f789b14 --- /dev/null +++ b/examples/discovery/collections/support-repo/profiles/base.yml @@ -0,0 +1,4 @@ +id: base +endpoint: https://example.invalid/v1 +model: support-example +temperature: 0.2 diff --git a/examples/discovery/collections/support-repo/profiles/fast.yml b/examples/discovery/collections/support-repo/profiles/fast.yml new file mode 100644 index 0000000..9454e05 --- /dev/null +++ b/examples/discovery/collections/support-repo/profiles/fast.yml @@ -0,0 +1,3 @@ +id: fast +extends: {id: base} +max_tokens: 256 diff --git a/examples/discovery/collections/support-repo/prompts/answer.md b/examples/discovery/collections/support-repo/prompts/answer.md new file mode 100644 index 0000000..bd71b8c --- /dev/null +++ b/examples/discovery/collections/support-repo/prompts/answer.md @@ -0,0 +1,3 @@ +Answer the support request using this transcript: + +{{input "transcript"}} diff --git a/examples/discovery/collections/support-repo/prompts/answer.yml b/examples/discovery/collections/support-repo/prompts/answer.yml new file mode 100644 index 0000000..d428406 --- /dev/null +++ b/examples/discovery/collections/support-repo/prompts/answer.yml @@ -0,0 +1,12 @@ +id: answer +default_profile: support/fast +inputs: + - name: transcript + required: true + content_type: text/markdown +messages: + - role: user + content_file: ./answer.md +output: + format: text + validation_mode: none diff --git a/examples/discovery/collections/support-repo/prompts/summarize.yml b/examples/discovery/collections/support-repo/prompts/summarize.yml new file mode 100644 index 0000000..d3f227d --- /dev/null +++ b/examples/discovery/collections/support-repo/prompts/summarize.yml @@ -0,0 +1,8 @@ +id: summarize +default_profile: support/fast +messages: + - role: user + content: Summarize the support request concisely. +output: + format: text + validation_mode: none diff --git a/examples/discovery/framework.yml b/examples/discovery/framework.yml new file mode 100644 index 0000000..fac9bfd --- /dev/null +++ b/examples/discovery/framework.yml @@ -0,0 +1,4 @@ +config: + imports: + - glob: collections/*/collection.yml + - glob: collections/*/collection.yaml diff --git a/internal/adapter/cli/discovery_test.go b/internal/adapter/cli/discovery_test.go new file mode 100644 index 0000000..d8738ad --- /dev/null +++ b/internal/adapter/cli/discovery_test.go @@ -0,0 +1,82 @@ +package cli + +import ( + "fmt" + "os" + "path/filepath" + "strings" + "testing" +) + +func TestCollectionCheckoutDiscoveryAcrossInvocations(t *testing.T) { + fixture, err := filepath.Abs(filepath.Join("..", "..", "..", "examples", "discovery")) + if err != nil { + t.Fatal(err) + } + for _, tc := range []struct { + name string + first string + second string + }{ + {name: "yml then yaml", first: "support-repo", second: "review-repo"}, + {name: "yaml then yml", first: "review-repo", second: "support-repo"}, + } { + t.Run(tc.name, func(t *testing.T) { + root := t.TempDir() + framework, err := os.ReadFile(filepath.Join(fixture, "framework.yml")) + if err != nil { + t.Fatal(err) + } + frameworkPath := filepath.Join(root, "framework.yml") + if err := os.WriteFile(frameworkPath, framework, 0o644); err != nil { + t.Fatal(err) + } + collections := filepath.Join(root, "collections") + if err := os.MkdirAll(collections, 0o755); err != nil { + t.Fatal(err) + } + install := func(name string) { + t.Helper() + if err := os.CopyFS(filepath.Join(collections, name), os.DirFS(filepath.Join(fixture, "collections", name))); err != nil { + t.Fatal(err) + } + } + config := writeAppConfigFile(t, fmt.Sprintf("promptkit_sources:\n - file: %q\n", frameworkPath)) + input := filepath.Join(root, "transcript.md") + if err := os.WriteFile(input, []byte("synthetic discovery transcript"), 0o644); err != nil { + t.Fatal(err) + } + args := func(name string) []string { + if name == "support-repo" { + return []string{"--config", config, "--prompt", "support/answer", "--profile", "support/fast", "--input", "transcript=" + input} + } + return []string{"--config", config, "--prompt", "review/answer", "--profile", "review/base"} + } + check := func(name string) { + t.Helper() + code, out, stderr := runCLICommand(t, renderCommand, args(name)) + if code != ExitOK { + t.Fatalf("render %s: code=%d stderr=%s", name, code, stderr) + } + if name == "support-repo" { + for _, want := range []string{"prompt: support/answer", "selected_profile_id: support/fast", "model: support-example", "max_tokens: 256", "Answer the support request", "synthetic discovery transcript"} { + if !strings.Contains(out, want) { + t.Fatalf("missing %q: %s", want, out) + } + } + } else if !strings.Contains(out, "prompt: review/answer") || !strings.Contains(out, "model: review-example") || !strings.Contains(out, "Review this material") { + t.Fatalf("unexpected review render: %s", out) + } + } + install(tc.first) + check(tc.first) + code, _, _ := runCLICommand(t, renderCommand, args(tc.second)) + if code != ExitRuntimeError { + t.Fatal("uninstalled collection unexpectedly selected") + } + install(tc.second) + check(tc.first) + check(tc.second) + }) + } +}