Clarify source selector clearing behavior
This commit is contained in:
@@ -15,7 +15,8 @@ validation. PromptKit v0.12.0 retains old-path ConfigKit v0.5.0 for framework
|
||||
sources and captured inspection. Each generation's paths, diagnostics, and
|
||||
writers remain separate; the shared YAML dependency stays at v4.0.0-rc.6.
|
||||
No runtime correctness defect, unnecessary compatibility layer, or unrequested
|
||||
runtime restriction was found. One documentation contract overstatement remains.
|
||||
runtime restriction was found. One documentation contract overstatement was
|
||||
identified; its remediation is complete below.
|
||||
|
||||
| Stage | Review result |
|
||||
| --- | --- |
|
||||
@@ -24,12 +25,12 @@ runtime restriction was found. One documentation contract overstatement remains.
|
||||
| 3: Adapter type separation | Application and framework values use their respective public types; structured errors and warnings reach the matching native writer. |
|
||||
| 4: Configuration coverage | Tests cover discovery, optional/required imports, placement, authored collections, CLI timing, presence, normalization, and inspection without new application identity rules. |
|
||||
| 5: Integration and examples | New application controls coexist with old framework controls; ordinary, composed, inheritance, and collection examples work, including overlay retention. |
|
||||
| 6: Documentation and attribution | Dependency/toolchain ownership and both notices are aligned; selector-clearing language still overstates the native contract (R6). |
|
||||
| 7: End-state validation | Independent tests, builds, example commands, dependency checks, and document checks passed; R6 must be resolved for complete documentation alignment. |
|
||||
| 6: Documentation and attribution | Dependency/toolchain ownership and both notices are aligned; selector-clearing wording is now corrected (R6). |
|
||||
| 7: End-state validation | Independent tests, builds, example commands, dependency checks, and document checks passed; R6's documentation alignment is now complete. |
|
||||
|
||||
### R6: Qualify Selector Clearing By The Effective Collection Policy
|
||||
|
||||
Priority: P3 (low). Status: Open.
|
||||
Priority: P3 (low). Status: Complete.
|
||||
|
||||
Locations: `docs/config.md:62–64` and `docs/config.md:108–109`.
|
||||
|
||||
@@ -76,6 +77,17 @@ Acceptance: the selector and overlay descriptions agree with the pinned native
|
||||
contract and the reproduced empty/null cases. Check the affected links and any
|
||||
added example. No production-code change or new runtime guarantee is required.
|
||||
|
||||
Resolution (2026-11-18): the configuration reference now distinguishes the final
|
||||
resolved selector list from individual source contributions. It explains
|
||||
omission, empty lists, nulls, and explicit replacement under the effective
|
||||
collection policy, qualifies overlay null handling, and links to the pinned
|
||||
upstream policy-lifetime contract. Runtime behavior and CLI whole-list overrides
|
||||
are unchanged. All 15 temporary selector-policy checks passed against a fresh
|
||||
build: omitted/empty/null/explicit-replace overlays under ordinary replacement,
|
||||
append, and upsert, plus CLI whole-list replacement and no-generation rendering
|
||||
under each policy. The pinned document and anchor and diff whitespace were
|
||||
checked. No provider was contacted; no production code or tests changed.
|
||||
|
||||
### Independent Review Verification
|
||||
|
||||
- `go test -count=1 ./...`, `go test -race -count=1 ./...`, and `go vet ./...`
|
||||
|
||||
Reference in New Issue
Block a user