Complete PromptKit adoption audit
This commit is contained in:
@@ -3,12 +3,11 @@
|
|||||||
## Status, Baseline, And Authority
|
## Status, Baseline, And Authority
|
||||||
|
|
||||||
Planned on 2026-10-04 against Scriptorium
|
Planned on 2026-10-04 against Scriptorium
|
||||||
`82b0f231b6ba71328f65f9a501143b2eedbe5d9c`. Stages 1–12 are complete; stage
|
`82b0f231b6ba71328f65f9a501143b2eedbe5d9c`. All thirteen stages are complete;
|
||||||
13 is pending.
|
the implementation was delivered after the full audit passed on 2026-10-04.
|
||||||
This plan is for a Luna coding agent: implement the stages in sequential order,
|
Separate release preparation remains pending. The
|
||||||
normally one stage per implementation prompt. The
|
|
||||||
[feature roadmap](promptkit.md) owns the target state, scope, and confirmed
|
[feature roadmap](promptkit.md) owns the target state, scope, and confirmed
|
||||||
product decisions; this document owns the steps and implementation status.
|
product decisions; this document records implementation steps and status.
|
||||||
|
|
||||||
The baseline selects PromptKit v0.11.2 and ConfigKit v0.5.0. Adopt published
|
The baseline selects PromptKit v0.11.2 and ConfigKit v0.5.0. Adopt published
|
||||||
PromptKit v0.12.0 at `4b8169da286917fde7875425bb32b799b12c6af3`, with its selected
|
PromptKit v0.12.0 at `4b8169da286917fde7875425bb32b799b12c6af3`, with its selected
|
||||||
@@ -721,7 +720,24 @@ historical records and unrelated policy baselines retain their meaning.
|
|||||||
|
|
||||||
## Stage 13: Complete The Adoption Audit And Record The Release Handoff
|
## Stage 13: Complete The Adoption Audit And Record The Release Handoff
|
||||||
|
|
||||||
Status: Pending. Depends on Stage 12.
|
Status: Complete. The audit confirmed native ordered Promptkit sources,
|
||||||
|
keyed definitions and presence, source-origin resource capture, eager final
|
||||||
|
validation, request/runtime boundaries, all four captured framework inspection
|
||||||
|
operations with redaction limited to that family, and shared server capacity.
|
||||||
|
No removed API or application schema, legacy loader, direct catalog/internal
|
||||||
|
import, module replacement, or workspace remains in executable code or
|
||||||
|
maintained inputs. The complete Go baseline passed (`go test ./...`,
|
||||||
|
`go test -race ./...`, `go vet ./...`, `gofmt` check, and a build outside the
|
||||||
|
worktree); the module graph and attribution links were reviewed. Every
|
||||||
|
maintained application config passed both application and framework validation;
|
||||||
|
both render scripts, the composed-overlay render, inheritance render, all four
|
||||||
|
framework inspection operations with the required backend endpoint pointer,
|
||||||
|
and existing prompt/profile inspection passed offline without provider
|
||||||
|
traffic. The final documentation and whitespace checks passed. The breaking
|
||||||
|
configuration and definition adoption requires a new pre-1.0 minor release and
|
||||||
|
may share that release with the completed ConfigKit adoption. Version choice,
|
||||||
|
release notes, publication, and roadmap retirement are subsequent release
|
||||||
|
preparation, and no release is claimed here.
|
||||||
|
|
||||||
Files: small genuine corrections exposed by validation, this plan, and the
|
Files: small genuine corrections exposed by validation, this plan, and the
|
||||||
feature roadmap's completion status. Release files/automation remain out of scope.
|
feature roadmap's completion status. Release files/automation remain out of scope.
|
||||||
|
|||||||
@@ -3,9 +3,11 @@
|
|||||||
## Status And Intent
|
## Status And Intent
|
||||||
|
|
||||||
Drafted on 2026-10-03; source-selection and framework-inspection decisions
|
Drafted on 2026-10-03; source-selection and framework-inspection decisions
|
||||||
confirmed by the maintainer on 2026-10-04. No implementation is delivered by
|
confirmed by the maintainer on 2026-10-04. The PromptKit v0.12.0 adoption has
|
||||||
this document. No significant decisions remain open within this scope;
|
been implemented and delivered after the complete audit passed on 2026-10-04.
|
||||||
implementation sequencing and release preparation remain separate work.
|
This document remains target and decision context, not an implementation-stage
|
||||||
|
log. Release preparation remains separate; no release version has been
|
||||||
|
selected or published. No significant decisions remain open within this scope.
|
||||||
|
|
||||||
Adopt PromptKit's ConfigKit-native configuration boundary while preserving
|
Adopt PromptKit's ConfigKit-native configuration boundary while preserving
|
||||||
Scriptorium's simple, request-independent execution model. As established in
|
Scriptorium's simple, request-independent execution model. As established in
|
||||||
|
|||||||
@@ -626,7 +626,7 @@ server:
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestParseServeArgsWithConfigProvidesRequiredDirectoriesAndAddr(t *testing.T) {
|
func TestParseServeArgsWithConfigUsesConfiguredSourcesAndAddr(t *testing.T) {
|
||||||
configPath := writeAppConfigFile(t, `
|
configPath := writeAppConfigFile(t, `
|
||||||
promptkit_sources:
|
promptkit_sources:
|
||||||
- directory: ./from-config/prompts
|
- directory: ./from-config/prompts
|
||||||
@@ -918,7 +918,7 @@ func TestRunCommandVarsOptional(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestRunCommandSucceedsWithPromptAndProfileDirsFromConfig(t *testing.T) {
|
func TestRunCommandSucceedsWithPromptAndProfileSourcesFromConfig(t *testing.T) {
|
||||||
lib := newCLITestLibrary(t)
|
lib := newCLITestLibrary(t)
|
||||||
inputPath := lib.writeInputFile(t, "transcript.md", "hello")
|
inputPath := lib.writeInputFile(t, "transcript.md", "hello")
|
||||||
|
|
||||||
@@ -1033,7 +1033,7 @@ func TestRenderCommandExplicitZeroTemperatureReachesEffectiveSettings(t *testing
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestRenderCommandSucceedsWithPromptAndProfileDirsFromConfig(t *testing.T) {
|
func TestRenderCommandSucceedsWithPromptAndProfileSourcesFromConfig(t *testing.T) {
|
||||||
lib := newCLITestLibrary(t)
|
lib := newCLITestLibrary(t)
|
||||||
inputPath := lib.writeInputFile(t, "transcript.md", "hello transcript")
|
inputPath := lib.writeInputFile(t, "transcript.md", "hello transcript")
|
||||||
|
|
||||||
@@ -1822,17 +1822,17 @@ func TestPromptkitProfileInspectionResolvesSupportedTargets(t *testing.T) {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
configWithoutPromptDir := writeAppConfigFile(t, fmt.Sprintf("promptkit_sources:\n - directory: %q\n - file: %q\n",
|
configWithoutPromptSource := writeAppConfigFile(t, fmt.Sprintf("promptkit_sources:\n - directory: %q\n - file: %q\n",
|
||||||
filepath.Join(fixtureRoot, "profiles"),
|
filepath.Join(fixtureRoot, "profiles"),
|
||||||
filepath.Join(fixtureRoot, "framework", "backends.yml"),
|
filepath.Join(fixtureRoot, "framework", "backends.yml"),
|
||||||
))
|
))
|
||||||
code, _, stderr := runCLICommand(t, inspectCommand, []string{
|
code, _, stderr := runCLICommand(t, inspectCommand, []string{
|
||||||
"profile",
|
"profile",
|
||||||
"--config", configWithoutPromptDir,
|
"--config", configWithoutPromptSource,
|
||||||
"--profile", "custom-derived",
|
"--profile", "custom-derived",
|
||||||
})
|
})
|
||||||
if code != ExitOK {
|
if code != ExitOK {
|
||||||
t.Fatalf("profile inspection unexpectedly required a prompt directory: %q", stderr)
|
t.Fatalf("profile inspection unexpectedly required a prompt source: %q", stderr)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1991,7 +1991,7 @@ func TestProfileInspectionHonorsDirectoryPrecedenceOutputAndFailures(t *testing.
|
|||||||
t.Fatalf("read profile inspection output: %v", err)
|
t.Fatalf("read profile inspection output: %v", err)
|
||||||
}
|
}
|
||||||
if !strings.Contains(string(output), `"model": "override-model"`) || !strings.Contains(string(output), `"backend_id": ""`) {
|
if !strings.Contains(string(output), `"model": "override-model"`) || !strings.Contains(string(output), `"backend_id": ""`) {
|
||||||
t.Fatalf("profile directory override was not used: %s", output)
|
t.Fatalf("profile source override was not used: %s", output)
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, profileID := range []string{"missing", "invalid"} {
|
for _, profileID := range []string{"missing", "invalid"} {
|
||||||
@@ -2237,7 +2237,7 @@ func TestRenderCommandPromptDefaultProfileWorksThroughCLIPath(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestRenderCommandUsesBuiltInProfileWithoutProfileDir(t *testing.T) {
|
func TestRenderCommandUsesBuiltInProfileWithoutCustomProfileSource(t *testing.T) {
|
||||||
t.Setenv("OPENROUTER_API_KEY", "test-key")
|
t.Setenv("OPENROUTER_API_KEY", "test-key")
|
||||||
lib := newCLITestLibrary(t)
|
lib := newCLITestLibrary(t)
|
||||||
inputPath := lib.writeInputFile(t, "transcript.md", "hello")
|
inputPath := lib.writeInputFile(t, "transcript.md", "hello")
|
||||||
|
|||||||
Reference in New Issue
Block a user