package contracts import ( "errors" "reflect" "strings" "testing" ) func TestCandidateAssessmentKeepsGuidanceSeparateAndOrdered(t *testing.T) { unavailable := errors.New("provider unavailable") assessment := CandidateAssessment{Validators: []ValidatorAssessment{ {ValidatorName: "shape", Decision: AssessmentRejected, Result: ValidationResult{ReasonCode: "shape-code", Message: "operator prose", CorrectionGuidance: "Return the required shape."}}, {ValidatorName: "coverage", Decision: AssessmentRejected, Result: ValidationResult{ReasonCode: "coverage-code", CorrectionGuidance: "Include all supported events."}}, {ValidatorName: "duplicate", Decision: AssessmentRejected, Result: ValidationResult{CorrectionGuidance: "Return the required shape."}}, {ValidatorName: "remote", Decision: AssessmentUnavailable, Failure: &ValidationUnavailableError{Cause: unavailable}}, }} guidance, err := assessment.Guidance() if err != nil || !reflect.DeepEqual(guidance, []string{"Return the required shape.", "Include all supported events."}) { t.Fatalf("guidance = %#v, %v", guidance, err) } if assessment.Accepted() || !errors.Is(assessment.Err(), unavailable) { t.Fatalf("assessment = %#v, error = %v", assessment, assessment.Err()) } for _, diagnostic := range []string{"shape-code", "coverage-code", "operator prose", "provider unavailable"} { if strings.Contains(strings.Join(guidance, "\n"), diagnostic) { t.Fatalf("diagnostic became correction instructions: %q", diagnostic) } } } func TestCandidateAssessmentRequiresEveryApproval(t *testing.T) { if !(CandidateAssessment{}).Accepted() { t.Fatal("empty validator chain rejected") } for _, decision := range []AssessmentDecision{AssessmentApproved, AssessmentRejected, AssessmentFailed, AssessmentUnavailable, ""} { assessment := CandidateAssessment{Validators: []ValidatorAssessment{{Decision: AssessmentApproved}, {Decision: decision}}} if got, want := assessment.Accepted(), decision == AssessmentApproved; got != want { t.Fatalf("%s accepted = %t", decision, got) } } } func TestCandidateAssessmentDoesNotInventMissingGuidance(t *testing.T) { for _, text := range []string{"", " \t\n"} { assessment := CandidateAssessment{Validators: []ValidatorAssessment{{ValidatorName: "validator", Decision: AssessmentRejected, Result: ValidationResult{ReasonCode: "opaque", Message: "not instructions", CorrectionGuidance: text}}}} if _, err := assessment.Guidance(); err == nil { t.Fatal("missing actionable guidance accepted") } } for _, decision := range []AssessmentDecision{AssessmentApproved, AssessmentFailed, AssessmentUnavailable} { guidance, err := (CandidateAssessment{Validators: []ValidatorAssessment{{Decision: decision, Result: ValidationResult{Message: "not instructions"}}}}).Guidance() if err != nil || len(guidance) != 0 { t.Fatalf("nonrejection guidance = %#v, %v", guidance, err) } } }