From c9744ad2e65228ccae5111a6f96eeb88c41983ce Mon Sep 17 00:00:00 2001 From: Eric Rakestraw Date: Tue, 17 Nov 2026 21:00:27 +0000 Subject: [PATCH] Complete ConfigKit upgrade verification --- docs/roadmap/implementation.md | 9 ++++++ .../config/collection_composition_test.go | 28 +++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/docs/roadmap/implementation.md b/docs/roadmap/implementation.md index 44641090..42e8acfe 100644 --- a/docs/roadmap/implementation.md +++ b/docs/roadmap/implementation.md @@ -467,6 +467,15 @@ Prompt size: focused internal/integration docs and dependency notices. ## Stage 11 — Verify The Entire Target And Finish The Sprint +**Complete.** The final offline `go test ./...`, `go vet ./...`, and +`go mod tidy -diff` pass with Go 1.27.0 and `GOWORK=off`; the test run permits +local HTTP listeners. A temporary native build validates the maintained minimal, +complete, and development selections and both application and PromptKit +inspection reports without provider calls. Module inspection confirms ConfigKit +v1.2.0 and v0.5.0, PromptKit v0.12.0, and YAML v4.0.0-rc.6. A final direct +identified-record inheritance regression supplements the composition coverage. +No production inference, publication, or deferred dependency upgrade was performed. + Goal: prove all feature-roadmap acceptance on the completed implementation. Work: diff --git a/internal/core/config/collection_composition_test.go b/internal/core/config/collection_composition_test.go index 0ab36b01..2e45c203 100644 --- a/internal/core/config/collection_composition_test.go +++ b/internal/core/config/collection_composition_test.go @@ -179,6 +179,34 @@ pipelines: } } +func TestIdentifiedStepRecordInheritance(t *testing.T) { + main := filepath.Join(t.TempDir(), "main.yml") + if err := os.WriteFile(main, []byte(`version: 5 +pipelines: + session: + input: {module: input} + steps: + - id: parent + references: {source: {path: ./shared.txt}} + - id: child + extends: {id: parent} + artifacts: {result: {extract: {module: extract}}} +`), 0600); err != nil { + t.Fatal(err) + } + loaded, err := Load(main, LoadOptions{}) + if err != nil { + t.Fatal(err) + } + steps := loaded.Config.Pipelines["session"].Steps + if len(steps) != 2 || steps[1].ID != "child" || steps[1].References["source"].Path != filepath.Join(filepath.Dir(main), "shared.txt") { + t.Fatalf("inherited step = %#v", steps) + } + if err := loaded.Config.Validate(); err != nil { + t.Fatalf("validate inherited steps: %v", err) + } +} + func TestEmptyStepOperationsAndOptionalImports(t *testing.T) { root := t.TempDir() main := filepath.Join(root, "main.yml")