Cache source directories during configuration normalization

This commit is contained in:
2026-11-18 00:36:26 +00:00
parent 1c93aa0947
commit 76364a7b7e
4 changed files with 81 additions and 10 deletions

View File

@@ -1,5 +1,13 @@
# Configuration Upgrade Review Remediation
All eight findings were completed on 2026-11-18, with one commit per finding.
Assessment and evidence paragraphs below retain their review-time context;
each finding's completion marker records the implemented resolution.
Final verification passed: full offline tests, vet, race checks for configuration,
CLI and LLM packages, module tidy consistency, a native temporary build, and
credential-free minimal/complete/development configuration and inspection checks.
The earlier PromptKit findings below retain their original scope and status.
The ConfigKit 1.2.0 review and subsequent focused audits appear below; they
do not reopen or attribute earlier issues to that upgrade.
@@ -444,7 +452,12 @@ retain their earlier scope and status.
### Finding CK-4 — Memoize Source Directories During Path Normalization
Priority: P3. Category: efficiency/scalability opportunity. Status: open.
Priority: P3. Category: efficiency/scalability opportunity. Status: complete.
Completed 2026-11-18: source-directory results, including missing/non-file
results, are memoized by source ID in load-local state. Main-directory setup
shares the lookup. Cache-sharing/isolation and existing path-origin tests pass;
the full offline suite, vet, race, and tidy checks pass. Path policy is unchanged.
Affected stages: 2–3; exposed by adoption of richer ConfigKit source metadata.
`internal/core/config/document_paths.go:144–176`, `documentPathBase`, calls