Record publish defaults and destinations at field level

This commit is contained in:
2026-11-18 04:03:33 +00:00
parent 69dc5cc8ec
commit e93fb8d5ab
3 changed files with 34 additions and 12 deletions

View File

@@ -200,19 +200,12 @@ func resolvePipelineConfig(cfg *PipelineConfig, resolution *configkit.Resolution
}
}
if cfg.Publish != nil {
defaultedOutput := false
for index := range cfg.Publish.Outputs {
output := cfg.Publish.Outputs[index]
path := configkit.Keys("publish", "outputs").Index(index).Key("required")
if !resolution.IsExplicit(path) {
defaultedOutput = true
}
configkit.Default(resolution, path, &output.Required, boolPtr(true), "publish outputs are required by default")
cfg.Publish.Outputs[index] = output
}
if defaultedOutput {
resolution.RecordDerivedDefault(configkit.Keys("publish", "outputs"), "publish output entry defaults")
}
}
before := cloneNotariusForResolution(cfg.Notarius)
if err := NormalizePipelineConfig(cfg); err != nil {
@@ -229,11 +222,6 @@ func resolvePipelineConfig(cfg *PipelineConfig, resolution *configkit.Resolution
configkit.Normalize(resolution, configkit.Keys("publish", "outputs").Index(derived.index).Key("dest"), &output.Dest, derived.dest, "derived from publish source")
cfg.Publish.Outputs[derived.index] = output
}
if len(destinations) > 0 {
// ConfigKit compares sequences atomically; child records alone do not
// cover the list mutation when requiredness was already explicit.
resolution.RecordNormalization(configkit.Keys("publish", "outputs"), "derived publish destinations")
}
}
return nil
}

View File

@@ -0,0 +1,31 @@
package config
import (
"testing"
configkit "go.maximumdirect.net/configkit"
)
func TestPublishFieldResolutionPreservesUnchangedSourceHistory(t *testing.T) {
root := writePipelineFixture(t, t.TempDir(), "pipeline.yml", "publish:\n outputs:\n - source: narratio.transcript.final\n")
cfg, err := LoadPipeline(root)
if err != nil {
t.Fatal(err)
}
output := cfg.Publish.Outputs[0]
if output.Dest == "" || output.Required == nil || !*output.Required {
t.Fatalf("missing resolved defaults: %#v", output)
}
base := configkit.Keys("publish", "outputs").Index(0)
for _, change := range cfg.resolution.configkitMetadata.History(base.Key("source")) {
if change.Origin.Layer == configkit.LayerResolution {
t.Fatalf("untouched source has resolution history: %#v", change)
}
}
for _, field := range []string{"required", "dest"} {
info, ok := cfg.resolution.configkitMetadata.Lookup(base.Key(field))
if !ok || info.Origin.Layer != configkit.LayerResolution {
t.Fatalf("missing field origin for %s: %#v", field, info)
}
}
}