Classify invalid artifact relations as input errors

This commit is contained in:
2026-11-20 13:48:55 +00:00
parent 672b7f0ebd
commit 7e45ffca43
5 changed files with 71 additions and 2 deletions

View File

@@ -114,11 +114,21 @@ func TestOperationOutcomePreservesCausesAndOperationalPrecedence(t *testing.T) {
}
input := &inputError{message: "invalid identity selection"}
operational := errors.New("storage unavailable")
_, catalogInput := config.DeriveArtifactCatalog(&config.PipelineConfig{Scriptorium: &config.ScriptoriumConfig{Artifacts: map[string]config.ScriptoriumArtifactConfig{
"result": {OutputPath: "artifacts/result.md", DependsOn: []string{"missing"}},
}}}, config.ResolvedParty{})
var catalogError *config.ArtifactCatalogInputError
if !errors.As(catalogInput, &catalogError) || errors.Unwrap(catalogError) == nil {
t.Fatalf("catalog validation lost its typed input cause: %v", catalogInput)
}
for _, tc := range []struct {
err error
status int
}{
{nil, 0}, {input, 2}, {invalid, 2},
{catalogInput, 2},
{errors.Join(catalogInput, operational), 1},
{errors.Join(catalogInput, context.Canceled), 1},
{&config.SessionIdentityError{Source: "session.yml", Field: "session_id", Expected: "one", Actual: "two"}, 2},
{fmt.Errorf("request: %w", errors.Join(input, invalid)), 2},
{errors.Join(input, operational), 1},