Stream verified prepared inputs into publication archives
This commit is contained in:
@@ -10,7 +10,7 @@ documentation, focused diagnostic reproductions, and repository checks.
|
||||
An integration-focused follow-up reviewed the same implementation at
|
||||
`bccf03a99f45c2b9b342412b85f70e356663df61`, tracing each stage into existing
|
||||
command, preparation, publication, restore, and inspection workflows. Items
|
||||
5–6 are additional findings from that pass; items 1–4 remain outstanding.
|
||||
5–6 were additional findings from that pass; items 1–4 were outstanding then.
|
||||
|
||||
An algorithm-focused pass reviewed all twelve stages at
|
||||
`583c5bdf1bc8f0af8ec2e257bcb03ecccbf283b1`. Items 7–10 are refactoring
|
||||
@@ -18,9 +18,8 @@ opportunities for consideration. Complexity follows the code and the selected
|
||||
ConfigKit v1.2.1 implementation; no operational timings or benchmarks were
|
||||
collected. The pass preserves algorithms expressly chosen by the plan.
|
||||
|
||||
The native configuration architecture is substantially implemented. The items
|
||||
below record the six required corrections and four additional algorithmic
|
||||
opportunities. This document implements none of their fixes.
|
||||
All ten items below are now complete. The original findings are retained with
|
||||
completion annotations; final verification is recorded at the end of this file.
|
||||
|
||||
## 1. P2: Distinguish effective resource origins from superseded history
|
||||
|
||||
@@ -332,6 +331,10 @@ temporary-file cleanup. Confirm that unrelated historical keys are not enumerate
|
||||
|
||||
## 10. P3: Stream prepared-input archival copies
|
||||
|
||||
Status: Complete. Verified descriptors stream through the existing atomic-reader
|
||||
copy helper, with unchanged-destination reuse. Archive bytes, checksums, modes,
|
||||
and tamper rejection are covered; full ordinary and race suites pass.
|
||||
|
||||
Stage: 7.
|
||||
|
||||
Location: `internal/stage/publish_sources.go:29–64`,
|
||||
@@ -356,7 +359,7 @@ validation, failure handling, and immutable publication behavior. Existing
|
||||
reader-copy and prepared-session publication tests provide suitable behavioral
|
||||
coverage; allocation or wall-clock thresholds are unnecessary.
|
||||
|
||||
## Stage-by-stage disposition
|
||||
## Stage-by-stage disposition at the initial reviews
|
||||
|
||||
| Stage | Review result |
|
||||
| --- | --- |
|
||||
@@ -436,3 +439,21 @@ and under `-race`. Focused configuration, file-reader copy, S3 opened-object
|
||||
metadata, native inspection, and prepared-session publication checks passed on
|
||||
Go 1.27.4. No performance data, timing assertions, benchmark gates, or application
|
||||
changes were introduced.
|
||||
|
||||
## Completed remediation validation
|
||||
|
||||
Each issue was addressed in order and committed with its completion marker.
|
||||
Using Go 1.27.4 on the completed implementation:
|
||||
|
||||
- `go test ./...` passed.
|
||||
- `go test -race ./...` passed, including the corrected restore contention test.
|
||||
- `go vet ./...`, `go build ./...`, and `go mod tidy -diff` passed.
|
||||
- Focused regressions cover effective provenance, field-level publish history,
|
||||
local/imported initialization, standalone remote input, remote authoring after
|
||||
publication, enumeration-free loading, and verified streaming archives.
|
||||
- Documentation checks and `git diff --check` passed.
|
||||
|
||||
Remote session authoring updates affect future command inputs. Committed
|
||||
publication objects remain immutable and restore continues to validate its
|
||||
pointer-selected remote state. Inspection caches are scoped to one operation;
|
||||
ConfigKit remains the authority for configuration and provenance.
|
||||
|
||||
Reference in New Issue
Block a user