Use native configuration validation and diagnostics

This commit is contained in:
2026-11-20 15:22:57 +00:00
parent 7e45ffca43
commit 39b4bddbc9
47 changed files with 351 additions and 308 deletions

View File

@@ -175,17 +175,18 @@ func TestConfigurationInspectionExplainsIdentityMismatches(t *testing.T) {
{"config", "show", "--scope", "campaign", "--campaign-file", campaign, "--campaign", "other-campaign"},
{"config", "show", "--scope", "session", "--campaign-file", campaign, "--session-file", session, "--session", "other-session"},
{"config", "diff", "--scope", "campaign", "--campaign-file", campaign, "--against-campaign-file", campaign, "--against-campaign", "other-campaign"},
{"config", "diff", "--scope", "session", "--campaign-file", campaign, "--session-file", session, "--against-campaign-file", campaign, "--against-session-file", session, "--against-session", "other-session"},
} {
var output, diagnostics bytes.Buffer
result := Execute(context.Background(), args, commandkit.Streams{Out: &output, Err: &diagnostics})
var identity *config.SessionIdentityError
if result.Status == 0 || !errors.As(result.Cause, &identity) {
var identity *configkit.LoadError
if result.Status != 2 || !errors.As(result.Cause, &identity) {
t.Fatalf("%v: identity cause missing: %#v", args, result)
}
if output.Len() != 0 || !strings.Contains(diagnostics.String(), identity.Field) || !strings.Contains(diagnostics.String(), identity.Expected) || !strings.Contains(diagnostics.String(), identity.Actual) {
if output.Len() != 0 || !strings.Contains(diagnostics.String(), "mismatch") || !strings.Contains(diagnostics.String(), "other-") || !strings.Contains(diagnostics.String(), "validate.error") {
t.Fatalf("%v: assertion not explained: %s", args, diagnostics.String())
}
if identity.Field == "campaign_id" && strings.Contains(diagnostics.String(), "session file") {
if strings.Contains(diagnostics.String(), "campaign_id") && strings.Contains(diagnostics.String(), "session file") {
t.Fatalf("campaign assertion mislabeled: %s", diagnostics.String())
}
}