Remove application credential substitution
This commit is contained in:
@@ -11,11 +11,10 @@ CLI wiring, and maintained examples. Definitions of behavior belong to the
|
||||
applicable. Preserve the precedence defined in the
|
||||
[configuration contract](../config.md#loading-and-composition), including the
|
||||
distinct validation and effective-config commands.
|
||||
3. Update redaction when secrets are involved.
|
||||
4. Review configuration tests and related CLI tests for precedence, validation,
|
||||
3. Review configuration tests and related CLI tests for precedence, validation,
|
||||
and source-specific behavior. Add or adjust tests for the changed contract
|
||||
according to the [testing policy](../policy/testing.md).
|
||||
5. Update the configuration reference and affected [examples](../../examples/).
|
||||
4. Update the configuration reference and affected [examples](../../examples/).
|
||||
|
||||
## Changing CLI Behavior
|
||||
|
||||
@@ -51,8 +50,7 @@ Select checks according to the [testing policy](../policy/testing.md):
|
||||
- Process/output changes: verify stdout, stderr, exit, output-file, and report
|
||||
behavior against the [CLI contract](../cli.md) and
|
||||
[subprocess guidance](../integrations/subprocess.md), including failures.
|
||||
- Report or diagnostics changes: review [report assembly tests and redaction
|
||||
checks](diagnostics-reporting.md#key-tests), metadata fields, and artifact paths.
|
||||
- Report or diagnostics changes: review [report assembly tests](diagnostics-reporting.md#key-tests), metadata fields, and artifact paths.
|
||||
- Schema or serialization changes: review [output-schema tests](output-schemas.md#key-tests)
|
||||
and `internal/core/schema` tests, including supported formats and rejection of
|
||||
unsupported schemas.
|
||||
|
||||
@@ -12,8 +12,7 @@ work-unit errors, separate run errors, and one recovery per successful logical
|
||||
operation. Reports order stages, sections, validators, and batches by semantic
|
||||
identity, never concurrent completion time. The core reporting package owns
|
||||
Audita's versioned YAML DTOs, fixed Markdown rendering, and brief CLI
|
||||
completion formatter. YAML redaction walks serialized string nodes so numeric
|
||||
and boolean values retain their types. Ordinary reports omit raw causes,
|
||||
completion formatter. Reports encode the typed documents directly to YAML. Ordinary reports omit raw causes,
|
||||
transcript text, complete decisions, and token/timing payloads.
|
||||
Validation operations with unavailable decisions report only affected requested
|
||||
indices, even when other candidates in the batch continue. Ignored extra
|
||||
@@ -34,17 +33,16 @@ pass; a published transcript is never erased by a later report failure.
|
||||
|
||||
Debug is independent. The shared `--debug` flag enables a unique retained child
|
||||
under `diagnostics.work_dir`. CLI passes empty diagnostics paths and nil writers
|
||||
when debug is off. With debug enabled, it captures source and normalized
|
||||
snapshots, invocation, effective settings, correction ledger, LLM execution
|
||||
observations, and model interactions. Candidate capture includes proposals later
|
||||
when debug is off. With debug enabled, it saves the source bytes as acquired, separate from the parsed and normalized
|
||||
transcript snapshots. It also captures invocation metadata, effective settings
|
||||
rendered by ConfigKit, the correction ledger, LLM execution observations, and
|
||||
model interactions. Candidate capture includes proposals later
|
||||
rejected or interrupted. Repair and revalidation artifacts use section, proposal,
|
||||
attempt, validator, and batch coordinates as applicable; their retained content
|
||||
is redacted using the selected role credentials. Ledger mapping preserves empty proposed and applied
|
||||
replacements and distinguishes unavailable candidates from interrupted work.
|
||||
attempt, validator, and batch coordinates as applicable. Ledger mapping preserves empty proposed and applied replacements and distinguishes unavailable candidates from interrupted work.
|
||||
|
||||
A concurrency-safe diagnostic callback reports optional write failures without
|
||||
aborting processing. Diagnostic redaction uses credential source metadata; debug
|
||||
artifacts can still contain sensitive transcript and prompt content. Execution
|
||||
aborting processing. Debug artifacts can contain sensitive transcript and
|
||||
prompt content. Execution
|
||||
position and optional operator ID are carried separately from generated safe
|
||||
artifact path coordinates.
|
||||
|
||||
|
||||
@@ -15,9 +15,7 @@ The operation budget includes preparation, admission, retries, and structural
|
||||
repair. `ErrOperationTimeout` remains recoverable even when wrapped by a
|
||||
preparation error. Parent cancellation remains distinct. The prepared notification
|
||||
provides the actual request snapshot; failures before notification have no snapshot.
|
||||
PromptKit owns backend and credential selection. The adapter uses captured
|
||||
credential source names for artifact redaction without inspecting unrelated
|
||||
environment values. See the [integration contract](../integrations/openai-compatible-llm.md)
|
||||
PromptKit owns backend and credential selection. See the [integration contract](../integrations/openai-compatible-llm.md)
|
||||
for failure behavior and the [configuration reference](../config.md) for sources.
|
||||
|
||||
When correction repair is enabled, the proposal call captures a native immutable
|
||||
|
||||
@@ -67,7 +67,7 @@ artifact lifecycle.
|
||||
|
||||
## Component Responsibilities
|
||||
|
||||
Core components implement configuration defaults/loading/validation/redaction,
|
||||
Core components implement configuration defaults, loading, and validation,
|
||||
transcript schemas and derived glossary views, normalization and chunking, output encoding,
|
||||
diagnostics artifact helpers, and public report structures.
|
||||
|
||||
|
||||
@@ -121,8 +121,7 @@ provider attempts. With debug enabled, utilization remains grouped by backend
|
||||
capacity and usage fields retain known/complete flags. Debug runs write
|
||||
`effective-config.redacted.yaml`, `selected-profiles.yaml`,
|
||||
`config-origins.yaml`, `utilization-diagnostics.json`, and
|
||||
`llm-execution.json`. Request and response artifacts remain redacted debugging
|
||||
material. See [operations](../operations.md#debug-evidence) for placement
|
||||
`llm-execution.json`. Request and response artifacts are debugging material. See [operations](../operations.md#debug-evidence) for placement
|
||||
and paths, [configuration](../config.md) for all settings, and the
|
||||
[CLI reference](../cli.md) for current flags.
|
||||
|
||||
|
||||
@@ -48,11 +48,9 @@ existence as proof of success.
|
||||
|
||||
The shared `--debug` flag enables retained artifacts in a run directory beneath
|
||||
`diagnostics.work_dir`; selecting a work directory alone does not enable capture.
|
||||
Optional debug preparation or writes can produce redacted warnings without
|
||||
Optional debug preparation or writes can produce warnings without
|
||||
changing correction decisions or the required output result. Debug material can
|
||||
include transcript content, prompts, responses, and correction decisions. It is
|
||||
not anonymized; protect it according to the input's sensitivity. Configured
|
||||
credential values are redacted at the diagnostic boundary. Repair interactions
|
||||
include transcript content, prompts, responses, and correction decisions. Protect this material according to the sensitivity of the inputs and responses. Repair interactions
|
||||
and revalidation artifacts include proposal and attempt coordinates; the
|
||||
correction ledger connects them to the original edit.
|
||||
|
||||
|
||||
@@ -111,6 +111,12 @@ Audit #3, #9, #31 (source bytes), #63–65. Use the
|
||||
bytes, malformed response evidence, actual paths, and native auth using
|
||||
synthetic data. Check feedback by decoding a production repair request.
|
||||
|
||||
**Complete.** Reports and debug artifacts encode typed data directly, source
|
||||
snapshots preserve the acquired bytes, and repair requests carry the original
|
||||
domain findings. Removed application credential discovery and substitution.
|
||||
The CLI build and full offline suite passed with Go 1.27.3, including checks
|
||||
for native authentication, malformed response capture, and destination paths.
|
||||
|
||||
## Stage 3 — Unify optional interaction capture
|
||||
|
||||
Audit #33 and #43.
|
||||
|
||||
Reference in New Issue
Block a user