Retain only reportable operation details
This commit is contained in:
@@ -82,7 +82,7 @@ func TestRunnerStopsOnContradictoryValidatorDecision(t *testing.T) {
|
||||
|
||||
func TestRunnerRecoverableProposalFailureAllowsLaterModule(t *testing.T) {
|
||||
failed := outcomeModule{fakeModule: fakeModule{key: "first", policy: proposals.ReplacementPolicyRequireUnique}, proposeResult: func(req contracts.ProposalRequest) (contracts.ProposalResult, error) {
|
||||
return contracts.ProposalResult{Operations: []outcomes.Operation{{Reference: outcomes.Reference{ModuleKey: "first", ModuleInstance: "first", Kind: outcomes.OperationProposal}, FailureReason: outcomes.ReasonTransportFailed}}}, nil
|
||||
return contracts.ProposalResult{Operations: []outcomes.Operation{{Reference: outcomes.Reference{ModuleKey: "first", ModuleInstance: "first", Kind: outcomes.OperationProposal}, FailureClass: outcomes.FailureRecoverable, FailureReason: outcomes.ReasonTransportFailed}}}, nil
|
||||
}}
|
||||
second := fakeModule{key: "second", policy: proposals.ReplacementPolicyRequireUnique, proposeF: func(req contracts.ProposalRequest) ([]proposals.CorrectionProposal, error) {
|
||||
return []proposals.CorrectionProposal{{TargetSegmentID: 1, OriginalText: "teh", CorrectedText: "the"}}, nil
|
||||
@@ -110,8 +110,8 @@ func TestRunnerOnlyFullyValidatedCandidatesApplyAndRecoveriesMerge(t *testing.T)
|
||||
{ProposalIndex: req.CandidateProposal[0].ProposalIndex, Approved: false, Disposition: validators.DispositionUnavailable, ReasonCode: string(outcomes.ReasonTransportFailed)},
|
||||
{ProposalIndex: req.CandidateProposal[1].ProposalIndex, Approved: true, Disposition: validators.DispositionApproved},
|
||||
}, Operations: []outcomes.Operation{
|
||||
{Reference: outcomes.Reference{Kind: outcomes.OperationValidation}, FailureReason: outcomes.ReasonTransportFailed},
|
||||
{Reference: outcomes.Reference{Kind: outcomes.OperationValidation}, FailureReason: outcomes.ReasonProviderFailed},
|
||||
{Reference: outcomes.Reference{Kind: outcomes.OperationValidation}, FailureClass: outcomes.FailureRecoverable, FailureReason: outcomes.ReasonTransportFailed, Cause: errors.New("transport")},
|
||||
{Reference: outcomes.Reference{Kind: outcomes.OperationValidation}, FailureClass: outcomes.FailureRecoverable, FailureReason: outcomes.ReasonProviderFailed, Cause: errors.New("provider")},
|
||||
}}, nil
|
||||
}}
|
||||
last := fakeValidator{name: "last", validateF: func(req validators.Request) (validators.Result, error) {
|
||||
@@ -143,6 +143,10 @@ func TestRunnerOnlyFullyValidatedCandidatesApplyAndRecoveriesMerge(t *testing.T)
|
||||
if len(proposal.RecoveryReasons) != 2 || proposal.RecoveryReasons[0] != outcomes.RecoveryOutputRepaired || proposal.RecoveryReasons[1] != outcomes.RecoveryProposalsFiltered || len(proposal.Filtered) != 1 || proposal.Filtered[0].ProposalIndex != 0 {
|
||||
t.Fatalf("repair and filtering must share one recovery: %+v", proposal)
|
||||
}
|
||||
if len(proposal.ProposalIndices) != 0 || unit.Operations[1].Cause != nil || unit.Operations[2].Cause != nil ||
|
||||
out.Totals.ModelOperations != 3 || out.Totals.WithErrors != 1 || out.Totals.Recoveries != 1 {
|
||||
t.Fatalf("report detail or counts: operations=%+v totals=%+v", unit.Operations, out.Totals)
|
||||
}
|
||||
}
|
||||
|
||||
func TestFatalValidatorNeverReturnsUncheckedCandidates(t *testing.T) {
|
||||
@@ -774,17 +778,8 @@ func TestRunnerApplyConflictAfterTwoInitiallyValidDeletions(t *testing.T) {
|
||||
if len(out.ModuleResults[0].ValidatorRejected) != 0 || len(out.WorkUnits) != 1 || out.WorkUnits[0].CorrectionsApplied != 1 {
|
||||
t.Fatalf("unexpected validation or application outcome: %+v", out)
|
||||
}
|
||||
foundProposal := false
|
||||
for _, operation := range out.WorkUnits[0].Operations {
|
||||
if operation.Reference.Kind == outcomes.OperationProposal && operation.Succeeded {
|
||||
foundProposal = true
|
||||
}
|
||||
if operation.FailureReason != "" || len(operation.RecoveryReasons) != 0 || len(operation.Filtered) != 0 {
|
||||
t.Fatalf("apply-time conflict must not count as model error or filtering recovery: %+v", operation)
|
||||
}
|
||||
}
|
||||
if !foundProposal {
|
||||
t.Fatalf("expected successful proposal operation: %+v", out.WorkUnits[0].Operations)
|
||||
if len(out.WorkUnits[0].Operations) != 0 || out.Totals.ProposalResponses != 1 || out.Totals.WithErrors != 0 || out.Totals.Recoveries != 0 {
|
||||
t.Fatalf("apply-time conflict changed report facts: operations=%+v totals=%+v", out.WorkUnits[0].Operations, out.Totals)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -933,7 +928,7 @@ func TestRunnerReconciledSurvivorsCompleteLaterValidation(t *testing.T) {
|
||||
t.Fatalf("survivor routing: text=%q later=%v calls=%d err=%v", out.FinalTranscript.Segments[0].Text, laterIndices, client.calls, err)
|
||||
}
|
||||
unit := out.WorkUnits[0]
|
||||
if unit.CorrectionsApplied != 1 || len(unit.Operations) != 2 || !unit.Operations[0].Succeeded || unit.Operations[1].FailureReason != outcomes.ReasonValidationDecisionsInvalid || len(unit.Operations[1].ProposalIndices) != 1 || unit.Operations[1].ProposalIndices[0] != 1 || len(unit.Operations[1].RecoveryReasons) != 0 {
|
||||
if unit.CorrectionsApplied != 1 || out.Totals.ProposalResponses != 1 || len(unit.Operations) != 1 || unit.Operations[0].FailureReason != outcomes.ReasonValidationDecisionsInvalid || len(unit.Operations[0].ProposalIndices) != 1 || unit.Operations[0].ProposalIndices[0] != 1 || len(unit.Operations[0].RecoveryReasons) != 0 {
|
||||
t.Fatalf("operation accounting: %+v", unit)
|
||||
}
|
||||
moduleResult := out.ModuleResults[0]
|
||||
@@ -1139,16 +1134,6 @@ func TestRunnerProposalIndexOrderingIsDeterministicAcrossParallelSections(t *tes
|
||||
t.Fatalf("change %d lost response order or segment identity: %+v", i, change)
|
||||
}
|
||||
}
|
||||
wantIndices := [][]int{{0, 1}, {2}}
|
||||
if len(out.WorkUnits) != len(wantIndices) {
|
||||
t.Fatalf("work units: %+v", out.WorkUnits)
|
||||
}
|
||||
for i, unit := range out.WorkUnits {
|
||||
if len(unit.Operations) != 1 || !reflect.DeepEqual(unit.Operations[0].ProposalIndices, wantIndices[i]) {
|
||||
t.Fatalf("section %d lost proposal indices: %+v", i, unit.Operations)
|
||||
}
|
||||
}
|
||||
|
||||
paths, err := filepath.Glob(filepath.Join(dir, "grammar", "*response-payload.json"))
|
||||
if err != nil || len(paths) != len(responses) {
|
||||
t.Fatalf("proposal diagnostic paths=%v error=%v", paths, err)
|
||||
|
||||
Reference in New Issue
Block a user