Adopt the upstream fix for malformed prompt configuration

This commit is contained in:
2026-11-17 01:28:21 +00:00
parent a355f05a27
commit e8c070805e
5 changed files with 54 additions and 42 deletions

View File

@@ -51,8 +51,9 @@ input, and status 1 for cancellation. While the supporting release is pending,
record the mismatch explicitly. A test that asserts only nonzero status does
not verify this fix.
**Complete.** The upstream handoff is recorded below. The exit-status fix
remains outstanding after the final verification pass.
**Complete.** The upstream handoff below records the original behavior.
The [delegated inspection follow-up](#delegated-inspection-fix) records the
adopted fix.
Build a temporary executable with `go build -o /tmp/audita-inspection ./cmd/audita`.
In a scratch directory, put `version: 3` in `config.yml`, `profiles: [` in the
@@ -82,8 +83,8 @@ assign it through `configFailure`, with `show` calling it through
integrations. They need to assign status 2 for typed operator-input failures
at those boundaries, preserving diagnostics, available inspection evidence,
and the cause. Cancellation and other operational failures need status 1.
The upstream tag list contained releases through `v0.7.0` for each
integration, which are already pinned. Recheck both in the final stage.
At the time of the handoff, the latest release of both integrations was
`v0.7.0`, the version Audita used for the reproduction.
## Stage 2 — Remove application credential substitution
@@ -749,7 +750,8 @@ The completed sprint should leave the target architecture reachable through
measurements actually performed, including any outstanding external dependency.
**Complete.** The integrated Audita work and release bootstrap passed checks.
The delegated inspection exit status remains an outstanding upstream item.
The [delegated inspection follow-up](#delegated-inspection-fix) closes the
upstream item that was open at the end of the sprint.
The bootstrap rejects a dirty checkout and a failed status command with no
output. A clean fixture reaches ReleaseKit with the prepared checkout and
@@ -763,9 +765,9 @@ glossary input were removed.
### Delegated inspection status
The [CommandKit upstream tags](https://forge.maximumdirect.net/base-layer/commandkit/tags)
confirmed `v0.7.0` is the latest release of both `ckprompt` and `ckconfig`.
The built Audita executable reproduced the Stage 1 mismatch:
At sprint close, the latest CommandKit integration releases were `ckprompt`
and `ckconfig` v0.7.0. The built Audita executable reproduced the Stage 1
mismatch:
| Invalid input | Path | Observed status and diagnostic |
| --- | --- | --- |
@@ -774,10 +776,23 @@ The built Audita executable reproduced the Stage 1 mismatch:
| Malformed automatic `prompts.yml` | `config show/sources/validate/explain/diff --scope promptkit` | 1, `yaml.invalid` |
| Malformed explicit app main file | `config show/sources/validate/explain/diff --scope app` | 1, `yaml.invalid` |
Caller cancellation remains status 1 in the shared CLI and subprocess tests.
The CommandKit integrations still own the fix to return status 2 for typed
operator-input failures. Audita retains its native delegations. The expected
upstream change and reproduction remain in the Stage 1 handoff.
Caller cancellation returned status 1 in the shared CLI and subprocess tests.
### Delegated inspection fix
Audita adopted `ckprompt` v0.9.0, `ckconfig` v0.8.0, and PromptKit v0.23.1.
PromptKit preserves `ErrInvalidConfig` through `errors.Is` and unwraps to the
original cause. Both integrations can now classify the typed ConfigKit load
error as invalid input. Audita uses the existing native command wiring.
[ckprompt v0.9.0 release notes](https://forge.maximumdirect.net/base-layer/commandkit/src/commit/29694ea874b53151d832c141b7c5913779852e0e/integrations/ckprompt/docs/releases/v0.9.0.md) ·
[PromptKit v0.23.1 release notes](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/74066167942fcf6f70c112359995739ec9789fa6/docs/releases/v0.23.1.md)
The Stage 1 fixture now returns status 2 with `yaml.invalid` identifying
`prompts.yml` for `promptkit list prompts`, `process`, and all five PromptKit
configuration commands. `config sources` and `config validate` still emit
their reports. All five app-scope commands likewise return status 2 for a
malformed main file. The CLI cancellation test still verifies status 1,
`context.Canceled` in the cause chain, and empty stdout.
### Catalog closure
@@ -795,7 +810,7 @@ the historical audit observations. Each stage records its verification above.
| #13, #31, #51–52, #54 | Stages 2 and 5. |
| #14–15, #22, #30–32, #39, #41 | Stages 5, 12, and 15–18. |
| #17, #21, #35, #53, #59, #62 | Stages 5 and 6, with final caller checks in Stage 20. |
| #20, #24 | Stages 7 and 11 for processing; Stage 1 and the upstream disposition above for delegated inspection. |
| #20, #24 | Stages 7 and 11 for processing, and the [delegated inspection fix](#delegated-inspection-fix). |
| #23, #25, #44 | Stages 12, 18, and 19. |
| #28–29, #58, #60–61 | Stage 20. |
| #33, #43 | Stages 3 and 18. |