Collect optional validation context only when it can fit

This commit is contained in:
2026-11-17 04:25:35 +00:00
parent 44c767f285
commit d26991f0bf
9 changed files with 128 additions and 56 deletions

View File

@@ -11,6 +11,16 @@ import (
"gitea.maximumdirect.net/eric/audita/v3/internal/framework/proposals"
)
func buildContextItems(req Request) ([]LLMValidationItem, []Decision) {
req.Section = req.sectionLookup()
items, immediate := buildValidationItems(req)
context := validationContextFor(req)
for i := range items {
items[i].NeighboringSegments, items[i].GlossaryEntries = context(items[i])
}
return items, immediate
}
func TestValidationContextCarriesAdjacentEvidenceAndRelevantDefinitions(t *testing.T) {
req := makeReq([]proposals.EnrichedCorrectionProposal{mk(7, "gestures", "Jesters")})
req.WorkingTranscript = &schema.Transcript{Segments: []schema.Segment{
@@ -25,7 +35,7 @@ func TestValidationContextCarriesAdjacentEvidenceAndRelevantDefinitions(t *testi
{ID: "lyra", Name: "Lyra", Description: "The host"},
{ID: "unrelated", Name: "Unrelated", Description: "Not mentioned"},
}
payload, immediate := buildValidationItems(req)
payload, immediate := buildContextItems(req)
if len(immediate) != 0 || len(payload) != 1 {
t.Fatalf("payload: %+v immediate: %+v", payload, immediate)
}
@@ -51,7 +61,7 @@ func TestValidationContextCarriesAdjacentEvidenceAndRelevantDefinitions(t *testi
req.WorkingTranscript.Segments = req.WorkingTranscript.Segments[1:2]
req.WorkingTranscript.Segments[0].Speaker = ""
req.Glossary = nil
isolated, _ := buildValidationItems(req)
isolated, _ := buildContextItems(req)
if isolated[0].Speaker != "" || len(isolated[0].NeighboringSegments) != 0 || len(isolated[0].GlossaryEntries) != 0 {
t.Fatalf("unexpected external context: %+v", isolated)
}
@@ -73,7 +83,7 @@ func TestValidationContextFitsBudgetWithoutDiscardingCandidate(t *testing.T) {
enriched := base
enriched.NeighboringSegments = []NeighboringSegment{{Position: "following", Text: strings.Repeat("long context ", 300)}}
enriched.GlossaryEntries = []glossary.Entry{{Name: "cat", Description: strings.Repeat("long definition ", 300)}}
fit, err := fitValidationContext(enriched, required, estimator)
fit, err := fitValidationContext(enriched, required, estimator, nil)
if err != nil {
t.Fatal(err)
}
@@ -91,15 +101,17 @@ func TestValidationContextFitsBudgetWithoutDiscardingCandidate(t *testing.T) {
func TestValidationContextSelectsGlossaryForEachReplacement(t *testing.T) {
req := makeReq([]proposals.EnrichedCorrectionProposal{mk(7, "gestures", "Jesters"), mk(11, "gestures", "Actors")})
req.WorkingTranscript = &schema.Transcript{Segments: []schema.Segment{{ID: 1, Text: "Those gestures are back."}}}
req.Glossary = []glossary.Entry{{ID: "actors", Name: "Actors"}, {ID: "jesters", Name: "Jesters"}}
payload, immediate := buildValidationItems(req)
req.WorkingTranscript = &schema.Transcript{Segments: []schema.Segment{
{ID: 1, Text: "Those gestures are back."}, {ID: 2, Text: "They met Lyra."},
}}
req.Glossary = []glossary.Entry{{ID: "lyra", Name: "Lyra"}, {ID: "actors", Name: "Actors"}, {ID: "jesters", Name: "Jesters"}}
payload, immediate := buildContextItems(req)
if len(immediate) != 0 || len(payload) != 2 {
t.Fatalf("payload: %+v immediate: %+v", payload, immediate)
}
for i, name := range []string{"Jesters", "Actors"} {
entries := payload[i].GlossaryEntries
if len(entries) != 1 || entries[0].Name != name {
if len(entries) != 2 || entries[0].Name != "Lyra" || entries[1].Name != name {
t.Fatalf("candidate %d context: %+v", i, entries)
}
}