Clarify prompt boundaries and enforce repair decisions
This commit is contained in:
@@ -3,47 +3,71 @@
|
||||
"additionalProperties": false,
|
||||
"required": [
|
||||
"proposal_ref",
|
||||
"action",
|
||||
"correction"
|
||||
"decision"
|
||||
],
|
||||
"properties": {
|
||||
"proposal_ref": {
|
||||
"type": "integer",
|
||||
"minimum": 1
|
||||
},
|
||||
"action": {
|
||||
"type": "string",
|
||||
"enum": [
|
||||
"revise",
|
||||
"withdraw"
|
||||
]
|
||||
},
|
||||
"correction": {
|
||||
"decision": {
|
||||
"anyOf": [
|
||||
{
|
||||
"type": "object",
|
||||
"additionalProperties": false,
|
||||
"required": [
|
||||
"id",
|
||||
"original_text",
|
||||
"corrected_text"
|
||||
"action",
|
||||
"correction"
|
||||
],
|
||||
"properties": {
|
||||
"id": {
|
||||
"type": "integer",
|
||||
"minimum": 1
|
||||
},
|
||||
"original_text": {
|
||||
"action": {
|
||||
"type": "string",
|
||||
"minLength": 1
|
||||
"enum": [
|
||||
"revise"
|
||||
]
|
||||
},
|
||||
"corrected_text": {
|
||||
"type": "string"
|
||||
"correction": {
|
||||
"type": "object",
|
||||
"additionalProperties": false,
|
||||
"required": [
|
||||
"id",
|
||||
"original_text",
|
||||
"corrected_text"
|
||||
],
|
||||
"properties": {
|
||||
"id": {
|
||||
"type": "integer",
|
||||
"minimum": 1
|
||||
},
|
||||
"original_text": {
|
||||
"type": "string",
|
||||
"minLength": 1
|
||||
},
|
||||
"corrected_text": {
|
||||
"type": "string"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"type": "null"
|
||||
"type": "object",
|
||||
"additionalProperties": false,
|
||||
"required": [
|
||||
"action",
|
||||
"correction"
|
||||
],
|
||||
"properties": {
|
||||
"action": {
|
||||
"type": "string",
|
||||
"enum": [
|
||||
"withdraw"
|
||||
]
|
||||
},
|
||||
"correction": {
|
||||
"type": "null"
|
||||
}
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -149,13 +149,16 @@ func TestCorrectionRepairSchema(t *testing.T) {
|
||||
name, content string
|
||||
valid bool
|
||||
}{
|
||||
{"delete whitespace", `{"proposal_ref":1,"action":"revise","correction":{"id":1,"original_text":" ","corrected_text":""}}`, true},
|
||||
{"withdraw", `{"proposal_ref":1,"action":"withdraw","correction":null}`, true},
|
||||
{"missing correction", `{"proposal_ref":1,"action":"withdraw"}`, false},
|
||||
{"extra field", `{"proposal_ref":1,"action":"withdraw","correction":null,"extra":1}`, false},
|
||||
{"zero reference", `{"proposal_ref":0,"action":"withdraw","correction":null}`, false},
|
||||
{"unknown action", `{"proposal_ref":1,"action":"other","correction":null}`, false},
|
||||
{"empty original", `{"proposal_ref":1,"action":"revise","correction":{"id":1,"original_text":"","corrected_text":"x"}}`, false},
|
||||
{"delete whitespace", `{"proposal_ref":1,"decision":{"action":"revise","correction":{"id":1,"original_text":" ","corrected_text":""}}}`, true},
|
||||
{"withdraw", `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`, true},
|
||||
{"revision without correction", `{"proposal_ref":1,"decision":{"action":"revise","correction":null}}`, false},
|
||||
{"withdrawal with correction", `{"proposal_ref":1,"decision":{"action":"withdraw","correction":{"id":1,"original_text":"cat","corrected_text":"dog"}}}`, false},
|
||||
{"flat response", `{"proposal_ref":1,"action":"withdraw","correction":null}`, false},
|
||||
{"missing correction", `{"proposal_ref":1,"decision":{"action":"withdraw"}}`, false},
|
||||
{"extra field", `{"proposal_ref":1,"extra":1,"decision":{"action":"withdraw","correction":null}}`, false},
|
||||
{"zero reference", `{"proposal_ref":0,"decision":{"action":"withdraw","correction":null}}`, false},
|
||||
{"unknown action", `{"proposal_ref":1,"decision":{"action":"other","correction":null}}`, false},
|
||||
{"empty original", `{"proposal_ref":1,"decision":{"action":"revise","correction":{"id":1,"original_text":"","corrected_text":"x"}}}`, false},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var value any
|
||||
|
||||
Reference in New Issue
Block a user