Clarify prompt boundaries and enforce repair decisions

This commit is contained in:
2026-11-15 02:41:32 +00:00
parent e183708021
commit c4ccd7897e
13 changed files with 111 additions and 67 deletions

View File

@@ -41,7 +41,7 @@ func TestRoleClientContinuesIndependentRepairConversations(t *testing.T) {
}
var messages [][]wireMessage
var models []string
outputs := []string{`{"corrections":[]}`, `{"proposal_ref":1,"action":"revise","correction":{"id":1,"original_text":"a","corrected_text":"b"}}`, `{"proposal_ref":1,"action":"withdraw","correction":null}`, `{"proposal_ref":1,"action":"withdraw","correction":null}`}
outputs := []string{`{"corrections":[]}`, `{"proposal_ref":1,"decision":{"action":"revise","correction":{"id":1,"original_text":"a","corrected_text":"b"}}}`, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}
transport := transportFunc(func(r *http.Request) (*http.Response, error) {
var req struct {
Model string `json:"model"`
@@ -126,7 +126,7 @@ func TestRepairContinuationUsesReplacementAndCountsStructuralRepair(t *testing.T
if err != nil {
t.Fatal(err)
}
outputs := []string{`{"corrections":[]}`, `{"bad":true}`, `{"proposal_ref":1,"action":"withdraw","correction":null}`}
outputs := []string{`{"corrections":[]}`, `{"proposal_ref":1,"decision":{"action":"revise","correction":null}}`, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}
var requests [][]structuredoutput.Message
transport := transportFunc(func(r *http.Request) (*http.Response, error) {
var req struct {

View File

@@ -19,8 +19,8 @@ func TestCoordinatorFinalTurnFailuresAndAccounting(t *testing.T) {
again bool
reason outcomes.ReasonCode
}{
{name: "last turn assessed", reply: reply{200, `{"proposal_ref":1,"action":"withdraw","correction":null}`}},
{name: "exhaustion", reply: reply{200, `{"proposal_ref":1,"action":"withdraw","correction":null}`}, again: true},
{name: "last turn assessed", reply: reply{200, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}},
{name: "exhaustion", reply: reply{200, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}, again: true},
{name: "invalid structure", reply: reply{200, `{"wrong":true}`}, reason: outcomes.ReasonInvalidOutputExhausted},
{name: "provider error", reply: reply{400, ""}, reason: outcomes.ReasonProviderFailed},
} {
@@ -75,7 +75,7 @@ func TestCoordinatorFinalTurnFailuresAndAccounting(t *testing.T) {
}
func TestCoordinatorCanceledDeliveryRetainsEvidence(t *testing.T) {
runtime, _, _ := adapterFixture(t, []reply{{200, `{"corrections":[]}`}, {200, `{"proposal_ref":1,"action":"withdraw","correction":null}`}}, 0, 0, nil)
runtime, _, _ := adapterFixture(t, []reply{{200, `{"corrections":[]}`}, {200, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}}, 0, 0, nil)
collector := NewObservationCollector()
proposal, _ := runtime.NewRoleClient("proposal", "base", runtime.Config.LLM, collector.Hooks())
req := adapterRequest(responseschema.CorrectionSetKey)
@@ -113,7 +113,7 @@ func TestCoordinatorCanceledDeliveryRetainsEvidence(t *testing.T) {
}
func TestCoordinatorReleasesAdmissionBeforeNestedValidation(t *testing.T) {
runtime, count, _ := adapterFixture(t, []reply{{200, `{"corrections":[]}`}, {200, `{"proposal_ref":1,"action":"withdraw","correction":null}`}, {200, `{"validations":[]}`}}, 0, 0, nil)
runtime, count, _ := adapterFixture(t, []reply{{200, `{"corrections":[]}`}, {200, `{"proposal_ref":1,"decision":{"action":"withdraw","correction":null}}`}, {200, `{"validations":[]}`}}, 0, 0, nil)
collector := NewObservationCollector()
proposal, _ := runtime.NewRoleClient("proposal", "base", runtime.Config.LLM, collector.Hooks())
repair, _ := runtime.NewRoleClient("repair", "base", runtime.Config.LLM, collector.Hooks())