Unify structured call completion and retain typed failures

This commit is contained in:
2026-11-16 14:27:54 +00:00
parent e98e525b5c
commit c2c8050bc8
18 changed files with 313 additions and 186 deletions

View File

@@ -3,7 +3,6 @@ package validators
import (
"context"
"encoding/json"
"errors"
"fmt"
"sort"
"strings"
@@ -103,6 +102,7 @@ func (v *LLMBackedValidator) Validate(ctx context.Context, req Request) (Result,
}
operations = append(operations, outcomes.Operation{
Reference: operationRef(outcomes.OperationValidationInput, nil),
FailureClass: outcomes.FailureRecoverable,
FailureReason: outcomes.ReasonValidationInputTooLarge,
ProposalIndices: indices,
})
@@ -173,17 +173,11 @@ func (v *LLMBackedValidator) Validate(ctx context.Context, req Request) (Result,
}
if err != nil {
artifacts := writeInteraction(nil, err)
var failure *structuredoutput.Failure
if errors.As(err, &failure) {
operation.FailureReason = failure.Reason
}
if operation.FailureReason == "" {
operation.FailureReason = outcomes.ReasonInternalFailure
}
structuredoutput.RecordFailure(&operation, err)
operation.ProposalIndices = batchProposalIndices(batch.Items)
operations = append(operations, operation)
if structuredoutput.IsRecoverable(err) && failure != nil && failure.Reason != "" {
decisions := rejectBatch(batch.Items, string(failure.Reason), "model validation was unavailable")
if operation.FailureClass == outcomes.FailureRecoverable {
decisions := rejectBatch(batch.Items, string(operation.FailureReason), "model validation was unavailable")
for i := range decisions {
decisions[i].DiagnosticArtifactPath = artifacts.ResponsePayloadPath
}
@@ -196,6 +190,7 @@ func (v *LLMBackedValidator) Validate(ctx context.Context, req Request) (Result,
reconciled := reconcileLLMResponse(batch.Items, response)
artifacts := writeInteraction(&reconciled, nil)
if len(reconciled.UnavailableIndices) > 0 {
operation.FailureClass = outcomes.FailureRecoverable
operation.FailureReason = outcomes.ReasonValidationDecisionsInvalid
operation.ProposalIndices = reconciled.UnavailableIndices
} else {