Unify structured call completion and retain typed failures
This commit is contained in:
@@ -14,10 +14,8 @@ const (
|
||||
FailureRuntime FailureKind = "runtime"
|
||||
)
|
||||
|
||||
// Failure exposes a safe message while retaining the typed cause for callers.
|
||||
// The cause must not be serialized or formatted directly in user artifacts.
|
||||
// Failure exposes an operator-facing message and retains the typed cause.
|
||||
type Failure struct {
|
||||
Kind FailureKind // Retained until the adapter switches to reason-based classification.
|
||||
Class FailureClass
|
||||
Reason outcomes.ReasonCode
|
||||
Message string
|
||||
@@ -26,12 +24,12 @@ type Failure struct {
|
||||
|
||||
// FailureClass determines whether domain processing may safely skip a model
|
||||
// operation or must stop the run. Parent cancellation always stops the run.
|
||||
type FailureClass string
|
||||
type FailureClass = outcomes.FailureClass
|
||||
|
||||
const (
|
||||
FailureRecoverable FailureClass = "recoverable"
|
||||
FailureFatal FailureClass = "fatal"
|
||||
FailureCanceled FailureClass = "canceled"
|
||||
FailureRecoverable = outcomes.FailureRecoverable
|
||||
FailureFatal = outcomes.FailureFatal
|
||||
FailureCanceled = outcomes.FailureCanceled
|
||||
)
|
||||
|
||||
func (f *Failure) Error() string { return f.Message }
|
||||
@@ -42,7 +40,22 @@ func IsRecoverable(err error) bool {
|
||||
return errors.As(err, &failure) && failure.Class == FailureRecoverable
|
||||
}
|
||||
|
||||
// RecordFailure retains the error chain for processing and sets the compact
|
||||
// reason used by reports. An absent reason does not change recoverability.
|
||||
func RecordFailure(operation *outcomes.Operation, err error) {
|
||||
operation.Cause = err
|
||||
operation.FailureClass = FailureFatal
|
||||
operation.FailureReason = outcomes.ReasonInternalFailure
|
||||
var failure *Failure
|
||||
if errors.As(err, &failure) {
|
||||
operation.FailureClass = failure.Class
|
||||
if failure.Reason != "" {
|
||||
operation.FailureReason = failure.Reason
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func IsMalformedError(err error) bool {
|
||||
var failure *Failure
|
||||
return errors.As(err, &failure) && failure.Kind == FailureMalformedOutput
|
||||
return errors.As(err, &failure) && failure.Reason == outcomes.ReasonInvalidOutputExhausted
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user