Use consistent reasons for typed failures
This commit is contained in:
@@ -35,6 +35,14 @@ const (
|
||||
func (f *Failure) Error() string { return f.Message }
|
||||
func (f *Failure) Unwrap() error { return f.Cause }
|
||||
|
||||
// EffectiveReason supplies the report reason even when a caller omitted it.
|
||||
func (f *Failure) EffectiveReason() outcomes.ReasonCode {
|
||||
if f.Reason != "" {
|
||||
return f.Reason
|
||||
}
|
||||
return outcomes.ReasonInternalFailure
|
||||
}
|
||||
|
||||
func IsRecoverable(err error) bool {
|
||||
var failure *Failure
|
||||
return errors.As(err, &failure) && failure.Class == FailureRecoverable
|
||||
@@ -49,9 +57,7 @@ func RecordFailure(operation *outcomes.Operation, err error) {
|
||||
var failure *Failure
|
||||
if errors.As(err, &failure) {
|
||||
operation.FailureClass = failure.Class
|
||||
if failure.Reason != "" {
|
||||
operation.FailureReason = failure.Reason
|
||||
}
|
||||
operation.FailureReason = failure.EffectiveReason()
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user