Keep match boundaries for exempt glossary names
This commit is contained in:
@@ -61,6 +61,53 @@ func TestApplicationChecksCurrentTextWithSelectedProtection(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestExemptGlossarySpellingKeepsLongestMatchBoundary(t *testing.T) {
|
||||
active := []glossary.Entry{
|
||||
{ID: "greater-mage", Name: "Greater Mage Armor"},
|
||||
{ID: "greater-magus", Name: "Greater Magus Armor"},
|
||||
}
|
||||
protected := []glossary.Entry{
|
||||
active[0], active[1],
|
||||
{ID: "short", Name: "Mage Armor"},
|
||||
{ID: "long", Name: "Superior Greater Mage Armor"},
|
||||
}
|
||||
for _, tc := range []struct {
|
||||
name, module, before, original, replacement string
|
||||
exempt, allowed bool
|
||||
}{
|
||||
{"full active name", "glossary", "Cast Greater Mage Armor.", "Greater Mage Armor", "Greater Magus Armor", true, true},
|
||||
{"span within active name", "glossary", "Cast Greater Mage Armor.", "Mage Armor", "Magus Armor", true, true},
|
||||
{"standalone protected name", "glossary", "Cast Mage Armor.", "Mage Armor", "Magus Armor", true, false},
|
||||
{"longer protected name", "glossary", "Cast Superior Greater Mage Armor.", "Greater Mage Armor", "Greater Magus Armor", true, false},
|
||||
{"same name in a grammar pass", "grammar", "Cast Greater Mage Armor.", "Greater Mage Armor", "Greater Magus Armor", false, false},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var exclusions []glossary.Entry
|
||||
if tc.exempt {
|
||||
exclusions = active
|
||||
}
|
||||
terms := glossary.Vocabulary(protected, exclusions)
|
||||
transcript := &schema.Transcript{Segments: []schema.Segment{{ID: 1, Text: tc.before}}}
|
||||
candidate := proposals.EnrichedCorrectionProposal{CorrectionProposal: proposals.CorrectionProposal{
|
||||
TargetSegmentID: 1, OriginalText: tc.original, CorrectedText: tc.replacement, Confidence: 1,
|
||||
}}
|
||||
policy := proposals.ReplacementPolicyRequireUnique
|
||||
decision, err := ValidateProtectedTerms(Request{ModuleKey: tc.module, WorkingTranscript: transcript, ReplacementPolicy: policy,
|
||||
ProtectedTerms: terms, CandidateProposal: []proposals.EnrichedCorrectionProposal{candidate}})
|
||||
if err != nil || len(decision.Decisions) != 1 || decision.Decisions[0].Approved != tc.allowed {
|
||||
t.Fatalf("decision=%+v err=%v", decision, err)
|
||||
}
|
||||
vocabulary := NewProtectedVocabulary(terms)
|
||||
result := proposals.ApplyProposals(transcript, []proposals.EnrichedCorrectionProposal{candidate}, policy, func(before, after string) bool {
|
||||
return vocabulary.AllowsChange(before, after, false)
|
||||
})
|
||||
if (len(result.Applied) == 1) != tc.allowed {
|
||||
t.Fatalf("apply-time protection disagrees with validation: %+v", result)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestValidationContextIncludesEachSharedDefinition(t *testing.T) {
|
||||
entries := []glossary.Entry{
|
||||
{Collection: "spells", ID: "shield", Name: "Shield", Category: "spell"},
|
||||
|
||||
Reference in New Issue
Block a user