Connect processing preflight and output reporting

2026-11-10 17:12:28 +00:00
parent 852e79405f
commit 199c1d1dbe
10 changed files with 634 additions and 328 deletions
--- a/internal/cli/process_output_test.go
+++ b/internal/cli/process_output_test.go
@@ -0,0 +1,112 @@
+package cli
+
+import (
+	"bytes"
+	"context"
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"gitea.maximumdirect.net/eric/audita/v3/internal/core/reporting"
+	commandkit "go.maximumdirect.net/commandkit"
+)
+
+func TestPreparedDeliveryFollowsReportingMode(t *testing.T) {
+	dir := t.TempDir()
+	for name, contents := range map[string]string{
+		"config.yml":      "version: 3\npipeline:\n  stages: []\nreporting:\n  enabled: false\n",
+		"transcript.json": `[{"speaker":"Alice","start":0,"end":1,"text":"hello"}]`,
+	} {
+		if err := os.WriteFile(filepath.Join(dir, name), []byte(contents), 0644); err != nil {
+			t.Fatal(err)
+		}
+	}
+	for _, tc := range []struct {
+		name     string
+		flags    []string
+		file     bool
+		wantInfo bool
+	}{
+		{"ordinary", nil, false, false}, {"verbose", []string{"--verbose"}, false, true}, {"quiet file", []string{"--quiet"}, true, false},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			input := processInput{Config: commandkit.Supplied[string]{Value: filepath.Join(dir, "config.yml"), Set: true}, Transcript: filepath.Join(dir, "transcript.json")}
+			if tc.file {
+				input.Output = commandkit.Supplied[string]{Value: filepath.Join(dir, "result.json"), Set: true}
+			}
+			cmd := commandkit.NewCommand(commandkit.CommandSpec[struct{}]{Name: "deliver", Run: func(inv commandkit.Invocation, _ struct{}) commandkit.Outcome {
+				loaded, err := loadProcessInputs(inv.Context, input, inv.ReportingMode())
+				if err != nil {
+					return commandkit.Usage(err.Error())
+				}
+				prepared, err := prepareProcess(inv.Context, input, loaded, inv.Reporter().Output())
+				if err != nil {
+					return commandkit.Failure(err.Error())
+				}
+				return finishProcess(inv, input, loaded, prepared, reporting.Snapshot{}, []byte("transcript bytes"), nil)
+			}})
+			app, err := commandkit.New(commandkit.Identity{Name: "test"}, cmd)
+			if err != nil {
+				t.Fatal(err)
+			}
+			var out, stderr bytes.Buffer
+			args := append([]string{"deliver"}, tc.flags...)
+			outcome := app.Execute(context.Background(), args, commandkit.Streams{Out: &out, Err: &stderr})
+			if outcome.Status != 0 {
+				t.Fatalf("outcome=%+v err=%s", outcome, stderr.String())
+			}
+			if tc.file {
+				data, err := os.ReadFile(input.Output.Value)
+				if err != nil || string(data) != "transcript bytes" {
+					t.Fatalf("file=%q err=%v", data, err)
+				}
+				if out.Len() != 0 {
+					t.Fatalf("stdout=%q", out.String())
+				}
+			} else if out.String() != "transcript bytes" {
+				t.Fatalf("stdout=%q", out.String())
+			}
+			if strings.Contains(stderr.String(), "Completed:") != tc.wantInfo {
+				t.Fatalf("stderr=%q", stderr.String())
+			}
+		})
+	}
+}
+
+func TestDeliveryFailureSuppressesCompletionSummary(t *testing.T) {
+	dir := t.TempDir()
+	for name, contents := range map[string]string{
+		"config.yml":      "version: 3\npipeline:\n  stages: []\nreporting:\n  enabled: false\n",
+		"transcript.json": `[{"speaker":"Alice","start":0,"end":1,"text":"hello"}]`,
+	} {
+		if err := os.WriteFile(filepath.Join(dir, name), []byte(contents), 0644); err != nil {
+			t.Fatal(err)
+		}
+	}
+	input := processInput{Config: commandkit.Supplied[string]{Value: filepath.Join(dir, "config.yml"), Set: true}, Transcript: filepath.Join(dir, "transcript.json")}
+	cmd := commandkit.NewCommand(commandkit.CommandSpec[struct{}]{Name: "deliver", Run: func(inv commandkit.Invocation, _ struct{}) commandkit.Outcome {
+		loaded, err := loadProcessInputs(inv.Context, input, inv.ReportingMode())
+		if err != nil {
+			return commandkit.Failure(err.Error())
+		}
+		prepared, err := prepareProcess(inv.Context, input, loaded, inv.Reporter().Output())
+		if err != nil {
+			return commandkit.Failure(err.Error())
+		}
+		return finishProcess(inv, input, loaded, prepared, reporting.Snapshot{}, []byte("transcript bytes"), nil)
+	}})
+	app, err := commandkit.New(commandkit.Identity{Name: "test"}, cmd)
+	if err != nil {
+		t.Fatal(err)
+	}
+	var stderr bytes.Buffer
+	outcome := app.Execute(context.Background(), []string{"deliver", "--verbose"}, commandkit.Streams{Out: shortProcessWriter{}, Err: &stderr})
+	if outcome.Status == 0 || strings.Contains(stderr.String(), "Completed:") {
+		t.Fatalf("status=%d stderr=%q", outcome.Status, stderr.String())
+	}
+}
+
+type shortProcessWriter struct{}
+
+func (shortProcessWriter) Write(data []byte) (int, error) { return len(data) / 2, nil }