Files
ansible-workspace-dnd/docs/roadmap/remediation.md

72 lines
2.7 KiB
Markdown
Raw Normal View History

2026-09-09 22:27:52 +00:00
# Feature 0005 Remediation Review
2026-09-08 23:53:06 +00:00
Status: resolved
Reviewed implementation commits:
2026-09-09 22:27:52 +00:00
- `3be78d8 Install and configure Narratio`
- `0e8ad9f Add focused Narratio integration coverage`
2026-09-08 23:53:06 +00:00
Remediation commit:
2026-09-09 22:27:52 +00:00
- `7feff47 Clean up Narratio review findings`
2026-09-09 22:27:52 +00:00
The production role implements the targeted architecture, and the complete
integration suite passes. The findings were limited to residual documentation
and test-quality issues; no production task, template, default, argument
specification, metadata, or dependency required a change.
2026-09-09 19:17:08 +00:00
## Finding 1: Remove the Retained Placeholder README Sentence
2026-09-09 19:17:08 +00:00
Severity: low
2026-09-09 22:27:52 +00:00
`ansible-role-narratio/README.md` ended with the original placeholder sentence,
“Ansible role to install the Narratio D&D transcript and session report
generation suite.” The rewritten README already provided the complete role
description, so this was accidental residue from the initial repository.
2026-09-08 23:53:06 +00:00
### Resolution
2026-09-09 22:27:52 +00:00
The retained placeholder sentence was removed without changing the substantive
role documentation.
2026-09-09 22:27:52 +00:00
## Finding 2: Make the Composition Test Non-vacuous
2026-09-08 04:42:11 +00:00
Severity: low
2026-09-09 22:27:52 +00:00
`ansible-role-narratio/tests/representative.yml` claimed to exercise
caller-side composition, but both secondary fragments were empty. The verifier
consequently proved only that one original entry survived serialization.
2026-09-09 19:17:08 +00:00
2026-09-09 22:27:52 +00:00
### Resolution
The Scriptorium artifact map now combines two nonempty caller-defined
fragments, and the verifier checks one entry from each. Publish outputs use one
direct value so the suite retains only one representative composition case.
Native validation and the immediate clean repeat remain in place.
## Finding 3: Use Ansible Privilege Escalation Directly in Verifiers
Severity: low
Both configuration verifiers escalated to root and then executed
`/usr/bin/sudo -u narratio` inside `ansible.builtin.command`, creating a
redundant second privilege transition.
2026-09-08 23:53:06 +00:00
### Resolution
2026-09-09 22:27:52 +00:00
Both verifier tasks now use `become_user: narratio` and invoke Narratio
directly. The integration driver enables pipelining and uses `/tmp` for
Ansible's transient module area, avoiding the local controller's otherwise
unmet temporary-file ACL requirement without adding a nested sudo command.
2026-09-08 23:53:06 +00:00
## Final Validation
2026-09-09 19:17:08 +00:00
`bash -n tests/integration`, the complete `tests/integration` suite, and
2026-09-09 22:27:52 +00:00
`git diff --check` passed after remediation. Syntax checking and
production-profile lint passed within the integration entry point. Baseline,
missing-binary recovery, and representative-configuration scenarios passed
their native Narratio checks as the application account, every required
immediate repeat reported `changed=0` and `failed=0`, and cleanup restored the
usable baseline deployment. No unresolved Feature 0005 findings remain.