Classify invalid delivery destinations during preflight

This commit is contained in:
2026-11-01 19:24:52 +00:00
parent 627d524aa2
commit e5512d50b0
9 changed files with 146 additions and 14 deletions

View File

@@ -1,6 +1,6 @@
# Remediation: forge boundary and credential preflight review
Status: open; the findings below are unaddressed.
Status: remediation in progress; completion is recorded per issue below.
## Review baseline and scope
@@ -31,7 +31,14 @@ separate Git authentication and completion semantics.
## 1. Complete local destination preflight error handling — P2
Status: open.
Status: complete.
**Completed:** Added the facade-owned `DeliveryPreflightInvalidDestination`
classification, preserved the adapter's validation cause, and mapped it to CLI
status 2 for ordinary and CI delivery. Updated consumer/configuration guidance.
Focused standalone, automatic, and CLI regressions cover invalid URLs, owners,
and repository names, early termination, and absence of hosted/build work.
Focused preflight tests and the compiled API/dependency check passed.
**Evidence:** [Gitea preflight](../../internal/gitea/backend.go),
[public error conversion](../../delivery.go), and