base-layer/releasekit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Bound subprocess output teardown

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-02 03:14:59 +00:00
parent 94aedacf05
commit 9c02ed769b
4 changed files with 101 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
internal/build/build.go
View File

@@ -2,6 +2,7 @@
package build
import (
"bytes"
"context"
"crypto/sha256"
"encoding/hex"
@@ -9,7 +10,6 @@ import (
"fmt"
"io"
"os"
"os/exec"
"path/filepath"
"strings"
@@ -17,6 +17,7 @@ import (
"go.maximumdirect.net/releasekit/internal/candidate"
"go.maximumdirect.net/releasekit/internal/git"
"go.maximumdirect.net/releasekit/internal/gotool"
"go.maximumdirect.net/releasekit/internal/process"
"go.maximumdirect.net/releasekit/internal/releaseidentity"
"go.maximumdirect.net/releasekit/internal/tempdir"
"go.maximumdirect.net/releasekit/internal/versioncontract"
@@ -227,17 +228,14 @@ func hashArtifact(artifact *Artifact) error {
}
func checkVersion(ctx context.Context, binaryPath, binaryName, version string) error {
command := exec.CommandContext(ctx, binaryPath, "version")
output, err := command.CombinedOutput()
var output bytes.Buffer
err := process.Run(ctx, process.Invocation{Args: []string{binaryPath, "version"}, Stdout: &output, Stderr: &output})
if err != nil {
if ctx.Err() != nil {
return fmt.Errorf("run native version check: %w", ctx.Err())
}
return fmt.Errorf("run native version check: %w: %s", err, strings.TrimSpace(string(output)))
return fmt.Errorf("run native version check: %w: %s", err, strings.TrimSpace(output.String()))
}
want := binaryName + " " + version + "\n"
if string(output) != want {
return fmt.Errorf("native version output = %q, want %q", output, want)
if output.String() != want {
return fmt.Errorf("native version output = %q, want %q", output.String(), want)
}
return nil
}