Complete resource inspection validation and coverage

This commit is contained in:
2026-11-06 15:34:21 +00:00
parent 19a0604874
commit f083ad5309
6 changed files with 61 additions and 19 deletions

View File

@@ -6,11 +6,11 @@ Implement the accepted [resource inspection roadmap](inspect-backend.md). That
document owns intent, scope, and product decisions; this plan owns the concrete
steps and representation choices needed to deliver them.
Baseline: `951739e`. ConfigKit v1.1.0 composes and resolves definitions once.
Promptkit captures executable prompts and backend-completed profile targets.
`InspectPrompt` currently exposes limited metadata; `InspectProfile` exposes an
execution target. There is no `InspectBackend` or typed `PromptSource`, and
`BackendConfig` lacks `Extends`. Existing inspection values do not have the
At baseline `951739e`, ConfigKit v1.1.0 composed and resolved definitions once.
Promptkit captured executable prompts and backend-completed profile targets.
`InspectPrompt` exposed limited metadata; `InspectProfile` exposed an
execution target. There was no `InspectBackend` or typed `PromptSource`, and
`BackendConfig` lacked `Extends`. Existing inspection values did not have the
selected generic JSON/YAML contract.
Each numbered stage is intended for one Luna implementation prompt, in order.
@@ -571,6 +571,13 @@ ConfigKit composition contracts intact.
## Stage 12: Validate And Close The Sprint
**Completed:** Audited the selected resource, encoding, source, ownership, and
null-migration boundaries; added coverage for inherited diagnostics and explicit
serialization values. With Go 1.27.3, `GOTOOLCHAIN=local`, and `GOWORK=off`,
`go test -race ./...`, `go vet ./...`, and module tidy verification pass. Changed
Go files are formatted, local documentation targets and whitespace are checked,
and the feature roadmap and plan are retained for review.
**Scope:** Combined verification and final cleanup of this feature only.
1. Confirm that all three inspection operations, every selected result field,

View File

@@ -6,8 +6,8 @@ Help operators using CommandKit-based applications inspect the configured
prompt, profile, or backend selected by ID. CommandKit owns commands and report
presentation; Promptkit exposes the selected resource's resolved configuration.
The direction is accepted for planning; implementation has not begun. Selected
work includes fuller prompt inspection, profile inspection of the resolved
The selected work has been implemented; this roadmap is retained for review.
It includes fuller prompt inspection, profile inspection of the resolved
profile itself, a new `InspectBackend`, `BackendConfig.Extends`, typed prompt
construction through `PromptConfig`/`PromptSource`, generically renderable
inspection results, and simplification of Promptkit's post-handoff null handling.
@@ -26,7 +26,7 @@ inspection assembles everything affecting execution.
| --- | --- |
| `InspectPrompt` | Resolved prompt definition, including captured imported message content. |
| `InspectProfile` | Resolved profile definition, before backend-to-profile execution completion. |
| Proposed `InspectBackend` | Resolved backend definition, including configured diagnostic metadata. |
| `InspectBackend` | Resolved backend definition, including configured diagnostic metadata. |
For example, given:
@@ -153,8 +153,8 @@ lookup. A captured prompt remains inspectable without a runnable default profile
## Resolved Profile Inspection
This is a deliberate change to existing `InspectProfile` behavior. It currently
returns backend-completed `EffectiveModelParams`; the new resource boundary
This is a deliberate change to the former `InspectProfile` behavior. It previously
returned backend-completed `EffectiveModelParams`; the resource boundary
requires the resolved profile's own fields instead.
Report fields supplied by the profile or inherited through ConfigKit, including
@@ -346,11 +346,11 @@ source round-tripping are not selected deliverables.
All five decisions below are resolved, including generic rendering and the
post-handoff null simplification in decision 4. Numbering is retained for
continuity with the discussion; implementation is pending.
continuity with the discussion; the selected implementation is complete.
### 1. How Should An Unknown Backend Be Classified?
**Status:** Accepted; implementation pending.
**Status:** Accepted and implemented.
**Decision:** Add public `ErrBackendNotFound` for an absent backend selected by
`InspectBackend`, following the existing prompt/profile sentinel pattern.
@@ -391,7 +391,7 @@ where to place those additions remains necessary for resource inspection.
### 3. Should Typed Prompt Construction Be Added In This Round?
**Status:** Accepted; implementation pending.
**Status:** Accepted and implemented.
**Decision:** Add `PromptConfig` and `PromptSource`, including inheritance,
following the thin mapping-constructor pattern described above. Retain the
@@ -411,7 +411,7 @@ is unnecessary; raw mappings continue to serve those cases.
### 4. How Should Resolved Resource Results And Presence Be Represented?
**Status:** Accepted; implementation pending.
**Status:** Accepted and implemented.
**Decision (Option A):** Use resource-oriented typed inspection results, reusing
suitable public nested values. Change `ProfileInspection` deliberately to report