Simplify profile null fallback behavior

This commit is contained in:
2026-11-06 15:16:35 +00:00
parent 8add7c49e6
commit b0a16ccce8
5 changed files with 70 additions and 54 deletions

View File

@@ -23,7 +23,7 @@ func (state *loaded) buildExecutionProfiles() error {
state.indexedProfiles = make(map[string]domain.ExecutionProfile, len(profileConfigs))
for _, id := range sortedKeys(profileConfigs) {
config := profileConfigs[id]
profile, err := captureExecutionProfile(id, config, state.profiles[id], state.registry)
profile, err := captureExecutionProfile(id, config, state.registry)
if err != nil {
return err
}
@@ -62,7 +62,7 @@ func captureBackend(id string, config backendConfig) domain.Backend {
return definition
}
func captureExecutionProfile(id string, config profileConfig, fields map[string]fieldState, registry *backend.Registry) (domain.ExecutionProfile, error) {
func captureExecutionProfile(id string, config profileConfig, registry *backend.Registry) (domain.ExecutionProfile, error) {
target := defaults.ExecutionTargetDefault()
if config.Backend != nil && *config.Backend != "" {
selected, err := registry.GetBackend(*config.Backend)
@@ -75,47 +75,44 @@ func captureExecutionProfile(id string, config profileConfig, fields map[string]
target.ExtraParams = selected.ExtraParams
}
presence := domain.ExecutionTargetPresence{}
if fields["endpoint"] != fieldAbsent {
if config.Endpoint != nil {
target.Endpoint = valueOrZero(config.Endpoint)
}
if fields["model"] != fieldAbsent {
if config.Model != nil {
target.Model = valueOrZero(config.Model)
}
if fields["temperature"] != fieldAbsent {
if config.Temperature != nil {
target.Temperature = valueOrZero(config.Temperature)
presence.Temperature = fields["temperature"] == fieldValue
presence.Temperature = true
}
if fields["top_p"] != fieldAbsent {
if config.TopP != nil {
target.TopP = valueOrZero(config.TopP)
presence.TopP = fields["top_p"] == fieldValue
presence.TopP = true
}
if fields["max_tokens"] != fieldAbsent {
if config.MaxTokens != nil {
target.MaxTokens = valueOrZero(config.MaxTokens)
presence.MaxTokens = fields["max_tokens"] == fieldValue
presence.MaxTokens = true
}
if fields["timeout_seconds"] == fieldValue {
if config.TimeoutSeconds != nil {
target.TimeoutSeconds = valueOrZero(config.TimeoutSeconds)
presence.TimeoutSeconds = true
}
if fields["service_tier"] != fieldAbsent {
if config.ServiceTier != nil {
target.ServiceTier = valueOrZero(config.ServiceTier)
}
if fields["reasoning_effort"] != fieldAbsent {
if config.ReasoningEffort != nil {
target.ReasoningEffort = valueOrZero(config.ReasoningEffort)
}
if fields["api_key_env"] != fieldAbsent {
if config.APIKeyEnv != nil {
target.APIKeyEnv = valueOrZero(config.APIKeyEnv)
}
if fields["api_key_required"] != fieldAbsent {
if config.APIKeyRequired != nil {
target.APIKeyRequired = valueOrZero(config.APIKeyRequired)
}
if target.APIKeyRequired && fields["api_key_env"] == fieldAbsent {
if target.APIKeyRequired && config.APIKeyEnv == nil {
target.APIKeyEnv = ""
}
switch fields["extra_params"] {
case fieldNull:
target.ExtraParams = nil
case fieldValue:
if config.ExtraParams != nil {
merged, err := overlayProviderMap(target.ExtraParams, config.ExtraParams)
if err != nil {
return domain.ExecutionProfile{}, fmt.Errorf("profile %q extra parameters: %w", id, err)