Test artifact hashes as opaque values

This commit is contained in:
2026-11-05 14:31:14 +00:00
parent e7a3665443
commit a91bc1608b
3 changed files with 16 additions and 10 deletions

View File

@@ -757,6 +757,10 @@ second catalog matrix. Focused bundle tests pass on Go 1.27.3.
meaningful without choosing an opaque value's algorithm. Keep benchmark setup meaningful without choosing an opaque value's algorithm. Keep benchmark setup
outside timed work and do not add a new encoding guarantee. outside timed work and do not add a new encoding guarantee.
Completion: size-hint tests and benchmark correctness setup compare file hashes
to the same content read inline, without selecting a hash algorithm. Artifact
tests and one-iteration checks of both benchmark paths pass on Go 1.27.3.
## Stage 30: Remove Unconsumed State And Orphan Helpers ## Stage 30: Remove Unconsumed State And Orphan Helpers
**Catalog:** 30, remaining half of 32, 33. **Catalog:** 30, remaining half of 32, 33.

View File

@@ -3,8 +3,6 @@ package artifact
import ( import (
"bytes" "bytes"
"context" "context"
"crypto/sha256"
"fmt"
"mime" "mime"
"os" "os"
"path/filepath" "path/filepath"
@@ -153,9 +151,12 @@ func checkArtifactFileRead(b *testing.B, reader Reader, ref domain.ArtifactRef,
if !bytes.Equal(artifact.Body, want) || artifact.Size != int64(len(want)) { if !bytes.Equal(artifact.Body, want) || artifact.Size != int64(len(want)) {
b.Fatalf("artifact size=%d body length=%d, want %d", artifact.Size, len(artifact.Body), len(want)) b.Fatalf("artifact size=%d body length=%d, want %d", artifact.Size, len(artifact.Body), len(want))
} }
wantHash := fmt.Sprintf("%x", sha256.Sum256(want)) inline, err := NewCompositeReader().Read(context.Background(), domain.ArtifactRef{Type: domain.ArtifactRefInline, Body: string(want)})
if artifact.Hash != wantHash { if err != nil {
b.Fatalf("artifact hash=%q, want %q", artifact.Hash, wantHash) b.Fatal(err)
}
if inline.Hash == "" || artifact.Hash != inline.Hash {
b.Fatalf("file and inline hashes differ: %q/%q", artifact.Hash, inline.Hash)
} }
} }

View File

@@ -3,9 +3,7 @@ package artifact
import ( import (
"bytes" "bytes"
"context" "context"
"crypto/sha256"
"errors" "errors"
"fmt"
"os" "os"
"path/filepath" "path/filepath"
"strings" "strings"
@@ -284,9 +282,12 @@ func TestFileReaderUsesOpenedSizeOnlyAsACapacityHint(t *testing.T) {
if artifact.Name != filepath.Base(filePath) || artifact.URI != filePath || artifact.ContentType == "" { if artifact.Name != filepath.Base(filePath) || artifact.URI != filePath || artifact.ContentType == "" {
t.Fatalf("unexpected artifact metadata: name=%q URI=%q content type=%q", artifact.Name, artifact.URI, artifact.ContentType) t.Fatalf("unexpected artifact metadata: name=%q URI=%q content type=%q", artifact.Name, artifact.URI, artifact.ContentType)
} }
wantHash := fmt.Sprintf("%x", sha256.Sum256(tc.body)) inline, err := NewCompositeReader().Read(context.Background(), domain.ArtifactRef{Type: domain.ArtifactRefInline, Body: string(tc.body)})
if artifact.Hash != wantHash { if err != nil {
t.Fatalf("artifact hash=%q, want %q", artifact.Hash, wantHash) t.Fatal(err)
}
if inline.Hash == "" || artifact.Hash != inline.Hash {
t.Fatalf("file and inline hashes differ: %q/%q", artifact.Hash, inline.Hash)
} }
}) })
} }