Merge provider defaults into one owned copy

internal/configuration/targets.go

@@ -138,24 +138,33 @@ func overlayProviderMap(lower, upper map[string]any) (map[string]any, error) {
 	if merged == nil {
 		merged = make(map[string]any)
 	}
+	if err := overlayOwnedProviderMap(merged, upper); err != nil {
+		return nil, err
+	}
+	return merged, nil
+}
+
+func overlayOwnedProviderMap(merged, upper map[string]any) error {
 	for key, value := range upper {
 		if child, ok := value.(map[string]any); ok {
 			if existing, ok := merged[key].(map[string]any); ok {
-				combined, err := overlayProviderMap(existing, child)
-				if err != nil {
-					return nil, err
+				if existing == nil {
+					existing = make(map[string]any)
+					merged[key] = existing
+				}
+				if err := overlayOwnedProviderMap(existing, child); err != nil {
+					return err
 				}
-				merged[key] = combined
 				continue
 			}
 		}
 		copied, err := jsonvalue.Copy(value)
 		if err != nil {
-			return nil, err
+			return err
 		}
 		merged[key] = copied
 	}
-	return merged, nil
+	return nil
 }
 
 func (state *loaded) lookupProfile(ctx context.Context, id string) (domain.ExecutionProfile, error) {

internal/configuration/targets_test.go

@@ -42,6 +42,28 @@ func TestLoadIndexesIdentifiedTargets(t *testing.T) {
 	}
 }
 
+func TestOverlayProviderMapOwnsInputsAndReplacesValues(t *testing.T) {
+	lower := map[string]any{"nested": map[string]any{"keep": "lower", "replace": []any{"old"}, "null": "old"}, "disjoint": []any{"original"}}
+	upper := map[string]any{"nested": map[string]any{"replace": []any{"new"}, "null": nil, "added": map[string]any{"value": "upper"}}}
+	got, err := overlayProviderMap(lower, upper)
+	if err != nil {
+		t.Fatal(err)
+	}
+	want := map[string]any{"nested": map[string]any{"keep": "lower", "replace": []any{"new"}, "null": nil, "added": map[string]any{"value": "upper"}}, "disjoint": []any{"original"}}
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("overlay = %#v", got)
+	}
+	lower["disjoint"].([]any)[0] = "changed"
+	upper["nested"].(map[string]any)["replace"].([]any)[0] = "changed"
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("overlay shares input storage: %#v", got)
+	}
+	got["nested"].(map[string]any)["added"].(map[string]any)["value"] = "changed"
+	if upper["nested"].(map[string]any)["added"].(map[string]any)["value"] != "upper" {
+		t.Fatal("result mutation reached upper")
+	}
+}
+
 func TestRequestCompletesLoadedPartialProfile(t *testing.T) {
 	state, err := load(mapping("partial profile", map[string]any{
 		"profiles": []any{map[string]any{"id": "partial"}},