Simplify smoke report ownership
This commit is contained in:
@@ -6,7 +6,6 @@ import (
|
||||
"time"
|
||||
|
||||
"go.maximumdirect.net/promptkit/internal/domain"
|
||||
"go.maximumdirect.net/promptkit/internal/jsonvalue"
|
||||
)
|
||||
|
||||
// SmokeTestKind identifies one built-in diagnostic operation.
|
||||
@@ -272,11 +271,7 @@ func (e *Engine) SmokeTest(ctx context.Context, req SmokeTestRequest) (*SmokeTes
|
||||
if domainReport == nil {
|
||||
return nil, mapPublicError(err)
|
||||
}
|
||||
report, conversionErr := fromDomainSmokeTestReport(*domainReport)
|
||||
if conversionErr != nil {
|
||||
return nil, fmt.Errorf("%w: failed to copy smoke-test report", ErrInvalidRequest)
|
||||
}
|
||||
return report, mapPublicError(err)
|
||||
return fromDomainSmokeTestReport(*domainReport), mapPublicError(err)
|
||||
}
|
||||
|
||||
func toDomainSmokeTestRequest(request SmokeTestRequest) (domain.SmokeTestRequest, error) {
|
||||
@@ -295,11 +290,7 @@ func toDomainSmokeTestRequest(request SmokeTestRequest) (domain.SmokeTestRequest
|
||||
}, nil
|
||||
}
|
||||
|
||||
func fromDomainSmokeTestReport(report domain.SmokeTestReport) (*SmokeTestReport, error) {
|
||||
extraParams, err := jsonvalue.CopyMap(report.Target.EffectiveSettings.ExtraParams)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
func fromDomainSmokeTestReport(report domain.SmokeTestReport) *SmokeTestReport {
|
||||
result := &SmokeTestReport{
|
||||
Kind: SmokeTestKind(report.Kind),
|
||||
Supported: report.Supported,
|
||||
@@ -313,7 +304,7 @@ func fromDomainSmokeTestReport(report domain.SmokeTestReport) (*SmokeTestReport,
|
||||
DefaultSourceBackendID: report.Target.DefaultSourceBackendID,
|
||||
SelectionSource: report.Target.SelectionSource,
|
||||
Endpoint: report.Target.Endpoint,
|
||||
EffectiveSettings: fromDomainExecutionTargetWithOwnedParams(report.Target.EffectiveSettings, extraParams),
|
||||
EffectiveSettings: fromDomainExecutionTarget(report.Target.EffectiveSettings),
|
||||
SettingsPresence: fromDomainExecutionTargetPresence(report.Target.SettingsPresence),
|
||||
},
|
||||
Facts: fromDomainSmokeTestFacts(report.Facts),
|
||||
@@ -336,7 +327,7 @@ func fromDomainSmokeTestReport(report domain.SmokeTestReport) (*SmokeTestReport,
|
||||
}
|
||||
}
|
||||
}
|
||||
return result, nil
|
||||
return result
|
||||
}
|
||||
|
||||
func fromDomainSmokeTestFacts(facts domain.SmokeTestFacts) SmokeTestFacts {
|
||||
|
||||
Reference in New Issue
Block a user