Simplify smoke report ownership

This commit is contained in:
2026-11-05 20:12:40 +00:00
parent f5c900cb0a
commit 5dd1418953
5 changed files with 17 additions and 50 deletions

View File

@@ -29,14 +29,8 @@ func TestSmokeReportConversionOwnsMutableValues(t *testing.T) {
Timing: domain.SmokeTestTiming{RequestDuration: &duration},
}},
}
converted, err := fromDomainSmokeTestReport(source)
if err != nil {
t.Fatal(err)
}
other, err := fromDomainSmokeTestReport(source)
if err != nil {
t.Fatal(err)
}
converted := fromDomainSmokeTestReport(source)
other := fromDomainSmokeTestReport(source)
encoded, err := json.Marshal(converted)
if err != nil {
t.Fatal(err)
@@ -63,22 +57,8 @@ func TestSmokeReportConversionOwnsMutableValues(t *testing.T) {
if got := source.Target.EffectiveSettings.ExtraParams["nested"].([]any)[0].(map[string]any)["value"]; got != "original" {
t.Fatalf("converted report changed source provider parameters: %v", got)
}
later, err := fromDomainSmokeTestReport(source)
if err != nil {
t.Fatal(err)
}
later := fromDomainSmokeTestReport(source)
if !reflect.DeepEqual(other, later) {
t.Fatal("converted report mutation affected another result")
}
}
func TestSmokeReportConversionPreservesProviderMapCopyError(t *testing.T) {
report, err := fromDomainSmokeTestReport(domain.SmokeTestReport{
Target: domain.SmokeTestTarget{EffectiveSettings: domain.ExecutionTarget{
ExtraParams: map[string]any{"unsupported": func() {}},
}},
})
if err == nil || report != nil {
t.Fatalf("invalid provider data produced report=%+v, error=%v", report, err)
}
}