base-layer/promptkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

Strengthen continuation notification ownership coverage

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-14 17:49:44 +00:00
parent 8831ae35f7
commit 57b62d391e
2 changed files with 48 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
prepared_notification_contract_test.go
View File

@@ -126,6 +126,9 @@ func TestPreparedNotificationInvalidHandlesAndPreparationOnlyCalls(t *testing.T)
if _, err := foreign.RunPrepared(context.Background(), handle); !errors.Is(err, promptkit.ErrInvalidRequest) {
t.Fatal(err)
}
if _, err := engine.RunPrepared(context.Background(), nil); !errors.Is(err, promptkit.ErrInvalidRequest) {
t.Fatal(err)
}
handle.Discard()
if _, err := engine.RunPrepared(context.Background(), handle); !errors.Is(err, promptkit.ErrInvalidRequest) {
t.Fatal(err)
@@ -136,6 +139,30 @@ func TestPreparedNotificationInvalidHandlesAndPreparationOnlyCalls(t *testing.T)
if calls != 0 {
t.Fatalf("unexpected notifications=%d", calls)
}
handle, err = engine.PrepareExecution(context.Background(), req)
if err != nil {
t.Fatal(err)
}
if _, err := engine.RunPrepared(context.Background(), handle); err != nil {
t.Fatal(err)
}
if _, err := engine.RunPrepared(context.Background(), handle); !errors.Is(err, promptkit.ErrInvalidRequest) || calls != 1 {
t.Fatalf("reused handle error=%v notifications=%d", err, calls)
}
}
func TestNotificationHoldsAdmission(t *testing.T) {
engine := newBackendCapacityEngine(t, observationClientFunc(func(context.Context, promptkit.GenerateRequest) (*promptkit.GenerateResponse, error) {
return &promptkit.GenerateResponse{Content: "ok"}, nil
}), 1, capacityInt(0), nil)
_, err := engine.Run(context.Background(), promptkit.RunRequest{PromptID: "prompt", OnPrepared: func(ctx context.Context, _ promptkit.PreparedRun) {
if _, err := engine.Run(ctx, promptkit.RunRequest{PromptID: "prompt"}); !errors.Is(err, promptkit.ErrCapacityExceeded) {
t.Errorf("nested admission error=%v", err)
}
}})
if err != nil {
t.Fatal(err)
}
}
func TestNotificationPanicReleasesCapacityAndConsumesHandle(t *testing.T) {