Preserve operation ownership in terminal observations
This commit is contained in:
@@ -10,6 +10,10 @@ lifecycle instrumentation spans the facade and runner boundaries.
|
||||
Prepared execution starts only after its private payload is atomically claimed;
|
||||
the facade receives that invocation's recorder privately and emits the terminal
|
||||
event after public error mapping. Failed claims and preparation emit nothing.
|
||||
The public projection retains private operation-owner metadata separately from
|
||||
inspectable child causes. Terminal classification uses that owner, preserving
|
||||
context precedence and generation-specific transport/provider details rather
|
||||
than mistaking a collaborator's nested lookup error for the parent's operation.
|
||||
|
||||
The facade masks inherited recorder and prepared-claim state when entering
|
||||
preparation or execution. Delegated calls from an injected collaborator retain
|
||||
|
||||
@@ -27,7 +27,7 @@ listing, and evidence-union improvements. No selected workstream was deferred.
|
||||
The designs below preserve the selected target and rationale. Historical planning
|
||||
evidence later in this document describes the original baseline, not current
|
||||
replacement measurements. Follow-up corrections are tracked in the remediation
|
||||
record; finding 5 remains outstanding at this status update.
|
||||
record; all five follow-up findings are now addressed.
|
||||
Private helper names are descriptive unless identifying an existing declaration.
|
||||
Catalog numbers are traceability identifiers, not a required implementation
|
||||
order or 34 separate delivery stages. The scope
|
||||
|
||||
@@ -9,13 +9,13 @@ The implementation changes begin after planning commit `6a1a32a`.
|
||||
|
||||
An integration-focused follow-up reviewed the same implementation at `356563a`,
|
||||
the documentation-only commit recording the original review. It adds finding 5;
|
||||
the earlier findings remain open and are not duplicated.
|
||||
the earlier findings were still open at that audit baseline and are not duplicated.
|
||||
|
||||
The broad architecture and selected simplifications are in place. Five findings
|
||||
remain open below: three correctness/completeness issues, one error-projection
|
||||
efficiency issue, and one documentation-status gap. These reviews implement none
|
||||
of their remedies. The existing race suite passing does not cover the reproduced
|
||||
edge cases.
|
||||
The broad architecture and selected simplifications are in place. All five
|
||||
findings are now addressed, with completion markers below: three correctness/
|
||||
completeness issues, one error-projection efficiency issue, and one documentation
|
||||
status gap. Finding descriptions and audit evidence retain the historical
|
||||
pre-fix behavior; the completion markers describe the delivered corrections.
|
||||
|
||||
The accepted artifact ownership, supported convenience-source types, and
|
||||
self-contained schema changes are intentional compatibility changes. No
|
||||
@@ -211,7 +211,12 @@ retirement can follow when appropriate.
|
||||
|
||||
### 5. Integrate Operation Ownership With Terminal Observation Classification [P2]
|
||||
|
||||
**Status:** Open. **Related stages:** 3–4, 25–26.
|
||||
**Status:** Complete. **Related stages:** 3–4, 25–26.
|
||||
|
||||
Completion: a private public-boundary wrapper retains operation ownership and a
|
||||
single mapped cause. Terminal observations classify that owner while retaining
|
||||
context precedence and generation-specific transport/provider details. Observed
|
||||
run, prepared-run, repair, and artifact regressions retain child cause identity.
|
||||
|
||||
**Locations:** [terminal classifier](../../observations.go), `observedFinish`,
|
||||
lines 160–192; [public error projection](../../errors.go), `mapPublicError`;
|
||||
@@ -365,7 +370,16 @@ efficiency, and scalability of the implemented stages. It confirms the
|
||||
exponential behavior in finding 3 and adds the recurrence and refactoring
|
||||
opportunity there, rather than creating a duplicate finding. No additional
|
||||
distinct algorithmic or ordinary-correctness finding was identified in this
|
||||
pass. All five existing findings remain open.
|
||||
pass. All five findings were open at that audit baseline; their completion
|
||||
markers above own the current remediation status.
|
||||
|
||||
Remediation completion validation: Go 1.27.3 with `GOTOOLCHAIN=local`,
|
||||
`GOWORK=off`, and `GOPROXY=off` passed the complete
|
||||
`go test -race -count=1 ./...` suite and `go vet ./...`. New regressions cover
|
||||
authentication read interruption at the overflow boundary, host/FS schema
|
||||
portability, relocated native schema submission, nested-cause duplication, and
|
||||
operation-owned terminal observations. Focused checks passed before each code
|
||||
unit was committed. Documentation links, formatting, and whitespace were checked.
|
||||
|
||||
The review used the plan and roadmap to exclude deliberate algorithm choices:
|
||||
the small-to-large evidence merge, owned provider overlay, bounded feedback
|
||||
|
||||
Reference in New Issue
Block a user