Verify configured secrets startup handoff
This commit is contained in:
@@ -170,3 +170,52 @@ func TestSecretsFromConfigKeepsPartialReportSafe(t *testing.T) {
|
||||
t.Fatalf("report = %#v, source = %#v, error = %v", report, prepared, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSecretsFromConfigClosesOpenedFiles(t *testing.T) {
|
||||
for _, test := range []struct {
|
||||
name, contents string
|
||||
fails bool
|
||||
}{
|
||||
{"success", "value", false},
|
||||
{"read failure", "bad\x00value", true},
|
||||
} {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
main := writeImportFile(t, root, "main.yml", "config: {secrets_dir: secrets}\n")
|
||||
writeImportFile(t, root, "secrets/SECRET", test.contents)
|
||||
var opened []*os.File
|
||||
open := func(name string) (*os.File, error) {
|
||||
file, err := os.Open(name)
|
||||
if err == nil {
|
||||
opened = append(opened, file)
|
||||
}
|
||||
return file, err
|
||||
}
|
||||
access := testSecretsAccess()
|
||||
access.openDirectory, access.openFile = open, open
|
||||
_, prepared, err := loadSecretsFromConfig(File(main), nil, mapSecretsEnvironment(map[string]string{}), access)
|
||||
if (err != nil) != test.fails || (prepared.kind == sourceInvalid) != test.fails || len(opened) != 2 {
|
||||
t.Fatalf("source = %#v, error = %v, opened = %d", prepared, err, len(opened))
|
||||
}
|
||||
for _, file := range opened {
|
||||
if _, err := file.Stat(); !errors.Is(err, os.ErrClosed) {
|
||||
t.Fatalf("file %q remains open: %v", file.Name(), err)
|
||||
}
|
||||
}
|
||||
// On systems exposing process descriptors, also check the main file,
|
||||
// whose normal acquisition uses the shared regular-file reader.
|
||||
entries, err := os.ReadDir("/proc/self/fd")
|
||||
if err != nil {
|
||||
return
|
||||
}
|
||||
canonical := canonicalTestPath(t, main)
|
||||
canonicalRoot := canonicalTestPath(t, root)
|
||||
for _, entry := range entries {
|
||||
target, err := os.Readlink(filepath.Join("/proc/self/fd", entry.Name()))
|
||||
if err == nil && (target == canonical || target == canonicalRoot) {
|
||||
t.Fatalf("main or root remains open through descriptor %s", entry.Name())
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user