Expose configured secrets bootstrap APIs
This commit is contained in:
103
facade_secrets_config_test.go
Normal file
103
facade_secrets_config_test.go
Normal file
@@ -0,0 +1,103 @@
|
||||
package configkit_test
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
configkit "go.maximumdirect.net/configkit"
|
||||
)
|
||||
|
||||
var _ func(string) (*configkit.SecretsReport, error) = configkit.LoadSecretsIntoEnvironment
|
||||
|
||||
func TestFacadeSecretsOptionsAndConfiguredPrecedence(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
directory := filepath.Join(root, "secrets")
|
||||
if err := os.Mkdir(directory, 0o700); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := os.WriteFile(filepath.Join(directory, "CONFIGKIT_FACADE_SECRET"), []byte("replacement\n"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Setenv("CONFIGKIT_FACADE_SECRET", "old")
|
||||
report, err := configkit.LoadSecretsIntoEnvironmentWithOptions(directory, configkit.SecretsOptions{Overwrite: true})
|
||||
if err != nil || len(report.Entries()) != 1 || report.Entries()[0].Status != configkit.SecretFileLoaded || os.Getenv("CONFIGKIT_FACADE_SECRET") != "replacement" {
|
||||
t.Fatalf("direct report = %#v, error = %v", report, err)
|
||||
}
|
||||
for _, test := range []struct {
|
||||
name, setting, want string
|
||||
overwrite *bool
|
||||
}{
|
||||
{"default", "", "old", nil},
|
||||
{"yaml true", " secrets_overwrite: true\n", "replacement", nil},
|
||||
{"false overrides true", " secrets_overwrite: true\n", "old", facadeBool(false)},
|
||||
{"true overrides false", " secrets_overwrite: false\n", "replacement", facadeBool(true)},
|
||||
} {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
t.Setenv("CONFIGKIT_FACADE_SECRET", "old")
|
||||
main := filepath.Join(root, "main.yml")
|
||||
if err := os.WriteFile(main, []byte("config:\n secrets_dir: secrets\n"+test.setting+"value: original\n"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
var report *configkit.SecretsReport
|
||||
var prepared configkit.Source
|
||||
var err error
|
||||
if test.overwrite == nil {
|
||||
report, prepared, err = configkit.LoadSecretsIntoEnvironmentFromConfig(configkit.File(main))
|
||||
} else {
|
||||
report, prepared, err = configkit.LoadSecretsIntoEnvironmentFromConfig(configkit.File(main), configkit.SecretsFromConfigOptions{Overwrite: test.overwrite})
|
||||
}
|
||||
if err != nil || report == nil || len(report.Entries()) != 1 || os.Getenv("CONFIGKIT_FACADE_SECRET") != test.want {
|
||||
t.Fatalf("report = %#v, error = %v", report, err)
|
||||
}
|
||||
if err := os.WriteFile(main, []byte("value: changed\n"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
loaded, err := configkit.Load[struct {
|
||||
Value string `yaml:"value"`
|
||||
}](prepared)
|
||||
if err != nil || loaded.Config.Value != "original" {
|
||||
t.Fatalf("prepared load = %#v, error = %v", loaded, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func facadeBool(value bool) *bool { return &value }
|
||||
|
||||
func TestFacadeSecretsFromConfigErrorsKeepPublicEvidence(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
directReport, directErr := configkit.LoadSecretsIntoEnvironmentWithOptions(filepath.Join(root, "missing"), configkit.SecretsOptions{Overwrite: true})
|
||||
var directFailure *configkit.SecretsError
|
||||
if directReport == nil || !errors.As(directErr, &directFailure) || len(directFailure.Diagnostics()) != 1 || directFailure.Diagnostics()[0].Code != configkit.CodeSecretsMissing {
|
||||
t.Fatalf("direct report = %#v, error = %#v", directReport, directErr)
|
||||
}
|
||||
main := filepath.Join(root, "main.yml")
|
||||
if err := os.WriteFile(main, []byte("config: {secrets_overwrite: invalid}\n"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
report, prepared, err := configkit.LoadSecretsIntoEnvironmentFromConfig(configkit.File(main), configkit.SecretsFromConfigOptions{Overwrite: facadeBool(false)})
|
||||
var loadErr *configkit.LoadError
|
||||
if report == nil || len(report.Entries()) != 0 || !errors.As(err, &loadErr) || len(loadErr.Sources()) != 1 || len(loadErr.Diagnostics()) != 1 || loadErr.Diagnostics()[0].Code != configkit.CodeSecretsInvalidValue || loadErr.Diagnostics()[0].Primary == nil || loadErr.Diagnostics()[0].Primary.SourceID != loadErr.Sources()[0].ID {
|
||||
t.Fatalf("preparation report = %#v, error = %#v", report, err)
|
||||
}
|
||||
if _, err := configkit.Load[struct{}](prepared); err == nil {
|
||||
t.Fatal("failed preparation returned a usable source")
|
||||
}
|
||||
report, _, err = configkit.LoadSecretsIntoEnvironmentFromConfig(configkit.File(main), configkit.SecretsFromConfigOptions{}, configkit.SecretsFromConfigOptions{})
|
||||
if report == nil || !errors.As(err, &loadErr) || len(loadErr.Diagnostics()) != 1 || loadErr.Diagnostics()[0].Code != configkit.CodeOptionsInvalid || len(loadErr.Sources()) != 0 {
|
||||
t.Fatalf("multiple options report = %#v, error = %#v", report, err)
|
||||
}
|
||||
if err := os.WriteFile(main, []byte("config: {secrets_dir: missing}\n"), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
report, prepared, err = configkit.LoadSecretsIntoEnvironmentFromConfig(configkit.File(main))
|
||||
var secretsErr *configkit.SecretsError
|
||||
if report == nil || !errors.As(err, &secretsErr) || len(secretsErr.Diagnostics()) != 1 || secretsErr.Diagnostics()[0].Code != configkit.CodeSecretsMissing {
|
||||
t.Fatalf("directory report = %#v, error = %#v", report, err)
|
||||
}
|
||||
if _, err := configkit.Load[struct{}](prepared); err == nil {
|
||||
t.Fatal("failed bootstrap returned a usable source")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user