Remove superseded history attribution paths
This commit is contained in:
@@ -272,19 +272,18 @@ func TestProjectedSequenceHistoryAgreesAcrossMetadataAndExplanation(t *testing.T
|
||||
t.Fatalf("compose diagnostics = %#v", diagnostics)
|
||||
}
|
||||
path := Keys("records").Index(1).Key("token")
|
||||
var metadata Metadata
|
||||
finalizeMetadataPaths(&metadata, composed.root, composed.applications)
|
||||
baseline := &document.Node{Kind: document.Mapping}
|
||||
model := sourceHistoryModelForInspection(baseline, composed.root, composed.origins, composed.applications, composed.overlays)
|
||||
metadata := Metadata{historyModel: model}
|
||||
finalizeEffectiveMetadataPaths(&metadata, composed.root)
|
||||
if !metadata.hasHistoricalPath(path) {
|
||||
t.Fatalf("projected metadata omitted shifted path %s: %#v", path, metadata.HistoricalPaths())
|
||||
}
|
||||
|
||||
baseline := &document.Node{Kind: document.Mapping}
|
||||
model := sourceHistoryModelForInspection(baseline, composed.root, composed.origins, composed.applications, composed.overlays)
|
||||
metadata.historyModel = model
|
||||
inspection := &Inspection{metadata: metadata, history: model, final: composed.root}
|
||||
inspection.secrets = classifySecretPaths(nil, func(candidate Path) bool {
|
||||
return reflect.DeepEqual(candidate, path)
|
||||
}, metadata, composed.root, nil)
|
||||
}, metadata)
|
||||
explanation, ok := inspection.Explain(path)
|
||||
if !ok || !explanation.Effective.Redacted {
|
||||
t.Fatalf("shifted explanation = %#v, %v", explanation, ok)
|
||||
@@ -323,15 +322,14 @@ func TestReplacedProjectedSensitiveRecordRemainsRedacted(t *testing.T) {
|
||||
})
|
||||
final := applications[len(applications)-1].value
|
||||
path := Keys("records").Index(1).Key("token")
|
||||
var metadata Metadata
|
||||
finalizeMetadataPaths(&metadata, final, applications)
|
||||
baseline := &document.Node{Kind: document.Mapping}
|
||||
model := sourceHistoryModelForInspection(baseline, final, nil, applications, nil)
|
||||
metadata.historyModel = model
|
||||
metadata := Metadata{historyModel: model}
|
||||
finalizeEffectiveMetadataPaths(&metadata, final)
|
||||
inspection := &Inspection{metadata: metadata, history: model, final: final}
|
||||
inspection.secrets = classifySecretPaths(nil, func(candidate Path) bool {
|
||||
return reflect.DeepEqual(candidate, path)
|
||||
}, metadata, final, nil)
|
||||
}, metadata)
|
||||
explanation, ok := inspection.Explain(path)
|
||||
if !ok || explanation.Effective.Present {
|
||||
t.Fatalf("replaced shifted record explanation = %#v, %v", explanation, ok)
|
||||
@@ -404,14 +402,13 @@ func TestMappedUpsertProjectsSensitiveReplacementEvidence(t *testing.T) {
|
||||
finalRecords, _ := documentAtPath(finalRoot, Keys("records"))
|
||||
finalRecords.Sequence = document.Clone(combined.value).Sequence
|
||||
|
||||
var metadata Metadata
|
||||
finalizeMetadataPaths(&metadata, finalRoot, applications)
|
||||
baseline := &document.Node{Kind: document.Mapping}
|
||||
model := sourceHistoryModelForInspection(baseline, finalRoot, nil, applications, nil)
|
||||
metadata.historyModel = model
|
||||
metadata := Metadata{historyModel: model}
|
||||
finalizeEffectiveMetadataPaths(&metadata, finalRoot)
|
||||
inspection := &Inspection{metadata: metadata, history: model, final: finalRoot}
|
||||
secretRule := func(candidate Path) bool { return reflect.DeepEqual(candidate, secretPath) }
|
||||
inspection.secrets = classifySecretPaths(nil, secretRule, metadata, finalRoot, nil)
|
||||
inspection.secrets = classifySecretPaths(nil, secretRule, metadata)
|
||||
explanation, ok := inspection.Explain(secretPath)
|
||||
if !ok || !explanation.Effective.Redacted {
|
||||
t.Fatalf("mapped replacement explanation = %#v, %v", explanation, ok)
|
||||
|
||||
Reference in New Issue
Block a user