Compare commits
14 Commits
integratio
...
integratio
| Author | SHA1 | Date | |
|---|---|---|---|
| 6c7d7c90de | |||
| 735b35a0a1 | |||
| 21dac4f89e | |||
| 9b673d0485 | |||
| 8a22dd6a4f | |||
| 20d2924338 | |||
| 2bd216f0d3 | |||
| 1c531e7109 | |||
| b9cede22f9 | |||
| 9d3ffff69f | |||
| a53bf9f916 | |||
| ed6060f344 | |||
| 1e92a87706 | |||
| f369d6a782 |
56
docs/cli.md
56
docs/cli.md
@@ -622,8 +622,9 @@ fields remain distinct.
|
||||
|
||||
Without `--check`, successful comparisons return status `0`, including empty
|
||||
results. Unsupported scopes and formats are usage errors. Application input
|
||||
checks can report usage or operational failures. Load and comparison failures
|
||||
use status `1`.
|
||||
checks can report usage or operational failures. Configuration load failures
|
||||
follow the [configuration failure classification](#configuration-failure-classification);
|
||||
other comparison failures use status `1`.
|
||||
|
||||
The bundled adapters load the left side before the right. Diagnostics identify
|
||||
the side and its sources; left-side diagnostics are retained if right loading
|
||||
@@ -666,8 +667,9 @@ request overrides. Backend reports describe configured backend fields. An
|
||||
value or a claim that one is available. Neither report resolves references or
|
||||
performs a network probe. See the [PromptKit resource inspection
|
||||
contracts](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/171fb11f4e967a1da3af57843c6467954b14ba09/resource_inspection.go).
|
||||
Omitting the ID is a usage error. Lookup failures and cancellation follow the
|
||||
shared operational failure rules.
|
||||
Omitting the ID is a usage error. Configuration loading follows the
|
||||
[configuration failure classification](#configuration-failure-classification);
|
||||
lookup failures and cancellation are operational.
|
||||
|
||||
### Resource namespace selection
|
||||
|
||||
@@ -721,7 +723,9 @@ application content in the report. It does not guarantee that a later model
|
||||
call will succeed. Application loaders and callbacks may have their own
|
||||
effects. The [PromptKit Prepare
|
||||
API](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/171fb11f4e967a1da3af57843c6467954b14ba09/engine.go)
|
||||
owns the prepared value and upstream preparation behavior.
|
||||
owns the prepared value and upstream preparation behavior. Configuration failures
|
||||
follow the [configuration failure classification](#configuration-failure-classification);
|
||||
other preparation failures are operational.
|
||||
|
||||
## PromptKit requirements
|
||||
|
||||
@@ -806,9 +810,10 @@ issues:
|
||||
PromptKit determines these findings and explanations. A partial report can
|
||||
still be a successful command result (status `0`); read `complete` and
|
||||
`issues` to understand what remains unknown. A reported issue alone does not
|
||||
fail this command. Load or selection failures, cancellation, and report
|
||||
delivery failures use status `1`. Invalid syntax, arguments, variable
|
||||
assignments, or formats use status `2`.
|
||||
fail this command. Configuration loading follows the [configuration failure
|
||||
classification](#configuration-failure-classification). Selection failures and
|
||||
cancellation use status `1`; invalid syntax, arguments, variable assignments,
|
||||
or formats use status `2`. Report delivery follows the [output failure rules](#output-failures).
|
||||
|
||||
### Concrete request validation
|
||||
|
||||
@@ -867,7 +872,9 @@ not certify provider acceptance or guarantee later execution. See PromptKit's
|
||||
[`Engine.ValidateRequest`
|
||||
API](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/171fb11f4e967a1da3af57843c6467954b14ba09/engine.go).
|
||||
|
||||
Request construction, engine loading, and validation failures use status `1`,
|
||||
Configuration errors returned by request construction or engine loading follow
|
||||
the [configuration failure classification](#configuration-failure-classification).
|
||||
Other request construction, loading, and validation failures use status `1`,
|
||||
retaining available diagnostics. Malformed syntax, missing arguments, and
|
||||
unsupported formats use status `2`. Messages follow the common reporting
|
||||
policy; report delivery failures follow the shared [output failure
|
||||
@@ -931,7 +938,8 @@ The owning provider controls membership and order. Namespace filters are
|
||||
passed to PromptKit without local membership interpretation. See the
|
||||
[PromptKit v0.21.0 consumer
|
||||
guide](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/171fb11f4e967a1da3af57843c6467954b14ba09/docs/consumers/pkg-promptkit.md)
|
||||
for resource and selection definitions.
|
||||
for resource and selection definitions. Catalog loading failures follow the
|
||||
[configuration failure classification](#configuration-failure-classification).
|
||||
|
||||
## PromptKit smoke testing
|
||||
|
||||
@@ -965,10 +973,13 @@ Status `0` means the requested operation and reporting completed without
|
||||
error. It does not mean every check passed: inspect the reported facts,
|
||||
`reason`, and whether the test was supported, applicable, and completed. For
|
||||
`all`, all four operations must return without error for status `0`.
|
||||
Individual errors use status `1`; the sequence continues after them but stops
|
||||
on cancellation, preserving results already obtained. A report returned with
|
||||
an error is still shown. Invalid syntax, arguments, formats, or conflicting
|
||||
namespace flags use status `2`.
|
||||
Configuration errors use the [configuration failure classification](#configuration-failure-classification);
|
||||
other individual errors use status `1`. For `all`, every failing operation must
|
||||
identify invalid configuration input to select status `2`; an operational
|
||||
failure or cancellation takes precedence. The sequence continues after errors
|
||||
but stops on cancellation, preserving results already obtained. A report
|
||||
returned with an error is still shown. Invalid syntax, arguments, formats, or
|
||||
conflicting namespace flags use status `2`.
|
||||
|
||||
### Smoke-test flags
|
||||
|
||||
@@ -1106,10 +1117,23 @@ and [engine API](https://forge.maximumdirect.net/base-layer/promptkit/src/commit
|
||||
| Status | Standard meaning |
|
||||
| --- | --- |
|
||||
| `0` | The operation succeeded. |
|
||||
| `1` | Loading, execution, cancellation, or output failed. |
|
||||
| `2` | The command syntax or supplied inputs were invalid. |
|
||||
| `1` | An operational loading or execution failure, cancellation, or output failure occurred. |
|
||||
| `2` | The command syntax, supplied inputs, or identifiable configuration input were invalid. |
|
||||
| `3` | `config diff --check` found differences. |
|
||||
|
||||
### Configuration failure classification
|
||||
|
||||
Standard configuration and PromptKit commands classify ConfigKit loading errors
|
||||
using their structured diagnostics. Identifiable invalid configuration input,
|
||||
including malformed YAML, decoding errors, and explicit semantic rejection,
|
||||
selects status `2`. Warnings do not fail a load. Missing or unreadable sources,
|
||||
schema and application wiring errors, callback failures, unknown or ambiguous
|
||||
diagnostics, and other failures select status `1`. An error with multiple
|
||||
failing branches selects status `2` only when every branch identifies invalid
|
||||
input; cancellation or a deadline always selects status `1`. Existing source
|
||||
and validation reports can still be delivered after a failed load. Filters on
|
||||
validation details do not change classification.
|
||||
|
||||
Applications may define additional results and decide how CommandKit's status
|
||||
maps to the process exit code. A command's successful status does not replace
|
||||
reading its report: partial requirements discovery and unsupported smoke
|
||||
|
||||
@@ -14,14 +14,14 @@ applications.
|
||||
| `go.maximumdirect.net/ckconfig` | You want operators to view, validate, explain, and compare ConfigKit configuration. |
|
||||
| `go.maximumdirect.net/ckprompt` | You want operators to inspect PromptKit resources, check and preview requests, or run smoke tests. |
|
||||
|
||||
Current integration source selects ConfigKit v1.2.0 and PromptKit v0.21.0.
|
||||
The v0.7.0 integrations select ConfigKit v1.2.0, and ckprompt selects PromptKit
|
||||
v0.21.0.
|
||||
|
||||
| Selection | Core | ckconfig | ckprompt | Upstream libraries and status |
|
||||
| --- | --- | --- | --- | --- |
|
||||
| Published core | v0.6.0 | — | — | Usable independently. |
|
||||
| ConfigKit integration | v0.6.0 | v0.6.0 | — | ConfigKit v1.1.0. |
|
||||
| PromptKit integration | v0.6.0 | v0.6.0 | v0.6.0 | ConfigKit v1.1.0 and PromptKit v0.20.0. |
|
||||
| Current integration source | v0.6.0 | Local | Local | ConfigKit v1.2.0 and PromptKit v0.21.0. Coordinated releases are pending. |
|
||||
| ConfigKit integration | v0.6.0 | v0.7.0 | — | ConfigKit v1.2.0. |
|
||||
| PromptKit integration | v0.6.0 | v0.7.0 | v0.7.0 | ConfigKit v1.2.0 and PromptKit v0.21.0. |
|
||||
| Earlier matched integration set | v0.3.0 | v0.2.0 | v0.2.0 | ConfigKit v0.8.0 and PromptKit v0.16.0, using their earlier import paths. |
|
||||
|
||||
Install the published core with:
|
||||
@@ -30,13 +30,17 @@ Install the published core with:
|
||||
go get go.maximumdirect.net/commandkit@v0.6.0
|
||||
```
|
||||
|
||||
Select either integration with `go get go.maximumdirect.net/ckconfig@v0.6.0`
|
||||
or `go get go.maximumdirect.net/ckprompt@v0.6.0`. The published integrations
|
||||
select core v0.6.0, and ckprompt selects ckconfig v0.6.0, which includes
|
||||
Select either integration with `go get go.maximumdirect.net/ckconfig@v0.7.0`
|
||||
or `go get go.maximumdirect.net/ckprompt@v0.7.0`. The published integrations
|
||||
select core v0.6.0. ckprompt v0.7.0 selects ckconfig v0.7.0, which includes
|
||||
`AdaptDiagnostics`.
|
||||
They build independently against these released dependencies; a local workspace
|
||||
is optional for development. Published ckconfig v0.3.0 also uses ConfigKit v1.1.0
|
||||
and does not compose with ckprompt v0.2.0's earlier ConfigKit dependency.
|
||||
Those published versions build independently against their released dependencies.
|
||||
The current checkout of ckprompt uses an API added to local ckconfig after
|
||||
v0.7.0, so it requires the aligned workspace until ckconfig v0.8.0 is published
|
||||
and ckprompt updates its dependency. See the
|
||||
[release handoff](../roadmap/future.md#configuration-outcome-release-handoff).
|
||||
Published ckconfig v0.3.0 also uses ConfigKit v1.1.0 and does not compose with
|
||||
ckprompt v0.2.0's earlier ConfigKit dependency.
|
||||
|
||||
ConfigKit v1.2.0 adds fields to `Input` and `LayeredOptions`, so application
|
||||
loaders should use keyed struct literals when constructing them. ConfigKit's
|
||||
@@ -47,8 +51,6 @@ PromptKit v0.21.0 exposes main-relative companion imports through its existing
|
||||
configuration-source API. Applications select those inputs when constructing
|
||||
the engine supplied to ckprompt's loader callback. [PromptKit companion import guidance](https://forge.maximumdirect.net/base-layer/promptkit/src/commit/171fb11f4e967a1da3af57843c6467954b14ba09/docs/consumers/pkg-promptkit.md#load-companion-prompts-relative-to-the-main-configuration).
|
||||
|
||||
Coordinated integration releases are tracked in the future work record. [Pending integration work](../roadmap/future.md#pending-integration-work).
|
||||
|
||||
Importing a module does not install its commands. Pass commands to
|
||||
`commandkit.New` or `App.Register` explicitly. ckprompt depends on ckconfig's
|
||||
public APIs, but you can install its `promptkit` commands without installing
|
||||
@@ -323,6 +325,10 @@ acquired evidence. See `EffectiveWriter` and `ExplanationReader` in the
|
||||
[ckconfig GoDoc](../../integrations/ckconfig/contracts.go) for the provider boundary.
|
||||
`ckconfig.AdaptDiagnostics` captures native diagnostic presentation evidence
|
||||
for applications providing their own ConfigKit-backed CLI integration.
|
||||
[`ckconfig.ClassifyConfigurationError`](../../integrations/ckconfig/errors.go)
|
||||
provides the standard CLI outcome classification for ConfigKit errors; callers
|
||||
construct their own outcomes, explanations, and causes. The [CLI reference](../cli.md#configuration-failure-classification)
|
||||
describes the standard commands' status behavior.
|
||||
Set `Scope.Features.Overrides` only when the loader passes
|
||||
`Selection.Overrides` to ConfigKit as part of its normal load. The integration
|
||||
parses CLI records but cannot add them to an already-loaded result. The
|
||||
|
||||
@@ -119,12 +119,15 @@ If a workspace already exists, ensure it includes these three modules. Preserve
|
||||
the ignored `go.work` and `go.work.sum`; do not commit them. Use
|
||||
`GOWORK=off GOTOOLCHAIN=local` for dependency preparation
|
||||
and independent module suites. Both integrations select released core v0.6.0;
|
||||
ckprompt also selects released ckconfig v0.6.0. Their declared dependencies
|
||||
support independent builds. The aligned workspace exercises the local sources
|
||||
together.
|
||||
Run `GOWORK=off GOTOOLCHAIN=local go test ./...` separately from each module
|
||||
directory. From the repository root, a workspace containing all three modules can
|
||||
also run:
|
||||
ckprompt also selects released ckconfig v0.7.0. The current ckprompt source uses
|
||||
the new classifier in local ckconfig, so its independent build is pending
|
||||
publication of ckconfig v0.8.0 and a ckprompt dependency update. The aligned
|
||||
workspace exercises the local sources together; ckconfig remains independently
|
||||
buildable against its published dependencies. See the
|
||||
[release handoff](roadmap/future.md#configuration-outcome-release-handoff).
|
||||
Run `GOWORK=off GOTOOLCHAIN=local go test ./...` separately for core and
|
||||
ckconfig, and for ckprompt after its published dependency is updated. From the
|
||||
repository root, a workspace containing all three modules can also run:
|
||||
|
||||
```sh
|
||||
GOTOOLCHAIN=local go test ./...
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
# Future work
|
||||
|
||||
Status: pending integration releases, optional shell
|
||||
validation, and future capability proposals.
|
||||
Status: release coordination, optional shell validation, and future capability proposals.
|
||||
No delivery dates are selected here.
|
||||
|
||||
## Purpose and authority
|
||||
@@ -31,18 +30,23 @@ govern any future implementation. The [CLI reference](../cli.md), public GoDoc,
|
||||
and [consumer guide](../consumers/guide.md) own implemented behavior. Retaining
|
||||
an idea here does not select its syntax, API, priority, or delivery date.
|
||||
|
||||
## Pending integration work
|
||||
## Configuration outcome release handoff
|
||||
|
||||
ConfigKit v1.2.0 is adopted in both integration source modules, and ckprompt
|
||||
selects PromptKit v0.21.0. Release notes for ckconfig v0.7.0 and ckprompt v0.7.0
|
||||
are prepared in their respective release directories.
|
||||
The current ckprompt source requires the classifier in local ckconfig, while
|
||||
its published dependency remains ckconfig v0.7.0. The aligned workspace
|
||||
validates the source combination; ckprompt independent validation remains
|
||||
pending until the dependency is published and updated. Follow the
|
||||
[dependency-first release procedure](../release.md#scope-and-release-order):
|
||||
|
||||
Publish ckconfig v0.7.0 first. Then update ckprompt's declared ckconfig dependency
|
||||
from v0.6.0 to the published v0.7.0, refresh its checksums, and validate its
|
||||
independent candidate before publishing ckprompt v0.7.0. Update the consumer
|
||||
guide's published-version table as each release becomes available. The release
|
||||
procedure owns version availability checks, final validation, and publication.
|
||||
[Release procedure](../release.md#scope-and-release-order).
|
||||
1. When publication is authorized, publish ckconfig v0.8.0 from its independently
|
||||
validated candidate.
|
||||
2. Prepare ckprompt against the actual published ckconfig v0.8.0 using `go get`
|
||||
and `go mod download` with `GOWORK=off GOTOOLCHAIN=local`, retaining the real
|
||||
checksums. Complete its v0.8.0 release note, compatibility guidance, and
|
||||
candidate preparation under the existing rules for its other dependencies.
|
||||
3. Independently validate and publish ckprompt v0.8.0 under the same
|
||||
authorization and procedure. Track hosted release delivery separately under
|
||||
the runbook.
|
||||
|
||||
## Optional verification
|
||||
|
||||
|
||||
373
docs/roadmap/implementation.md
Normal file
373
docs/roadmap/implementation.md
Normal file
@@ -0,0 +1,373 @@
|
||||
# Invalid configuration outcome implementation
|
||||
|
||||
Status — complete. Release coordination remains in the
|
||||
[future work handoff](future.md#configuration-outcome-release-handoff).
|
||||
|
||||
## Sprint scope and baseline
|
||||
|
||||
Implement the accepted [feature roadmap](invalid-configuration-outcomes.md).
|
||||
Its target and accepted decisions govern the work. This plan supplies the
|
||||
specific API, diagnostic mapping, integration edits, and validation.
|
||||
|
||||
The planning baseline is commit `a53bf9f916ffb44d816f3929fb5297a68ad118c0`.
|
||||
Production sources still match the reviewed v0.7.0 integration baseline. Read
|
||||
[development guidance](../development.md), the [agent policy](../policy/agents.md),
|
||||
and the applicable architecture, testing, documentation, and release policies.
|
||||
|
||||
Execute Stage 1 through Stage 5 in order as one sprint. Intermediate stages may
|
||||
leave dependent work or test expectation updates for a later stage. Mark each
|
||||
stage complete with its actual verification evidence and commit completed units
|
||||
under the repository's local commit policy. Continue through the remaining
|
||||
stages using the decisions in this plan.
|
||||
|
||||
Use Go 1.27.0 and the ignored workspace containing core, ckconfig, and ckprompt.
|
||||
The new shared API will first exist in local ckconfig. ckprompt currently selects
|
||||
published ckconfig v0.7.0, which lacks it. The aligned workspace supplies local
|
||||
ckconfig throughout this sprint. Published dependency alignment is release
|
||||
coordination work described in Stage 5. Record that pending state explicitly
|
||||
when reporting validation.
|
||||
|
||||
## Stage 1 — Implement the shared classifier
|
||||
|
||||
Status — complete. Added the shared classifier and focused tests for the
|
||||
selected diagnostic codes, fallback evidence, wrappers, joins, cancellation,
|
||||
and real ConfigKit loading errors. Verified with Go 1.27.0 using
|
||||
`GOTOOLCHAIN=local GOPROXY=off go test ./integrations/ckconfig -run 'TestConfigurationDiagnosticClassification|TestClassifyConfigurationError' -count=1`
|
||||
in the aligned workspace (with a temporary writable Go build cache).
|
||||
|
||||
Add `integrations/ckconfig/errors.go` with the following exported function and
|
||||
GoDoc describing its CLI classification purpose, accepted evidence, fallback,
|
||||
nil behavior, and precedence.
|
||||
|
||||
```go
|
||||
func ClassifyConfigurationError(err error) commandkit.OutcomeKind
|
||||
```
|
||||
|
||||
The function returns an outcome kind and reads error evidence. Handlers own
|
||||
outcome construction, explanations, causes, and invocation context.
|
||||
|
||||
### Exact behavior
|
||||
|
||||
1. A nil error returns `commandkit.OutcomeSuccess`.
|
||||
2. A nonnil error matching `context.Canceled` or `context.DeadlineExceeded`
|
||||
through `errors.Is` returns `commandkit.OutcomeOperational`.
|
||||
3. Recognize a nonnil `*configkit.LoadError`, including ordinary wrapping, and
|
||||
inspect its complete `Diagnostics()` result. Ignore warning diagnostics.
|
||||
Require at least one error-severity diagnostic and classify as usage only
|
||||
when every error diagnostic has a usage code in the table below. An unknown
|
||||
severity, an operational or unknown error code, or insufficient error
|
||||
evidence selects operational.
|
||||
4. Traverse ordinary `Unwrap() error` wrappers and `Unwrap() []error` branches.
|
||||
A join selects usage only when every nonnil failing branch selects usage.
|
||||
An operational branch wins in either ordering. A nonnil error exposing an
|
||||
empty child list is an unclassified failure and selects operational.
|
||||
5. Other nonnil errors select `commandkit.OutcomeOperational`. This includes an
|
||||
empty or typed-nil `*configkit.LoadError`, opaque application errors, and
|
||||
native PromptKit errors carrying their existing domain classifications.
|
||||
|
||||
Use the public ConfigKit constants in an explicit switch. The following table is
|
||||
the complete usage-code list for the selected ConfigKit v1.2.0 baseline. All
|
||||
error codes outside it select operational.
|
||||
|
||||
| Evidence | ConfigKit constants selecting usage |
|
||||
| --- | --- |
|
||||
| YAML content and fixed parser input bounds | `CodeYAMLInvalid`, `CodeYAMLEmpty`, `CodeYAMLMultipleDocuments`, `CodeYAMLRootType`, `CodeYAMLDuplicateKey`, `CodeYAMLTag`, `CodeYAMLAnchor`, `CodeYAMLAlias`, `CodeYAMLMergeKey`, `CodeYAMLScalar`, `CodeYAMLDepthLimit`, `CodeYAMLNodeLimit` |
|
||||
| Typed decoding | `CodeDecodeType`, `CodeDecodeNull`, `CodeDecodeRange`, `CodeDecodeDuration`, `CodeDecodeText`, `CodeDecodeUnknownField`, `CodeDecodeArrayLength` |
|
||||
| Excessive individual source input | `CodeSourceLimitExceeded` |
|
||||
| Unsupported import directives and invalid graph relationships | `CodeImportDisabled`, `CodeImportCycle`, `CodeImportRepeated`, `CodeImportVersion` |
|
||||
| Sequence declarations and peer composition | `CodeSequenceInvalid`, `CodeSequenceConflict`, `CodeComposeInvalid`, `CodeComposeConflict` |
|
||||
| Protected version contributions | `CodeUnderlayVersion`, `CodeOverlayVersion` |
|
||||
| Invalid overlay relationships and directives | `CodeOverlayRepeated`, `CodeOverlayDirective` |
|
||||
| Version and explicit semantic rejection | `CodeVersionType`, `CodeVersionError`, `CodeResolveError`, `CodeValidateError` |
|
||||
| Inheritance declarations and references | `CodeInheritanceInvalid`, `CodeInheritanceMissing`, `CodeInheritanceCycle`, `CodeInheritanceVersion` |
|
||||
| Invalid override paths and conflicting assignments | `CodeOverrideInvalidPath`, `CodeOverrideDuplicate`, `CodeOverrideOverlap`, `CodeOverrideDirective`, `CodeOverrideVersion` |
|
||||
| Excessive override input | `CodeOverrideLimitExceeded` |
|
||||
| Invalid or absent typed secret references | `CodeSecretRequired`, `CodeSecretInvalidName` |
|
||||
|
||||
The mapping follows the public code meanings and ConfigKit v1.2.0's
|
||||
`docs/config.md` sections on input limits, YAML documents, composition,
|
||||
inheritance, overrides, secret references, and safe failures. Review the pinned
|
||||
module source and documentation in the Go module cache when implementing it.
|
||||
|
||||
The fallback intentionally includes these reviewed cases.
|
||||
|
||||
- Acquisition failures, including missing or unreadable sources and imports,
|
||||
permission failures, non-regular sources, and unavailable overlays.
|
||||
- `CodeImportInvalid` and `CodeOverlayInvalid`, which cover both invalid content
|
||||
and acquisition/context failures. Their codes alone provide ambiguous evidence.
|
||||
- `CodeImportOutsideRoot` and `CodeOverlayOutsideRoot`, where containment can
|
||||
reflect source resolution and filesystem conditions.
|
||||
- `CodeImportLimitExceeded` and `CodeOverlayLimitExceeded`, whose acquisition
|
||||
budgets can encompass source graph and filesystem traversal work.
|
||||
- Schema and options errors, source-description and reused-reader errors,
|
||||
`CodeHistoryLimitExceeded`, and callback failures or invalid callback actions.
|
||||
- `CodeOverrideInvalidLabel` and `CodeOverrideInvalidValue`, whose meanings also
|
||||
cover malformed application-created records and unsupported Go values.
|
||||
- `CodeSecretUnset` and `CodeSecretEmpty`, which describe credential acquisition
|
||||
from the runtime environment. Secrets-directory bootstrap failures also follow
|
||||
the operational fallback.
|
||||
|
||||
The fixed source/parser bounds and override input budgets in the usage list
|
||||
identify excessive supplied input. The acquisition and retained-evidence budgets
|
||||
listed above retain operational classification under the accepted fallback.
|
||||
These choices classify returned evidence and leave upstream limits and
|
||||
validation rules with ConfigKit.
|
||||
|
||||
Implement straightforward error-tree traversal. Recognize the current typed
|
||||
loading error before following its children. Inspect join branches separately
|
||||
so an `errors.As` search over a whole join cannot hide later failures. Perform
|
||||
the cancellation `errors.Is` checks once at the public entry point, then walk
|
||||
the tree and inspect each encountered loading error's diagnostics once. A small
|
||||
private diagnostics classifier and recursive walker are appropriate here.
|
||||
|
||||
Add focused tests in `integrations/ckconfig/errors_test.go`.
|
||||
|
||||
- Exercise the mapping through the private diagnostics classifier using ordinary
|
||||
diagnostic values, including warnings, mixed evidence, unknown codes, and
|
||||
missing error evidence. Include each selected usage constant and representative
|
||||
operational families.
|
||||
- Exercise the exported function with real public loading-error fixtures,
|
||||
wrappers, all-input joins, mixed joins in both orders, nested joins,
|
||||
cancellation, deadlines, nil, and empty loading errors. Assert classification
|
||||
and preservation of the original error's supported identity.
|
||||
|
||||
Generate representative fixtures through public ConfigKit loading APIs. Assertions
|
||||
own CommandKit's mapping and traversal. Upstream domain validation remains owned
|
||||
by ConfigKit under the [testing policy](../policy/testing.md#upstream-integration-testing-ownership).
|
||||
|
||||
Run the focused classifier tests. Stage 5 owns the final independent module suite.
|
||||
|
||||
## Stage 2 — Apply classification and cancellation precedence in ckconfig
|
||||
|
||||
Status — complete. The configuration failure boundary now incorporates
|
||||
invocation cancellation and selects the shared classification. Tests cover all
|
||||
five operations, both comparison sides, filtered validation, report delivery,
|
||||
operational failures, and cancellation with retained causes. Updated the native
|
||||
override and simple-example expectations for their input diagnostic codes.
|
||||
Verified with Go 1.27.0: `GOTOOLCHAIN=local GOPROXY=off go test
|
||||
./integrations/ckconfig/...` in the aligned workspace, using a temporary Go
|
||||
build cache; both the integration and simple example passed.
|
||||
|
||||
Update `configFailure` in `integrations/ckconfig/operations.go` to receive
|
||||
`context.Context` as its first argument. Update its callers in `operations.go`,
|
||||
`show.go`, `sources.go`, `explain.go`, `validate.go`, and `diff.go` to pass the
|
||||
invocation context. Add context to `configAcquisitionFailure` and pass it through
|
||||
from `runConfigShow`.
|
||||
|
||||
At this failure boundary, sample `ctx.Err()` when context is available. If it is
|
||||
nonnull, use it as the cause when the operation cause is nil, or join it with the
|
||||
operation cause when `errors.Is` does not already identify it. Preserve the
|
||||
original cause directly when additional cancellation evidence is absent.
|
||||
|
||||
Call `ClassifyConfigurationError` with that combined cause. Construct
|
||||
`commandkit.Usage` for usage classification and `commandkit.Failure` otherwise.
|
||||
Keep the latter default for intentionally reported failures with a nil cause.
|
||||
Retain the existing explanation selection, details, and cause attachment.
|
||||
|
||||
Apply the result to all acquisition errors reaching the five configuration
|
||||
operations. Classification uses the returned error's complete evidence. Detailed
|
||||
validation filters and projected `View.Findings` are report inputs. Successful
|
||||
callbacks continue through their existing result flow.
|
||||
|
||||
Follow the existing operation-specific reporting lifecycle. Sources can emit
|
||||
their inventory after failed loading, validation can emit its reached-scope
|
||||
report, and comparisons retain side-specific diagnostics. The existing
|
||||
`config diff --check` domain outcome and core presentation rules apply.
|
||||
|
||||
Extend the existing command and native-adapter tests to cover these outcomes.
|
||||
|
||||
1. A wrapped malformed-YAML loading error returned through `FromConfigKit`
|
||||
produces usage status `2` for show, sources, validate, explain discovery, and
|
||||
diff. Assert the actionable diagnostic, typed cause, and appropriate report
|
||||
evidence for each operation.
|
||||
2. Diff handles a failure on either loading side and preserves the acquired
|
||||
diagnostic context. A detailed-validation filter hiding an error has the same
|
||||
classification as the unfiltered failure.
|
||||
3. Ordinary acquisition failures and a representative operational loading error
|
||||
produce status `1`.
|
||||
4. Already-canceled invocations produce status `1`, retain cancellation identity,
|
||||
and leave stdout empty before acquisition. A callback that cancels context
|
||||
and returns a loading error retains both causes and selects status `1`.
|
||||
5. An output failure while delivering a source or validation report after an
|
||||
input failure follows core's operational presentation-failure rule while
|
||||
retaining the configuration cause.
|
||||
|
||||
Use existing coverage in `detailed_validation_test.go`, `diff_execution_test.go`,
|
||||
the source/report tests, and `contracts_adapter_test.go` where suitable. Update
|
||||
the invalid-fixture expectations in `examples/simple/main_test.go`, which
|
||||
currently assert operational outcomes for native loading errors. Check related
|
||||
expectations against their actual fixture codes before changing them.
|
||||
|
||||
Run the changed command tests and the affected simple-example tests. Stage 5
|
||||
owns the final independent ckconfig suite.
|
||||
|
||||
## Stage 3 — Apply the shared function to PromptKit inspection and requests
|
||||
|
||||
Status — complete. PromptKit failure handling now samples invocation
|
||||
cancellation and applies the shared classifier, including the smoke handler
|
||||
call sites needed for compilation. Tests cover every catalog, named inspection,
|
||||
requirements, validation, preparation, native loader and builder failures,
|
||||
and cancellation with preserved causes. With Go 1.27.0, the aligned workspace
|
||||
passed `GOTOOLCHAIN=local GOPROXY=off go test ./integrations/ckprompt -skip
|
||||
'^TestPublicConfigDiffUsesPromptKitPairAndPreparedInputs$'`; that composition
|
||||
test and the composed example retain expectations for Stage 4. A temporary Go
|
||||
build cache was used.
|
||||
|
||||
Update `definitionFailure` in `integrations/ckprompt/command.go` to receive the
|
||||
invocation context and combine observed cancellation with the operation cause
|
||||
using the same handler-level approach as Stage 2. Call
|
||||
`ckconfig.ClassifyConfigurationError` and choose Usage or Failure while retaining
|
||||
the existing explanation and cause. A nil cause for a missing provider result
|
||||
still yields an operational failure.
|
||||
|
||||
Update all callers, including the catalog fallback in `newCatalogListCommand`,
|
||||
the handlers in `command.go`, `validation_command.go`, `preparation.go`, and the
|
||||
smoke handlers that Stage 4 will verify.
|
||||
|
||||
Cover every installed catalog and named prompt/profile/backend inspection,
|
||||
requirements discovery, concrete validation, and prepared-request preview.
|
||||
Configuration loading errors may come from engine loaders or request builders.
|
||||
The returned ConfigKit evidence selects the classification in each path.
|
||||
Native lookup, preparation, validation, and provider errors with insufficient
|
||||
configuration evidence take the operational fallback. Existing preflight and
|
||||
application input-check contracts continue to govern their own failures.
|
||||
|
||||
Retain the original upstream error and diagnostic adaptation in `adapters.go`.
|
||||
Use the newly context-aware failure boundary to observe cancellation when a
|
||||
callback returns an error before the handler's later success checkpoint.
|
||||
|
||||
Extend tests around `command_test.go`, `requirements_command_test.go`,
|
||||
`validation_command_test.go`, and `preparation_test.go`.
|
||||
|
||||
- Supply a shared real ConfigKit loading-error fixture through each relevant
|
||||
suite callback and representative native loader/builder paths. Assert usage
|
||||
status `2`, diagnostics, and `errors.As`/`errors.Is` preservation.
|
||||
- Cover an ordinary PromptKit lookup error, an ordinary loader or builder
|
||||
failure, and missing-result handling as operational outcomes.
|
||||
- Cover pre-canceled input and cancellation occurring with a returned loading
|
||||
error, checking status `1` and retained cancellation/loading identity.
|
||||
|
||||
Use table-driven cases for handlers with equivalent failure behavior. Reuse
|
||||
existing tests for forwarding and lifecycle semantics. Verify the affected
|
||||
packages using the aligned workspace.
|
||||
|
||||
## Stage 4 — Verify smoke aggregation and configuration composition
|
||||
|
||||
Status — complete. Verified individual and aggregate smoke outcomes, mixed
|
||||
failures and cancellation with retained reports and causes, and all five
|
||||
operations through the composed PromptKit configuration scope, including the
|
||||
right comparison side and pre-canceled invocations. Updated the existing
|
||||
comparison and composed-example expectations for input diagnostics. With Go
|
||||
1.27.0, `GOTOOLCHAIN=local GOPROXY=off go test ./integrations/ckprompt/...`
|
||||
passed in the aligned workspace using a temporary Go build cache.
|
||||
|
||||
In `integrations/ckprompt/smoke_command.go`, complete the context argument updates
|
||||
and apply the shared classification to individual failures and the final joined
|
||||
aggregate cause. Follow the existing sequential four-kind execution, cancellation
|
||||
stop behavior, report delivery, explanation combination, and acquired diagnostic
|
||||
flow. The classifier supplies the new aggregate outcome.
|
||||
|
||||
Extend `smoke_outcome_test.go`, `smoke_aggregate_test.go`, and related command
|
||||
tests to verify a single input failure, an all-input aggregate, a mixed
|
||||
input/operational aggregate, and cancellation joined with an input failure.
|
||||
Assert the available reports and all supplied error identities. Existing
|
||||
report-with-error behavior remains part of those assertions.
|
||||
|
||||
Exercise `ConfigScope` through the public ckconfig family in ckprompt tests.
|
||||
Use a loader returning a wrapped malformed-YAML loading error and cover show,
|
||||
sources, validate, explain discovery, and diff, including the right comparison
|
||||
side. This establishes that composed PromptKit configuration commands use the
|
||||
shared ckconfig policy. Check the accompanying source and validation report
|
||||
evidence and the already-canceled behavior.
|
||||
|
||||
Update affected assertions in `examples/composed/main_test.go` against the
|
||||
fixture's actual evidence. Add a focused fixture only where it establishes a
|
||||
CommandKit-specific composition or outcome boundary. Reuse the existing example
|
||||
and adapter tests for ordinary upstream capability forwarding.
|
||||
|
||||
Run the focused smoke/composition tests. Stage 5 owns the final aligned-workspace
|
||||
ckprompt suite. Review native lookup and operational error tests for accidental
|
||||
classification broadening.
|
||||
|
||||
## Stage 5 — Update documentation, validate, and record release coordination
|
||||
|
||||
Status — complete. Updated the CLI and consumer contracts, development
|
||||
guidance, ckconfig v0.8.0 release note, and dependency-first release handoff.
|
||||
With Go 1.27.0 and a temporary writable Go build cache, the independent ckconfig
|
||||
suite passed with `GOWORK=off GOTOOLCHAIN=local GOPROXY=off go test
|
||||
-mod=readonly ./...`. In the aligned workspace, the three prescribed
|
||||
`GOTOOLCHAIN=local GOPROXY=off go test -mod=readonly` commands passed for
|
||||
`./...`, `./integrations/ckconfig/...`, and `./integrations/ckprompt/...`.
|
||||
Reviewed the diff, local Markdown links and fragments, and whitespace. The
|
||||
independent ckprompt build remains pending publication and dependency alignment.
|
||||
|
||||
Update the implemented CLI contract in `docs/cli.md`, including the outcome
|
||||
table and affected load-failure wording in configuration comparison, inspection,
|
||||
requirements discovery, concrete validation, catalogs, preparation, and smoke
|
||||
testing. Document input classification, operational fallback, mixed-error
|
||||
precedence, and the existing output-failure rules. Add the new exported API's
|
||||
GoDoc and concise consumer guidance linked to it.
|
||||
|
||||
Prepare `integrations/ckconfig/docs/releases/v0.8.0.md` explaining the status
|
||||
contract change and shared classification API, using the module's existing
|
||||
release-note conventions and immutable licensing footer. Record the planned
|
||||
ckprompt v0.8.0 note and published-dependency update as release follow-up under
|
||||
`docs/roadmap/future.md`. The ckprompt candidate is prepared after ckconfig
|
||||
publication under the [release procedure](../release.md#scope-and-release-order).
|
||||
|
||||
### Final sprint verification
|
||||
|
||||
Format changed Go files. Run the commands below from the indicated module
|
||||
directories, with Go 1.27.0 on PATH. The default suites are deterministic and
|
||||
offline once selected dependencies are present in the module cache.
|
||||
|
||||
From `integrations/ckconfig`, verify its published dependencies independently.
|
||||
|
||||
```sh
|
||||
GOWORK=off GOTOOLCHAIN=local GOPROXY=off go test -mod=readonly ./...
|
||||
```
|
||||
|
||||
From the repository root, verify all three local modules together.
|
||||
|
||||
```sh
|
||||
GOTOOLCHAIN=local GOPROXY=off go test -mod=readonly ./...
|
||||
GOTOOLCHAIN=local GOPROXY=off go test -mod=readonly ./integrations/ckconfig/...
|
||||
GOTOOLCHAIN=local GOPROXY=off go test -mod=readonly ./integrations/ckprompt/...
|
||||
```
|
||||
|
||||
The integration commands include their maintained example packages. Review
|
||||
the final diff, Markdown links/fragments, and `git diff --check`. Confirm that
|
||||
the shared code mapping, error trees, cancellation, reporting, both scope
|
||||
adapters, and command families have the planned regression evidence. Report
|
||||
actual checks and any remaining failures.
|
||||
|
||||
ckprompt's independent published-dependency build is pending the ckconfig release
|
||||
because its current v0.7.0 selection lacks the new function. Keep that limitation
|
||||
visible in the development/consumer guidance and release handoff. Retain the
|
||||
existing published requirements through the implementation sprint. The ignored
|
||||
aligned workspace is the local build setup for the new source combination.
|
||||
|
||||
### Release handoff
|
||||
|
||||
Record these follow-up actions together in `future.md` so they survive later
|
||||
retirement of the implementation documents.
|
||||
|
||||
1. Publish ckconfig v0.8.0 from its independently validated candidate using the
|
||||
documented release process when publication is authorized.
|
||||
2. Prepare ckprompt with actual published ckconfig v0.8.0 using `go get` and
|
||||
`go mod download` with `GOWORK=off GOTOOLCHAIN=local`. Retain real checksums,
|
||||
then finish its v0.8.0 release note, consumer compatibility guidance, and
|
||||
release preparation. The other dependency selections follow their existing
|
||||
release preparation rules.
|
||||
3. Validate ckprompt independently against its updated published dependencies
|
||||
through its release candidate suite and publish ckprompt v0.8.0 under the
|
||||
same authorization and procedure. Track hosted release delivery under the
|
||||
runbook's separate delivery process.
|
||||
|
||||
These actions follow the existing dependency-first release procedure. The sprint
|
||||
can complete with verified local behavior and explicit pending release alignment.
|
||||
The release handoff identifies the remaining independent-build evidence.
|
||||
|
||||
Mark each completed stage with its implementation and verification evidence.
|
||||
Commit the completed sprint work under the repository policy and report its
|
||||
commits, checks, and pending release coordination.
|
||||
142
docs/roadmap/invalid-configuration-outcomes.md
Normal file
142
docs/roadmap/invalid-configuration-outcomes.md
Normal file
@@ -0,0 +1,142 @@
|
||||
# Invalid configuration outcomes
|
||||
|
||||
Status — implemented, with review remediation complete. The
|
||||
[implementation plan](implementation.md) and [remediation record](remediation.md)
|
||||
record the completed work and verification. Publication and downstream dependency
|
||||
alignment remain in the [release handoff](future.md#configuration-outcome-release-handoff).
|
||||
The accepted behavior and design decisions are recorded below.
|
||||
|
||||
## Purpose
|
||||
|
||||
Make standard ckconfig and ckprompt commands return usage status `2` for
|
||||
identifiable invalid configuration input, while returning operational status `1`
|
||||
for cancellation and other operational failures. Preserve actionable upstream
|
||||
diagnostics and supported typed error identity through the integration boundary.
|
||||
|
||||
CommandKit owns this CLI classification. ConfigKit and PromptKit own loading,
|
||||
validation, diagnostic meaning, and their public error contracts. Application
|
||||
commands own their domain outcomes. These responsibilities follow the
|
||||
[architecture policy](../policy/architecture.md#ownership-boundaries).
|
||||
|
||||
## Historical baseline
|
||||
|
||||
The reviewed baseline is CommandKit commit
|
||||
`1e92a87706e44684ee34395245e5b633474677e0`, following the publication of
|
||||
ckconfig v0.7.0 and ckprompt v0.7.0. Both integration modules select core
|
||||
v0.6.0 and ConfigKit v1.2.0. ckprompt selects ckconfig v0.7.0 and PromptKit
|
||||
v0.21.0. Their manifests own the dependency selections.
|
||||
|
||||
The consumer report reproduced malformed operator YAML in Audita, including
|
||||
its automatic `prompts.yml` companion and an explicitly selected application
|
||||
configuration. Delegated inspection returned `yaml.invalid` with status `1`,
|
||||
while Audita's processing command returned the same diagnostic with status `2`.
|
||||
The report's reproduction is retained in Audita's
|
||||
[upstream handoff](https://forge.maximumdirect.net/eric/audita/src/commit/a355f05a273d6ac9d577eab8d30caa60cb74eee8/docs/roadmap/implementation.md).
|
||||
|
||||
The initial review confirmed the baseline behavior through Audita's existing
|
||||
regression tests and a temporary public-API reproduction against the aligned
|
||||
CommandKit workspace.
|
||||
The latter covered catalog listing and all five configuration operations in both
|
||||
the application and PromptKit scopes, including wrapped ConfigKit loading errors
|
||||
and already-canceled contexts.
|
||||
|
||||
- [FromConfigKit](../../integrations/ckconfig/configkit_adapter.go) and
|
||||
[the PromptKit adapters](../../integrations/ckprompt/adapters.go) preserved the
|
||||
ConfigKit loading error and adapted its diagnostic evidence.
|
||||
- [configFailure](../../integrations/ckconfig/operations.go) and
|
||||
[definitionFailure](../../integrations/ckprompt/command.go) constructed operational
|
||||
outcomes for the affected failures. Configuration comparison and validation
|
||||
also reached the former helper.
|
||||
- ConfigKit's public `LoadError` represents several kinds of loading failure,
|
||||
including malformed YAML, acquisition errors, and schema or callback problems.
|
||||
Its public diagnostic codes provide the classification evidence. Its error
|
||||
contract intentionally exposes safe diagnostics and preserves its own typed
|
||||
identity across CommandKit adaptation.
|
||||
- `config sources` can report discovered source evidence after failed loading,
|
||||
and `config validate` can report failed validation. Cancellation observed
|
||||
before acquisition leaves stdout empty in the reviewed command paths.
|
||||
|
||||
At that baseline, the published CLI contract assigned loading failures status
|
||||
`1`. The implemented change classifies identifiable invalid configuration as
|
||||
usage status `2`, with operational fallback, as described in the
|
||||
[current CLI contract](../cli.md#configuration-failure-classification).
|
||||
|
||||
## Targeted end state
|
||||
|
||||
| Evidence available to the integration | Selected outcome |
|
||||
| --- | --- |
|
||||
| ConfigKit error diagnostics that identify invalid configuration input under the selected mapping | Usage, status `2` |
|
||||
| Caller cancellation or deadline observed at an existing operation checkpoint, or present in the returned error chain | Operational, status `1` |
|
||||
| I/O, schema or wiring defects, callback execution failures, and other recognized operational failures | Operational, status `1` |
|
||||
| An unrecognized failure, including a loading error with insufficient classification evidence | Operational, status `1` |
|
||||
| Successful acquisition with warnings | Follow the command's successful-result behavior |
|
||||
|
||||
Classification uses upstream structured evidence. Diagnostic text, filenames,
|
||||
and source labels serve presentation and provenance. The input-error code
|
||||
mapping follows the accepted decisions below.
|
||||
|
||||
The selected outcome retains the original returned cause, including ordinary
|
||||
wrapping and joined errors, so supported `errors.Is` and `errors.As` queries
|
||||
continue to work. Existing explanations, source context, diagnostic visibility,
|
||||
and operation-specific reporting lifecycles apply to the newly classified
|
||||
failures. Shared rendering and delivery failures follow the
|
||||
[core output-failure rules](../cli.md#output-failures), including their effect on
|
||||
usage outcomes.
|
||||
|
||||
Apply the classification to configuration acquisition failures throughout the
|
||||
standard suites, including failures returned by application callbacks when they
|
||||
carry the supported ConfigKit evidence. CLI syntax, resource lookup, request
|
||||
execution, and application-specific error semantics retain their owning
|
||||
contracts. The work concerns interpreting returned failure evidence at the CLI
|
||||
boundary.
|
||||
|
||||
## Release targets
|
||||
|
||||
Target ckconfig v0.8.0 followed by ckprompt v0.8.0, with released ckprompt
|
||||
selecting the published ckconfig version containing the shared API. This is a
|
||||
published status-contract change under the
|
||||
[compatibility policy](../policy/release.md#versioning-and-compatibility).
|
||||
Implementation and source publication have their own completion evidence under
|
||||
the [release procedure](../release.md). Pending downstream dependency alignment
|
||||
belongs in the release handoff.
|
||||
|
||||
## Accepted decisions
|
||||
|
||||
### Exact diagnostic-code mapping
|
||||
|
||||
Use a built-in, explicit mapping based on ConfigKit v1.2.0's public
|
||||
code semantics. Include YAML-content and decoding errors, explicit
|
||||
`version.error`, `resolve.error`, and `validate.error` findings, and other codes
|
||||
whose documented meaning clearly identifies invalid configuration content.
|
||||
Classify schema/options defects, acquisition failures, hook execution failures,
|
||||
invalid callback paths or records, and validation mutation as operational.
|
||||
Use operational classification for ambiguous limit, secret, and source-selection
|
||||
evidence. The implementation plan records the individual codes selected under
|
||||
this rule, including limits that explicitly identify excessive input and secret
|
||||
reference errors that explicitly identify invalid configuration.
|
||||
|
||||
This uses the evidence upstream already supplies and distinguishes reported
|
||||
configuration rejection from callback machinery failing. Source evidence
|
||||
alone may be insufficient to establish whether application-supplied data came
|
||||
from an operator, so the rule follows the meaning recorded in upstream
|
||||
diagnostics.
|
||||
|
||||
### Shared classification interface
|
||||
|
||||
Place one narrowly documented, exported classification function in ckconfig.
|
||||
Both integrations use it, with ckprompt accessing it through its existing
|
||||
dependency. The function inspects the returned error and its ConfigKit
|
||||
diagnostics and returns the appropriate outcome classification. Its
|
||||
responsibilities include the diagnostic mapping, operational fallback, and
|
||||
joined-error precedence.
|
||||
|
||||
Keep command explanation construction, cause attachment, reporting, and
|
||||
invocation-specific cancellation checks in their owning handlers. The
|
||||
implementation plan specifies the shared function as
|
||||
`ClassifyConfigurationError(error) commandkit.OutcomeKind`. It classifies nil as
|
||||
success, identifiable input failures as usage, and other failures as operational.
|
||||
|
||||
A shared implementation reduces drift across the two standard families and
|
||||
fits ckconfig's ownership of ConfigKit adaptation. The narrowly scoped public
|
||||
function adds an API maintenance obligation while allowing the mapping and
|
||||
error-chain rules to be maintained in one place.
|
||||
130
docs/roadmap/remediation.md
Normal file
130
docs/roadmap/remediation.md
Normal file
@@ -0,0 +1,130 @@
|
||||
# Configuration outcome review remediation
|
||||
|
||||
Status — R1 and R2 complete. Findings from the stage-by-stage review of
|
||||
[the implementation plan](implementation.md) at commit
|
||||
`8a22dd6`. Review findings concern the accepted
|
||||
[feature target](invalid-configuration-outcomes.md).
|
||||
|
||||
## R1 — Present ConfigKit diagnostics returned by request builders
|
||||
|
||||
Priority — P2. Status — complete. Affects Stages 3 and 4.
|
||||
|
||||
Completed by sharing ConfigKit loading-error diagnostic adaptation between engine
|
||||
loaders and all three request builders. Public-command regression coverage now
|
||||
checks malformed configuration, warnings and semantic rejection, ordinary builder
|
||||
failures, cancellation, preserved causes, and skipped engine loading across
|
||||
validation, preparation, individual smoke, and aggregate smoke. The regression
|
||||
fails against the original adapters using a temporary Go overlay and passes with
|
||||
the fix. All three aligned-workspace module suites and maintained examples passed
|
||||
with Go 1.27.0, offline dependencies, and read-only module metadata.
|
||||
|
||||
### Relevant implementation
|
||||
|
||||
- `WithRequestValidation` returns an empty acquisition when its builder fails in
|
||||
[adapters.go](../../integrations/ckprompt/adapters.go) at line 196.
|
||||
- `WithRequestPreparation` does the same in
|
||||
[preparation.go](../../integrations/ckprompt/preparation.go) at line 43.
|
||||
- `WithSmokeTesting` does the same in
|
||||
[smoke.go](../../integrations/ckprompt/smoke.go) at line 51.
|
||||
- The builder cases in
|
||||
[configuration_outcomes_test.go](../../integrations/ckprompt/configuration_outcomes_test.go)
|
||||
discard stderr and assert status and cause identity. The native engine-loader
|
||||
cases also assert diagnostic presentation.
|
||||
|
||||
### Circumstances and observed behavior
|
||||
|
||||
An application request builder can load configuration while deriving a concrete
|
||||
validation, preparation, or smoke request. If that load returns a wrapped
|
||||
`*configkit.LoadError`, the native adapter returns the original cause with an
|
||||
empty `Acquired` value. The handler correctly classifies the error, but receives
|
||||
an empty diagnostic/explanation acquisition. Core renders the handler's generic
|
||||
failure explanation and usage guidance.
|
||||
|
||||
A temporary public-API reproduction used a ConfigKit loading error for malformed
|
||||
`profiles: [` YAML with source label `operator-prompts.yml`. The following
|
||||
commands returned status `2` and retained the typed loading cause, while stderr
|
||||
omitted both `yaml.invalid` and the source label.
|
||||
|
||||
- `promptkit requirements validate example`
|
||||
- `promptkit show prepared example`
|
||||
- `promptkit test reachability`
|
||||
- `promptkit test all`
|
||||
|
||||
Returning the same error from the engine loader presented the diagnostic and
|
||||
source context in each command. Builder-failure cases invoked the engine loader
|
||||
zero times. The early builder returns predate this sprint, but they leave a gap
|
||||
in its accepted target of preserving actionable configuration diagnostics across
|
||||
the affected paths. Stage 3 explicitly includes diagnostics in the native
|
||||
loader/builder verification.
|
||||
|
||||
### Expected behavior and remediation
|
||||
|
||||
Adapt available ConfigKit source evidence, warnings, and terminal diagnostics
|
||||
from builder-returned loading errors through the same presentation logic used
|
||||
for engine-loader failures. Keep the original returned error as the cause and
|
||||
apply the shared classifier and handler cancellation precedence. A failing
|
||||
builder completes through its existing failure path.
|
||||
|
||||
Reuse `promptKitDiagnostics` and the error adaptation already performed by
|
||||
`loadPromptKitEngine`. A small private error-to-acquisition helper can make that
|
||||
adaptation available to all three builder-failure branches. Ordinary application
|
||||
errors follow their existing explanation and operational fallback behavior.
|
||||
|
||||
Extend the public-command builder cases to capture stderr and assert the
|
||||
diagnostic code, source context, usage status, and typed/wrapped cause. Cover
|
||||
validation, preparation, individual smoke, and aggregate smoke through their
|
||||
native adapters. Retain cancellation coverage and verify that the engine loader
|
||||
is skipped following a builder error. These assertions concern CommandKit's
|
||||
adaptation of supplied error evidence.
|
||||
|
||||
## R2 — Reconcile feature-roadmap status and baseline wording
|
||||
|
||||
Priority — P3. Status — complete. Affects Stage 5 documentation consistency.
|
||||
|
||||
Completed by marking the feature as implemented with review remediation complete,
|
||||
linking the release handoff, and labeling the old status behavior and failure
|
||||
helpers as historical baseline evidence. Verified the document against the
|
||||
implemented classifier, current CLI contract, and pending release coordination.
|
||||
Local Markdown links/fragments and whitespace checks passed.
|
||||
|
||||
At review time, the [feature roadmap](invalid-configuration-outcomes.md) said
|
||||
"pending implementation" at its opening. Its baseline section also described
|
||||
the current CLI contract as assigning loading failures status `1` and presented
|
||||
the status change as proposed. Meanwhile, the implementation plan recorded all
|
||||
stages complete, and the
|
||||
[CLI reference](../cli.md#configuration-failure-classification) documents the
|
||||
implemented status `2` classification and operational fallback.
|
||||
|
||||
Update the feature status to reflect implemented work, outstanding remediation,
|
||||
and the separately tracked release coordination. Describe the old status `1`
|
||||
contract explicitly as behavior at the reviewed baseline. Keep the historical
|
||||
baseline evidence and accepted decisions, with links to the current CLI contract
|
||||
and [release handoff](future.md#configuration-outcome-release-handoff).
|
||||
|
||||
## Review verification
|
||||
|
||||
Reviewed the code mapping and error-tree traversal in Stage 1, configuration
|
||||
failure handling in Stage 2, inspection and request paths in Stage 3, smoke
|
||||
aggregation and composed scopes in Stage 4, and documentation and release
|
||||
coordination in Stage 5. The classifier's usage switch matches all 48 constants
|
||||
in the plan. The implementation maintains the accepted ownership boundaries and
|
||||
operational fallback.
|
||||
|
||||
Using Go 1.27.0, offline dependencies, read-only module metadata, and a temporary
|
||||
writable build cache, the following suites passed.
|
||||
|
||||
- Root module in the aligned workspace, including the core example and scripts.
|
||||
- ckconfig independently against its declared published dependencies, including
|
||||
the simple example.
|
||||
- ckconfig in the aligned workspace, including the simple example.
|
||||
- ckprompt in the aligned workspace, including the composed example.
|
||||
|
||||
Checked 133 local Markdown links/fragments across the six Markdown files changed
|
||||
by the sprint and checked the sprint diff for whitespace errors. The temporary
|
||||
builder reproduction described in R1 exercised the public command boundary
|
||||
with deterministic, local failure fixtures.
|
||||
|
||||
ckprompt's independent published-dependency validation follows the recorded
|
||||
release handoff because its manifest still selects ckconfig v0.7.0. This is the
|
||||
planned release coordination state. The review identified no additional
|
||||
strengthened contracts or restrictions requiring remediation.
|
||||
119
integrations/ckconfig/config_outcomes_test.go
Normal file
119
integrations/ckconfig/config_outcomes_test.go
Normal file
@@ -0,0 +1,119 @@
|
||||
package ckconfig
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"go.maximumdirect.net/commandkit"
|
||||
"go.maximumdirect.net/configkit"
|
||||
)
|
||||
|
||||
func TestNativeConfigurationInputOutcomes(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("malformed-input", []byte("broken: [")))
|
||||
var native *configkit.LoadError
|
||||
if !errors.As(loadErr, &native) || len(native.Diagnostics()) == 0 {
|
||||
t.Fatalf("fixture: %v", loadErr)
|
||||
}
|
||||
wrapped := fmt.Errorf("application loader: %w", loadErr)
|
||||
app := newConfigTestApp(t, AppCommand(func(context.Context, Selection) (*configkit.Result[map[string]any], error) { return nil, wrapped }))
|
||||
cases := []struct {
|
||||
name string
|
||||
args []string
|
||||
report string
|
||||
}{
|
||||
{"show", []string{"config", "show"}, ""},
|
||||
{"sources", []string{"config", "sources", "--format=json"}, `"sources"`},
|
||||
{"validation", []string{"config", "validate", "--details", "--format=json"}, `"code": "yaml.invalid"`},
|
||||
{"filtered validation", []string{"config", "validate", "--details", "--code=not-selected", "--format=json"}, `"state": "filtered"`},
|
||||
{"discovery", []string{"config", "explain", "--list"}, ""},
|
||||
{"diff", []string{"config", "diff"}, ""},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var out, diag bytes.Buffer
|
||||
result := app.Execute(context.Background(), tc.args, commandkit.Streams{Out: &out, Err: &diag})
|
||||
var got *configkit.LoadError
|
||||
if result.Kind != commandkit.OutcomeUsage || result.Status != 2 || !errors.Is(result.Cause, loadErr) || !errors.As(result.Cause, &got) || got != native {
|
||||
t.Fatalf("outcome: %#v", result)
|
||||
}
|
||||
if !strings.Contains(diag.String(), native.Diagnostics()[0].Message) || !strings.Contains(diag.String(), "malformed-input") {
|
||||
t.Fatalf("diagnostics: %q", diag.String())
|
||||
}
|
||||
if tc.report != "" && !strings.Contains(out.String(), tc.report) {
|
||||
t.Fatalf("report: %q", out.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestNativeConfigurationComparisonFailureSides(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("bad-side", []byte("broken: [")))
|
||||
for _, bad := range []string{"left", "right"} {
|
||||
t.Run(bad, func(t *testing.T) {
|
||||
app := newConfigTestApp(t, AppCommand(func(_ context.Context, selection Selection) (*configkit.Result[map[string]any], error) {
|
||||
if selection.Config.Value == bad {
|
||||
return nil, fmt.Errorf("wrapped: %w", loadErr)
|
||||
}
|
||||
return configkit.Load[map[string]any](configkit.Bytes("good-side", []byte("ok: true")))
|
||||
}))
|
||||
var diag bytes.Buffer
|
||||
result := app.Execute(context.Background(), []string{"config", "diff", "--config=left", "--against-config=right"}, commandkit.Streams{Out: io.Discard, Err: &diag})
|
||||
if result.Kind != commandkit.OutcomeUsage || result.Status != 2 || !errors.Is(result.Cause, loadErr) || !strings.Contains(diag.String(), "bad-side") || !strings.Contains(diag.String(), bad) {
|
||||
t.Fatalf("outcome=%#v diagnostics=%q", result, diag.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestConfigurationFailureCancellationAndDelivery(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("bad-input", []byte("broken: [")))
|
||||
for _, args := range [][]string{{"config", "show"}, {"config", "sources"}, {"config", "validate"}, {"config", "explain", "--list"}, {"config", "diff"}} {
|
||||
t.Run(strings.Join(args, "_"), func(t *testing.T) {
|
||||
calls := 0
|
||||
app := newConfigTestApp(t, AppCommand(func(context.Context, Selection) (*configkit.Result[map[string]any], error) {
|
||||
calls++
|
||||
return nil, loadErr
|
||||
}))
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
var out bytes.Buffer
|
||||
result := app.Execute(ctx, args, commandkit.Streams{Out: &out, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, context.Canceled) || calls != 0 || out.Len() != 0 {
|
||||
t.Fatalf("outcome=%#v calls=%d output=%q", result, calls, out.String())
|
||||
}
|
||||
ctx, cancel = context.WithCancel(context.Background())
|
||||
defer cancel()
|
||||
app = newConfigTestApp(t, AppCommand(func(context.Context, Selection) (*configkit.Result[map[string]any], error) {
|
||||
cancel()
|
||||
return nil, loadErr
|
||||
}))
|
||||
result = app.Execute(ctx, args, commandkit.Streams{Out: io.Discard, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, context.Canceled) || !errors.Is(result.Cause, loadErr) {
|
||||
t.Fatalf("joined outcome=%#v", result)
|
||||
}
|
||||
})
|
||||
}
|
||||
app := newConfigTestApp(t, AppCommand(func(context.Context, Selection) (*configkit.Result[map[string]any], error) { return nil, loadErr }))
|
||||
for _, args := range [][]string{{"config", "sources"}, {"config", "validate"}} {
|
||||
result := app.Execute(context.Background(), args, commandkit.Streams{Out: shortWriter{}, Err: io.Discard})
|
||||
if result.Kind != commandkit.OutcomeOperational || result.Status != 1 || !errors.Is(result.Cause, loadErr) || result.Presentation.Output.State != commandkit.DeliveryIncomplete {
|
||||
t.Fatalf("delivery %v: %#v", args, result)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestConfigurationOperationalFailures(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.File("/nonexistent-commandkit-outcome-test"))
|
||||
for _, failure := range []error{errors.New("unavailable"), loadErr} {
|
||||
app := newConfigTestApp(t, AppCommand(func(context.Context, Selection) (*configkit.Result[map[string]any], error) { return nil, failure }))
|
||||
result := app.Execute(context.Background(), []string{"config", "show"}, commandkit.Streams{Out: io.Discard, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, failure) {
|
||||
t.Fatalf("outcome=%#v", result)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -10,25 +10,25 @@ import (
|
||||
func runConfigDiff[I, S any](invocation commandkit.Invocation, plan *configOperationPlan[I, S], state S) commandkit.Outcome {
|
||||
if plan.comparison == nil || plan.comparison.scope == nil {
|
||||
cause := errors.New("configuration comparison was not prepared")
|
||||
return configFailure("Configuration comparison was not prepared.", commandkit.Explanation{}, cause)
|
||||
return configFailure(invocation.Context, "Configuration comparison was not prepared.", commandkit.Explanation{}, cause)
|
||||
}
|
||||
selected := plan.comparison
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration comparison was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration comparison was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
compare := selected.scope.scope.Compare
|
||||
if compare == nil {
|
||||
cause := fmt.Errorf("configuration scope %q has no comparison callback", selected.scope.scope.Name)
|
||||
return configFailure("Configuration scope does not support comparison.", commandkit.Explanation{}, cause)
|
||||
return configFailure(invocation.Context, "Configuration scope does not support comparison.", commandkit.Explanation{}, cause)
|
||||
}
|
||||
acquired, err := compare(invocation.Context, selected.request, state)
|
||||
reporter := invocation.Reporter()
|
||||
queueConfigDiagnostics(reporter, acquired.Diagnostics)
|
||||
if err != nil {
|
||||
return configFailure(fmt.Sprintf("Unable to compare configuration scope %q.", selected.scope.scope.Name), acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to compare configuration scope %q.", selected.scope.scope.Name), acquired.Explanation, err)
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration comparison was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration comparison was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
outcome := renderPreparedConfigReport(invocation, acquired.Explanation, func() (any, error) {
|
||||
if plan.details {
|
||||
|
||||
19
integrations/ckconfig/docs/releases/v0.8.0.md
Normal file
19
integrations/ckconfig/docs/releases/v0.8.0.md
Normal file
@@ -0,0 +1,19 @@
|
||||
# CommandKit ckconfig v0.8.0
|
||||
|
||||
CommandKit ckconfig v0.8.0 classifies identifiable invalid ConfigKit input as a
|
||||
usage failure. The new `ClassifyConfigurationError` function exposes the same
|
||||
CLI classification for callers building their own outcomes.
|
||||
|
||||
## Compatibility and upgrade
|
||||
|
||||
Select `go.maximumdirect.net/ckconfig v0.8.0` with CommandKit core v0.6.0. The
|
||||
consumer minimum remains Go 1.27.0. Standard configuration commands now return
|
||||
status `2` for diagnostic evidence identifying invalid configuration input;
|
||||
previously these loading failures returned status `1`. Update scripts that
|
||||
interpret those statuses. Cancellation, operational failures, and ambiguous or
|
||||
unknown evidence remain status `1`. See the [CLI contract](../../../../docs/cli.md#configuration-failure-classification)
|
||||
and the [classifier GoDoc](../../errors.go) for details.
|
||||
|
||||
[COPYRIGHT](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckconfig/v0.8.0/integrations/ckconfig/COPYRIGHT) |
|
||||
[LICENSE](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckconfig/v0.8.0/integrations/ckconfig/LICENSE) |
|
||||
[ATTRIBUTION](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckconfig/v0.8.0/integrations/ckconfig/docs/oss/attribution.md)
|
||||
102
integrations/ckconfig/errors.go
Normal file
102
integrations/ckconfig/errors.go
Normal file
@@ -0,0 +1,102 @@
|
||||
package ckconfig
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
|
||||
"go.maximumdirect.net/commandkit"
|
||||
"go.maximumdirect.net/configkit"
|
||||
)
|
||||
|
||||
// ClassifyConfigurationError selects a CLI outcome from ConfigKit loading
|
||||
// diagnostics. A nil error is success. A loading error is usage only when it
|
||||
// contains at least one error diagnostic and all error diagnostics identify
|
||||
// invalid configuration input; warnings are ignored. Unknown evidence and
|
||||
// other errors are operational. Wrappers and joined errors are inspected, and
|
||||
// any operational branch, cancellation, or deadline takes precedence.
|
||||
// The caller remains responsible for constructing an outcome and its cause.
|
||||
func ClassifyConfigurationError(err error) commandkit.OutcomeKind {
|
||||
if err == nil {
|
||||
return commandkit.OutcomeSuccess
|
||||
}
|
||||
if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
return classifyConfigurationTree(err)
|
||||
}
|
||||
|
||||
func classifyConfigurationTree(err error) commandkit.OutcomeKind {
|
||||
if load, ok := err.(*configkit.LoadError); ok {
|
||||
if load == nil {
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
return classifyConfigurationDiagnostics(load.Diagnostics())
|
||||
}
|
||||
switch wrapped := err.(type) {
|
||||
case interface{ Unwrap() []error }:
|
||||
found := false
|
||||
for _, child := range wrapped.Unwrap() {
|
||||
if child == nil {
|
||||
continue
|
||||
}
|
||||
found = true
|
||||
if classifyConfigurationTree(child) != commandkit.OutcomeUsage {
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
}
|
||||
if found {
|
||||
return commandkit.OutcomeUsage
|
||||
}
|
||||
case interface{ Unwrap() error }:
|
||||
if child := wrapped.Unwrap(); child != nil {
|
||||
return classifyConfigurationTree(child)
|
||||
}
|
||||
}
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
|
||||
func classifyConfigurationDiagnostics(diagnostics []configkit.Diagnostic) commandkit.OutcomeKind {
|
||||
found := false
|
||||
for _, diagnostic := range diagnostics {
|
||||
switch diagnostic.Severity {
|
||||
case configkit.SeverityWarning:
|
||||
continue
|
||||
case configkit.SeverityError:
|
||||
found = true
|
||||
if !configurationInputCode(diagnostic.Code) {
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
default:
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
}
|
||||
if found {
|
||||
return commandkit.OutcomeUsage
|
||||
}
|
||||
return commandkit.OutcomeOperational
|
||||
}
|
||||
|
||||
func configurationInputCode(code configkit.Code) bool {
|
||||
switch code {
|
||||
case configkit.CodeYAMLInvalid, configkit.CodeYAMLEmpty, configkit.CodeYAMLMultipleDocuments,
|
||||
configkit.CodeYAMLRootType, configkit.CodeYAMLDuplicateKey, configkit.CodeYAMLTag,
|
||||
configkit.CodeYAMLAnchor, configkit.CodeYAMLAlias, configkit.CodeYAMLMergeKey,
|
||||
configkit.CodeYAMLScalar, configkit.CodeYAMLDepthLimit, configkit.CodeYAMLNodeLimit,
|
||||
configkit.CodeDecodeType, configkit.CodeDecodeNull, configkit.CodeDecodeRange,
|
||||
configkit.CodeDecodeDuration, configkit.CodeDecodeText, configkit.CodeDecodeUnknownField,
|
||||
configkit.CodeDecodeArrayLength, configkit.CodeSourceLimitExceeded,
|
||||
configkit.CodeImportDisabled, configkit.CodeImportCycle, configkit.CodeImportRepeated,
|
||||
configkit.CodeImportVersion, configkit.CodeSequenceInvalid, configkit.CodeSequenceConflict,
|
||||
configkit.CodeComposeInvalid, configkit.CodeComposeConflict, configkit.CodeUnderlayVersion,
|
||||
configkit.CodeOverlayVersion, configkit.CodeOverlayRepeated, configkit.CodeOverlayDirective,
|
||||
configkit.CodeVersionType, configkit.CodeVersionError, configkit.CodeResolveError,
|
||||
configkit.CodeValidateError, configkit.CodeInheritanceInvalid, configkit.CodeInheritanceMissing,
|
||||
configkit.CodeInheritanceCycle, configkit.CodeInheritanceVersion, configkit.CodeOverrideInvalidPath,
|
||||
configkit.CodeOverrideDuplicate, configkit.CodeOverrideOverlap, configkit.CodeOverrideDirective,
|
||||
configkit.CodeOverrideVersion, configkit.CodeOverrideLimitExceeded, configkit.CodeSecretRequired,
|
||||
configkit.CodeSecretInvalidName:
|
||||
return true
|
||||
default:
|
||||
return false
|
||||
}
|
||||
}
|
||||
93
integrations/ckconfig/errors_test.go
Normal file
93
integrations/ckconfig/errors_test.go
Normal file
@@ -0,0 +1,93 @@
|
||||
package ckconfig
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"testing"
|
||||
|
||||
"go.maximumdirect.net/commandkit"
|
||||
"go.maximumdirect.net/configkit"
|
||||
)
|
||||
|
||||
func TestConfigurationDiagnosticClassification(t *testing.T) {
|
||||
usageCodes := []configkit.Code{
|
||||
configkit.CodeYAMLInvalid, configkit.CodeYAMLEmpty, configkit.CodeYAMLMultipleDocuments, configkit.CodeYAMLRootType, configkit.CodeYAMLDuplicateKey, configkit.CodeYAMLTag, configkit.CodeYAMLAnchor, configkit.CodeYAMLAlias, configkit.CodeYAMLMergeKey, configkit.CodeYAMLScalar, configkit.CodeYAMLDepthLimit, configkit.CodeYAMLNodeLimit,
|
||||
configkit.CodeDecodeType, configkit.CodeDecodeNull, configkit.CodeDecodeRange, configkit.CodeDecodeDuration, configkit.CodeDecodeText, configkit.CodeDecodeUnknownField, configkit.CodeDecodeArrayLength, configkit.CodeSourceLimitExceeded,
|
||||
configkit.CodeImportDisabled, configkit.CodeImportCycle, configkit.CodeImportRepeated, configkit.CodeImportVersion, configkit.CodeSequenceInvalid, configkit.CodeSequenceConflict, configkit.CodeComposeInvalid, configkit.CodeComposeConflict, configkit.CodeUnderlayVersion, configkit.CodeOverlayVersion, configkit.CodeOverlayRepeated, configkit.CodeOverlayDirective,
|
||||
configkit.CodeVersionType, configkit.CodeVersionError, configkit.CodeResolveError, configkit.CodeValidateError, configkit.CodeInheritanceInvalid, configkit.CodeInheritanceMissing, configkit.CodeInheritanceCycle, configkit.CodeInheritanceVersion, configkit.CodeOverrideInvalidPath, configkit.CodeOverrideDuplicate, configkit.CodeOverrideOverlap, configkit.CodeOverrideDirective, configkit.CodeOverrideVersion, configkit.CodeOverrideLimitExceeded, configkit.CodeSecretRequired, configkit.CodeSecretInvalidName,
|
||||
}
|
||||
for _, code := range usageCodes {
|
||||
t.Run(string(code), func(t *testing.T) {
|
||||
ds := []configkit.Diagnostic{{Severity: configkit.SeverityWarning, Code: configkit.CodeSourceRead}, {Severity: configkit.SeverityError, Code: code}}
|
||||
if got := classifyConfigurationDiagnostics(ds); got != commandkit.OutcomeUsage {
|
||||
t.Fatalf("got %s", got)
|
||||
}
|
||||
})
|
||||
}
|
||||
for _, code := range []configkit.Code{configkit.CodeSourceMissing, configkit.CodeSourcePermission, configkit.CodeImportInvalid, configkit.CodeImportOutsideRoot, configkit.CodeImportLimitExceeded, configkit.CodeOverlayInvalid, configkit.CodeOverlayOutsideRoot, configkit.CodeOverlayLimitExceeded, configkit.CodeSchemaRoot, configkit.CodeOptionsInvalid, configkit.CodeHistoryLimitExceeded, configkit.CodeResolveHookFailed, configkit.CodeValidateMutation, configkit.CodeOverrideInvalidLabel, configkit.CodeOverrideInvalidValue, configkit.CodeSecretUnset, configkit.CodeSecretEmpty, configkit.CodeSecretsMissing, "future.code"} {
|
||||
t.Run(string(code), func(t *testing.T) {
|
||||
ds := []configkit.Diagnostic{{Severity: configkit.SeverityError, Code: configkit.CodeYAMLInvalid}, {Severity: configkit.SeverityError, Code: code}}
|
||||
if got := classifyConfigurationDiagnostics(ds); got != commandkit.OutcomeOperational {
|
||||
t.Fatalf("got %s", got)
|
||||
}
|
||||
})
|
||||
}
|
||||
for _, ds := range [][]configkit.Diagnostic{nil, {{Severity: configkit.SeverityWarning, Code: configkit.CodeYAMLInvalid}}, {{Severity: "future", Code: configkit.CodeYAMLInvalid}}, {{Severity: configkit.SeverityError, Code: configkit.CodeYAMLInvalid}, {Severity: "future"}}} {
|
||||
if got := classifyConfigurationDiagnostics(ds); got != commandkit.OutcomeOperational {
|
||||
t.Fatalf("%v: got %s", ds, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
type emptyChildren struct{}
|
||||
|
||||
func (emptyChildren) Error() string { return "empty" }
|
||||
func (emptyChildren) Unwrap() []error { return nil }
|
||||
|
||||
func TestClassifyConfigurationError(t *testing.T) {
|
||||
_, invalid := configkit.Load[map[string]any](configkit.Bytes("invalid", []byte("broken: [")))
|
||||
_, missing := configkit.Load[map[string]any](configkit.File("/nonexistent-commandkit-classifier-test"))
|
||||
var load *configkit.LoadError
|
||||
if !errors.As(invalid, &load) || load == nil {
|
||||
t.Fatalf("invalid fixture: %v", invalid)
|
||||
}
|
||||
if missing == nil {
|
||||
t.Fatal("missing fixture unexpectedly succeeded")
|
||||
}
|
||||
var typedNil *configkit.LoadError
|
||||
opaque := errors.New("opaque")
|
||||
cases := []struct {
|
||||
name string
|
||||
err error
|
||||
want commandkit.OutcomeKind
|
||||
}{
|
||||
{"nil", nil, commandkit.OutcomeSuccess},
|
||||
{"invalid", invalid, commandkit.OutcomeUsage},
|
||||
{"wrapped", fmt.Errorf("wrapped: %w", invalid), commandkit.OutcomeUsage},
|
||||
{"all input", errors.Join(invalid, fmt.Errorf("wrapped: %w", invalid)), commandkit.OutcomeUsage},
|
||||
{"mixed first", errors.Join(missing, invalid), commandkit.OutcomeOperational},
|
||||
{"mixed last", errors.Join(invalid, missing), commandkit.OutcomeOperational},
|
||||
{"nested", errors.Join(invalid, errors.Join(invalid, opaque)), commandkit.OutcomeOperational},
|
||||
{"canceled", errors.Join(invalid, context.Canceled), commandkit.OutcomeOperational},
|
||||
{"deadline", fmt.Errorf("deadline: %w", context.DeadlineExceeded), commandkit.OutcomeOperational},
|
||||
{"missing", missing, commandkit.OutcomeOperational},
|
||||
{"opaque", opaque, commandkit.OutcomeOperational},
|
||||
{"empty load", &configkit.LoadError{}, commandkit.OutcomeOperational},
|
||||
{"typed nil", typedNil, commandkit.OutcomeOperational},
|
||||
{"empty children", emptyChildren{}, commandkit.OutcomeOperational},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
if got := ClassifyConfigurationError(tc.err); got != tc.want {
|
||||
t.Fatalf("got %s, want %s", got, tc.want)
|
||||
}
|
||||
if errors.Is(tc.err, invalid) {
|
||||
var got *configkit.LoadError
|
||||
if !errors.As(tc.err, &got) || got == nil {
|
||||
t.Fatal("load identity lost")
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
@@ -176,11 +176,11 @@ func TestSimpleFailedLoadReportsEvidence(t *testing.T) {
|
||||
t.Fatalf("fixture failure = %v", failure)
|
||||
}
|
||||
outcome, output, _ := executeSimple(t, "config", "validate", "--config=fixtures/invalid.yml", "--details", "--severity=error", "--format=json")
|
||||
if outcome.Kind != commandkit.OutcomeOperational || !strings.Contains(output, `"state": "present"`) || !strings.Contains(output, `"severity": "error"`) {
|
||||
if outcome.Kind != commandkit.OutcomeUsage || !strings.Contains(output, `"state": "present"`) || !strings.Contains(output, `"severity": "error"`) {
|
||||
t.Fatalf("detailed failure = %#v %q", outcome, output)
|
||||
}
|
||||
outcome, output, _ = executeSimple(t, "config", "sources", "--config=fixtures/invalid.yml", "--source-id="+native.Sources()[0].ID, "--format=json")
|
||||
if outcome.Kind != commandkit.OutcomeOperational || !strings.Contains(output, `"id":`) || !strings.Contains(output, "invalid.yml") {
|
||||
if outcome.Kind != commandkit.OutcomeUsage || !strings.Contains(output, `"id":`) || !strings.Contains(output, "invalid.yml") {
|
||||
t.Fatalf("source failure = %#v %q", outcome, output)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -108,11 +108,11 @@ func runConfigExplanation[I, S any](invocation commandkit.Invocation, plan *conf
|
||||
name := selected.scope.scope.Name
|
||||
reporter := invocation.Reporter()
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration explanation was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration explanation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
if selected.scope.scope.Acquire == nil {
|
||||
cause := fmt.Errorf("configuration scope %q has no acquisition callback", name)
|
||||
return configFailure(fmt.Sprintf("Unable to explain configuration scope %q.", name), commandkit.Explanation{}, cause)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to explain configuration scope %q.", name), commandkit.Explanation{}, cause)
|
||||
}
|
||||
acquired, acquireErr := selected.scope.scope.Acquire(invocation.Context, Request{
|
||||
Operation: Explain,
|
||||
@@ -120,14 +120,14 @@ func runConfigExplanation[I, S any](invocation commandkit.Invocation, plan *conf
|
||||
}, selected.input, state)
|
||||
queueConfigAcquisition(reporter, acquired)
|
||||
if acquireErr != nil {
|
||||
return configFailure(fmt.Sprintf("Unable to explain configuration scope %q.", name), acquired.Explanation, acquireErr)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to explain configuration scope %q.", name), acquired.Explanation, acquireErr)
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration explanation was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration explanation was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
if plan.list {
|
||||
if acquired.Value.Metadata == nil {
|
||||
return configFailure("Configuration scope did not provide path metadata.", acquired.Explanation, fmt.Errorf("configuration scope %q declared path discovery without metadata", name))
|
||||
return configFailure(invocation.Context, "Configuration scope did not provide path metadata.", acquired.Explanation, fmt.Errorf("configuration scope %q declared path discovery without metadata", name))
|
||||
}
|
||||
report := pathDiscoveryReport{Scope: name, Paths: []pathDiscoveryEntry{}}
|
||||
var prefix []string
|
||||
@@ -157,16 +157,16 @@ func runConfigExplanation[I, S any](invocation commandkit.Invocation, plan *conf
|
||||
}
|
||||
if acquired.Value.Explanation == nil {
|
||||
cause := fmt.Errorf("configuration scope %q did not provide an explanation reader", name)
|
||||
return configFailure("Configuration scope did not provide explanation data.", acquired.Explanation, cause)
|
||||
return configFailure(invocation.Context, "Configuration scope did not provide explanation data.", acquired.Explanation, cause)
|
||||
}
|
||||
|
||||
explanation, found := acquired.Value.Explanation.Explain(plan.path)
|
||||
if !found {
|
||||
cause := fmt.Errorf("configuration path %q is not known in scope %q", plan.path.String(), name)
|
||||
return configFailure("The requested configuration path is not available.", acquired.Explanation, cause)
|
||||
return configFailure(invocation.Context, "The requested configuration path is not available.", acquired.Explanation, cause)
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration explanation was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration explanation was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
report := makeExplanationReport(name, explanation)
|
||||
if acquired.Value.Metadata != nil {
|
||||
@@ -192,7 +192,7 @@ func runConfigExplanation[I, S any](invocation commandkit.Invocation, plan *conf
|
||||
}
|
||||
renderErr := reporter.Report(commandkit.Report{Value: report, TextTemplate: explanationTemplate})
|
||||
if renderErr != nil && invocation.Context.Err() != nil {
|
||||
return configFailure("Configuration explanation was canceled.", acquired.Explanation, invocation.Context.Err())
|
||||
return configFailure(invocation.Context, "Configuration explanation was canceled.", acquired.Explanation, invocation.Context.Err())
|
||||
}
|
||||
return commandkit.Success()
|
||||
}
|
||||
|
||||
@@ -1,6 +1,8 @@
|
||||
package ckconfig
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
|
||||
@@ -15,7 +17,7 @@ func runConfigOperation[I, S any](invocation commandkit.Invocation, operation Op
|
||||
return invocation.Help()
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration operation was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration operation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
plan := input.plan
|
||||
var state S
|
||||
@@ -64,11 +66,23 @@ func queueConfigAcquisition(reporter *commandkit.Reporter, acquired commandkit.A
|
||||
}
|
||||
}
|
||||
|
||||
func configFailure(message string, explanation commandkit.Explanation, cause error) commandkit.Outcome {
|
||||
func configFailure(ctx context.Context, message string, explanation commandkit.Explanation, cause error) commandkit.Outcome {
|
||||
if explanation.Message != "" || len(explanation.Details) > 0 {
|
||||
message = explanation.Message
|
||||
}
|
||||
if ctx != nil {
|
||||
if canceled := ctx.Err(); canceled != nil {
|
||||
if cause == nil {
|
||||
cause = canceled
|
||||
} else if !errors.Is(cause, canceled) {
|
||||
cause = errors.Join(cause, canceled)
|
||||
}
|
||||
}
|
||||
}
|
||||
outcome := commandkit.Failure(message, explanation.Details...)
|
||||
if cause != nil && ClassifyConfigurationError(cause) == commandkit.OutcomeUsage {
|
||||
outcome = commandkit.Usage(message, explanation.Details...)
|
||||
}
|
||||
if cause != nil {
|
||||
outcome = outcome.WithCause(cause)
|
||||
}
|
||||
@@ -76,6 +90,7 @@ func configFailure(message string, explanation commandkit.Explanation, cause err
|
||||
}
|
||||
|
||||
func configAcquisitionFailure(
|
||||
ctx context.Context,
|
||||
reporter *commandkit.Reporter,
|
||||
operation, scope string,
|
||||
acquired commandkit.Acquired[View],
|
||||
@@ -83,7 +98,7 @@ func configAcquisitionFailure(
|
||||
) commandkit.Outcome {
|
||||
queueConfigAcquisition(reporter, acquired)
|
||||
message := fmt.Sprintf("Unable to %s configuration scope %q.", operation, scope)
|
||||
return configFailure(message, acquired.Explanation, cause)
|
||||
return configFailure(ctx, message, acquired.Explanation, cause)
|
||||
}
|
||||
|
||||
// Preserve the preparation/delivery cancellation checkpoint for buffered reports.
|
||||
@@ -105,7 +120,7 @@ func renderPreparedConfigReport(invocation commandkit.Invocation, explanation co
|
||||
canceled = invocation.Context.Err()
|
||||
}
|
||||
if canceled != nil {
|
||||
return configFailure("Configuration report preparation was canceled.", explanation, canceled)
|
||||
return configFailure(invocation.Context, "Configuration report preparation was canceled.", explanation, canceled)
|
||||
}
|
||||
if renderErr == nil {
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: value})
|
||||
|
||||
@@ -88,7 +88,7 @@ func TestOverrideNativeLoadErrorAndProvenance(t *testing.T) {
|
||||
}
|
||||
result = app.Execute(context.Background(), []string{"config", "validate", "--set==1"}, commandkit.Streams{Out: io.Discard, Err: io.Discard})
|
||||
var loadErr *configkit.LoadError
|
||||
if result.Kind != commandkit.OutcomeOperational || !errors.As(result.Cause, &loadErr) {
|
||||
if result.Kind != commandkit.OutcomeUsage || !errors.As(result.Cause, &loadErr) {
|
||||
t.Fatalf("native invalid root override: %#v", result)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -19,29 +19,29 @@ func runConfigShow[I, S any](invocation commandkit.Invocation, plan *configOpera
|
||||
reporter := invocation.Reporter()
|
||||
for _, selected := range plan.scopes {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
if selected.scope.scope.Acquire == nil {
|
||||
return commandkit.Failure(fmt.Sprintf("Configuration scope %q has no acquisition callback.", selected.scope.scope.Name))
|
||||
}
|
||||
acquired, acquireErr := selected.scope.scope.Acquire(invocation.Context, Request{Operation: Show, Selection: selected.selection}, selected.input, state)
|
||||
if acquireErr != nil {
|
||||
return configAcquisitionFailure(reporter, "show", selected.scope.scope.Name, acquired, acquireErr)
|
||||
return configAcquisitionFailure(invocation.Context, reporter, "show", selected.scope.scope.Name, acquired, acquireErr)
|
||||
}
|
||||
queueConfigAcquisition(reporter, acquired)
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration show was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
if plan.pathSet {
|
||||
if acquired.Value.Explanation == nil {
|
||||
return configFailure("Configuration scope did not provide explanation data.", acquired.Explanation, fmt.Errorf("configuration scope %q declared path show without an explanation reader", selected.scope.scope.Name))
|
||||
return configFailure(invocation.Context, "Configuration scope did not provide explanation data.", acquired.Explanation, fmt.Errorf("configuration scope %q declared path show without an explanation reader", selected.scope.scope.Name))
|
||||
}
|
||||
explanation, found := acquired.Value.Explanation.Explain(plan.path)
|
||||
if !found || !explanation.Effective.Present {
|
||||
return configFailure("The requested effective configuration path is not available.", acquired.Explanation, fmt.Errorf("configuration path %q is not effective in scope %q", plan.path.String(), selected.scope.scope.Name))
|
||||
return configFailure(invocation.Context, "The requested effective configuration path is not available.", acquired.Explanation, fmt.Errorf("configuration path %q is not effective in scope %q", plan.path.String(), selected.scope.scope.Name))
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration show was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
var value any
|
||||
err := reporter.RenderOutput(func(io.Writer) error {
|
||||
@@ -51,7 +51,7 @@ func runConfigShow[I, S any](invocation commandkit.Invocation, plan *configOpera
|
||||
})
|
||||
if err == nil {
|
||||
if canceled := invocation.Context.Err(); canceled != nil {
|
||||
return configFailure("Configuration show was canceled.", acquired.Explanation, canceled)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", acquired.Explanation, canceled)
|
||||
}
|
||||
_ = reporter.Report(commandkit.Report{Value: value})
|
||||
}
|
||||
@@ -63,7 +63,7 @@ func runConfigShow[I, S any](invocation commandkit.Invocation, plan *configOpera
|
||||
documents = append(documents, effectiveDocument{name: selected.scope.scope.Name, view: acquired.Value})
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var value any
|
||||
var canceled error
|
||||
@@ -92,16 +92,16 @@ func runConfigShow[I, S any](invocation commandkit.Invocation, plan *configOpera
|
||||
return nil
|
||||
})
|
||||
if canceled != nil {
|
||||
return configFailure("Configuration show was canceled.", commandkit.Explanation{}, canceled)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", commandkit.Explanation{}, canceled)
|
||||
}
|
||||
if err != nil {
|
||||
if canceled := invocation.Context.Err(); canceled != nil {
|
||||
return configFailure("Configuration show was canceled.", commandkit.Explanation{}, canceled)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", commandkit.Explanation{}, canceled)
|
||||
}
|
||||
return commandkit.Success()
|
||||
}
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration show was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
_ = reporter.Report(commandkit.Report{Value: value})
|
||||
return commandkit.Success()
|
||||
|
||||
@@ -59,11 +59,11 @@ func runConfigSources[I, S any](invocation commandkit.Invocation, plan *configOp
|
||||
name := selected.scope.scope.Name
|
||||
reporter := invocation.Reporter()
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return configFailure("Configuration source listing was canceled.", commandkit.Explanation{}, err)
|
||||
return configFailure(invocation.Context, "Configuration source listing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
if selected.scope.scope.Acquire == nil {
|
||||
cause := fmt.Errorf("configuration scope %q has no acquisition callback", name)
|
||||
return configFailure(fmt.Sprintf("Unable to list sources for configuration scope %q.", name), commandkit.Explanation{}, cause)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to list sources for configuration scope %q.", name), commandkit.Explanation{}, cause)
|
||||
}
|
||||
acquired, acquireErr := selected.scope.scope.Acquire(invocation.Context, Request{
|
||||
Operation: Sources,
|
||||
@@ -72,15 +72,15 @@ func runConfigSources[I, S any](invocation commandkit.Invocation, plan *configOp
|
||||
queueConfigAcquisition(reporter, acquired)
|
||||
if acquireErr == nil && invocation.Context.Err() != nil {
|
||||
err := invocation.Context.Err()
|
||||
return configFailure("Configuration source listing was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration source listing was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
if acquired.Value.Sources == nil {
|
||||
if acquireErr != nil {
|
||||
explanation := sourceSelectionExplanation(acquired.Explanation, "Source inventory is unavailable.")
|
||||
return configFailure(fmt.Sprintf("Unable to list sources for configuration scope %q.", name), explanation, acquireErr)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to list sources for configuration scope %q.", name), explanation, acquireErr)
|
||||
}
|
||||
cause := fmt.Errorf("configuration scope %q did not provide a source reader", name)
|
||||
return configFailure("Configuration scope did not provide source information.", acquired.Explanation, cause)
|
||||
return configFailure(invocation.Context, "Configuration scope did not provide source information.", acquired.Explanation, cause)
|
||||
}
|
||||
|
||||
sources := acquired.Value.Sources.Sources()
|
||||
@@ -134,17 +134,17 @@ func runConfigSources[I, S any](invocation commandkit.Invocation, plan *configOp
|
||||
if plan.sourceID.Set && len(document.Sources) == 0 {
|
||||
message := fmt.Sprintf("Source ID %q was not found in configuration scope %q.", plan.sourceID.Value, name)
|
||||
if acquireErr != nil {
|
||||
return configFailure(fmt.Sprintf("Unable to list sources for configuration scope %q.", name), sourceSelectionExplanation(acquired.Explanation, message), acquireErr)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to list sources for configuration scope %q.", name), sourceSelectionExplanation(acquired.Explanation, message), acquireErr)
|
||||
}
|
||||
return configFailure(message, acquired.Explanation, fmt.Errorf("source ID %q was not found", plan.sourceID.Value))
|
||||
return configFailure(invocation.Context, message, acquired.Explanation, fmt.Errorf("source ID %q was not found", plan.sourceID.Value))
|
||||
}
|
||||
if acquireErr == nil && invocation.Context.Err() != nil {
|
||||
err := invocation.Context.Err()
|
||||
return configFailure("Configuration source listing was canceled.", acquired.Explanation, err)
|
||||
return configFailure(invocation.Context, "Configuration source listing was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
_ = reporter.Report(commandkit.Report{Value: document, TextTemplate: sourceTextTemplate})
|
||||
if acquireErr != nil {
|
||||
return configFailure(fmt.Sprintf("Unable to list sources for configuration scope %q.", name), acquired.Explanation, acquireErr)
|
||||
return configFailure(invocation.Context, fmt.Sprintf("Unable to list sources for configuration scope %q.", name), acquired.Explanation, acquireErr)
|
||||
}
|
||||
return commandkit.Success()
|
||||
}
|
||||
|
||||
@@ -71,7 +71,7 @@ func runConfigValidation[I, S any](invocation commandkit.Invocation, plan *confi
|
||||
}
|
||||
for _, selected := range plan.scopes {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
outcome = configFailure("Configuration validation was canceled.", commandkit.Explanation{}, err)
|
||||
outcome = configFailure(invocation.Context, "Configuration validation was canceled.", commandkit.Explanation{}, err)
|
||||
break
|
||||
}
|
||||
name := selected.scope.scope.Name
|
||||
@@ -109,7 +109,7 @@ func runConfigValidation[I, S any](invocation commandkit.Invocation, plan *confi
|
||||
if entry.Outcome == "canceled" {
|
||||
message = "Configuration validation was canceled."
|
||||
}
|
||||
outcome = configFailure(message, acquired.Explanation, err)
|
||||
outcome = configFailure(invocation.Context, message, acquired.Explanation, err)
|
||||
break
|
||||
}
|
||||
}
|
||||
|
||||
@@ -196,7 +196,8 @@ func WithRequestValidation[I, S any](
|
||||
if build != nil {
|
||||
built, err := build(ctx, request, input, state)
|
||||
if err != nil {
|
||||
return commandkit.Acquired[struct{}]{}, err
|
||||
messages := promptKitLoadErrorDiagnostics(err, "")
|
||||
return commandkit.Acquired[struct{}]{Diagnostics: messages.diagnostics, Explanation: messages.explanation}, err
|
||||
}
|
||||
concreteRequest = built
|
||||
}
|
||||
@@ -476,12 +477,7 @@ func loadPromptKitEngine[I, S any](
|
||||
) (*promptkit.Engine, *promptkit.ConfigurationInspection, promptKitAcquisition, error) {
|
||||
engine, err := load(ctx, selection, input, state)
|
||||
if err != nil {
|
||||
var loadErr *configkit.LoadError
|
||||
if errors.As(err, &loadErr) {
|
||||
messages := promptKitDiagnostics("promptkit", side, loadErr.Sources(), loadErr.Diagnostics())
|
||||
return nil, nil, messages, err
|
||||
}
|
||||
return nil, nil, promptKitAcquisition{}, err
|
||||
return nil, nil, promptKitLoadErrorDiagnostics(err, side), err
|
||||
}
|
||||
if engine == nil {
|
||||
return nil, nil, promptKitAcquisition{}, errors.New("PromptKit configuration loader returned a nil engine")
|
||||
@@ -509,6 +505,14 @@ func appendPromptKitAcquisition(left, right promptKitAcquisition) promptKitAcqui
|
||||
return left
|
||||
}
|
||||
|
||||
func promptKitLoadErrorDiagnostics(err error, side string) promptKitAcquisition {
|
||||
var loadErr *configkit.LoadError
|
||||
if errors.As(err, &loadErr) && loadErr != nil {
|
||||
return promptKitDiagnostics("promptkit", side, loadErr.Sources(), loadErr.Diagnostics())
|
||||
}
|
||||
return promptKitAcquisition{}
|
||||
}
|
||||
|
||||
func promptKitDiagnostics(scope, side string, sources []configkit.SourceInfo, records []configkit.Diagnostic) promptKitAcquisition {
|
||||
heading := "Configuration scope " + strconv.Quote(scope)
|
||||
if side != "" {
|
||||
|
||||
@@ -202,7 +202,7 @@ func newCatalogListCommand[I, S any](suite Suite[I, S], name string) commandkit.
|
||||
}
|
||||
return runCatalogList(invocation, suite, input, name, list, collectionCatalogReport)
|
||||
default:
|
||||
return definitionFailure("Unable to list the selected PromptKit catalog.", commandkit.Explanation{}, fmt.Errorf("unknown PromptKit catalog %q", name))
|
||||
return definitionFailure(invocation.Context, "Unable to list the selected PromptKit catalog.", commandkit.Explanation{}, fmt.Errorf("unknown PromptKit catalog %q", name))
|
||||
}
|
||||
},
|
||||
})
|
||||
@@ -368,7 +368,7 @@ func runCatalogList[T any, I, S any](
|
||||
) commandkit.Outcome {
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure("PromptKit catalog listing was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit catalog listing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
}
|
||||
var state S
|
||||
@@ -377,18 +377,18 @@ func runCatalogList[T any, I, S any](
|
||||
}
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure("PromptKit catalog listing was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit catalog listing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
}
|
||||
|
||||
acquired, err := list(invocation.Context, CatalogRequest{Selection: input.selection, Filter: input.filter}, input.selected, state)
|
||||
queuePromptDiagnostics(invocation.Reporter(), acquired.Diagnostics)
|
||||
if err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Unable to list PromptKit %s.", catalog), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Unable to list PromptKit %s.", catalog), acquired.Explanation, err)
|
||||
}
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure("PromptKit catalog listing was canceled.", acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit catalog listing was canceled.", acquired.Explanation, err)
|
||||
}
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: project(acquired.Value)})
|
||||
@@ -397,14 +397,14 @@ func runCatalogList[T any, I, S any](
|
||||
|
||||
func runDefinitionInspection[I, S any](invocation commandkit.Invocation, suite Suite[I, S], input *definitionInput[I], kind string) commandkit.Outcome {
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit inspection was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit inspection was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var state S
|
||||
if suite.NewState != nil {
|
||||
state = suite.NewState()
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit inspection was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit inspection was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var value any
|
||||
var diagnostics []commandkit.Diagnostic
|
||||
@@ -435,13 +435,13 @@ func runDefinitionInspection[I, S any](invocation commandkit.Invocation, suite S
|
||||
}
|
||||
queuePromptDiagnostics(invocation.Reporter(), diagnostics)
|
||||
if err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Unable to inspect PromptKit %s %q.", kind, input.id), explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Unable to inspect PromptKit %s %q.", kind, input.id), explanation, err)
|
||||
}
|
||||
if value == nil {
|
||||
return definitionFailure(fmt.Sprintf("PromptKit %s inspection returned no result.", kind), explanation, nil)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("PromptKit %s inspection returned no result.", kind), explanation, nil)
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Inspection of PromptKit %s %q was canceled.", kind, input.id), explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Inspection of PromptKit %s %q was canceled.", kind, input.id), explanation, err)
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: value})
|
||||
return commandkit.Success()
|
||||
@@ -520,7 +520,7 @@ func requirementsReportFromInspection(inspection *promptkit.RequirementInspectio
|
||||
func runRequirementsInspection[I, S any](invocation commandkit.Invocation, suite Suite[I, S], input *requirementsInput[I]) commandkit.Outcome {
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure("PromptKit requirements inspection was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit requirements inspection was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
}
|
||||
var state S
|
||||
@@ -529,7 +529,7 @@ func runRequirementsInspection[I, S any](invocation commandkit.Invocation, suite
|
||||
}
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure("PromptKit requirements inspection was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit requirements inspection was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -537,14 +537,14 @@ func runRequirementsInspection[I, S any](invocation commandkit.Invocation, suite
|
||||
acquired, err := suite.InspectRequirements(invocation.Context, request, input.selected, state)
|
||||
queuePromptDiagnostics(invocation.Reporter(), acquired.Diagnostics)
|
||||
if err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Unable to inspect requirements for PromptKit prompt %q.", input.inspection.PromptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Unable to inspect requirements for PromptKit prompt %q.", input.inspection.PromptID), acquired.Explanation, err)
|
||||
}
|
||||
if acquired.Value == nil {
|
||||
return definitionFailure("PromptKit requirements inspection returned no result.", acquired.Explanation, nil)
|
||||
return definitionFailure(invocation.Context, "PromptKit requirements inspection returned no result.", acquired.Explanation, nil)
|
||||
}
|
||||
if invocation.Context != nil {
|
||||
if err := invocation.Context.Err(); err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Requirements inspection for PromptKit prompt %q was canceled.", input.inspection.PromptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Requirements inspection for PromptKit prompt %q was canceled.", input.inspection.PromptID), acquired.Explanation, err)
|
||||
}
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: requirementsReportFromInspection(acquired.Value)})
|
||||
@@ -602,8 +602,20 @@ func queuePromptDiagnostics(reporter *commandkit.Reporter, diagnostics []command
|
||||
}
|
||||
}
|
||||
|
||||
func definitionFailure(message string, explanation commandkit.Explanation, cause error) commandkit.Outcome {
|
||||
func definitionFailure(ctx context.Context, message string, explanation commandkit.Explanation, cause error) commandkit.Outcome {
|
||||
if ctx != nil {
|
||||
if canceled := ctx.Err(); canceled != nil {
|
||||
if cause == nil {
|
||||
cause = canceled
|
||||
} else if !errors.Is(cause, canceled) {
|
||||
cause = errors.Join(cause, canceled)
|
||||
}
|
||||
}
|
||||
}
|
||||
outcome := commandkit.Failure(message)
|
||||
if cause != nil && ckconfig.ClassifyConfigurationError(cause) == commandkit.OutcomeUsage {
|
||||
outcome = commandkit.Usage(message)
|
||||
}
|
||||
if explanation.Message != "" || len(explanation.Details) > 0 {
|
||||
outcome = outcome.WithExplanation(explanation.Message, explanation.Details...)
|
||||
}
|
||||
|
||||
@@ -154,7 +154,7 @@ func TestPublicConfigDiffUsesPromptKitPairAndPreparedInputs(t *testing.T) {
|
||||
|
||||
var diagnostics bytes.Buffer
|
||||
failure := app.Execute(context.Background(), []string{"config", "diff", "--scope", "promptkit", "--config", "bad-left.yml", "--against-config", "right.yml", "--campaign", "spring", "--against-campaign", "spring"}, commandkit.Streams{Out: io.Discard, Err: &diagnostics})
|
||||
if failure.Kind != commandkit.OutcomeOperational || !strings.Contains(diagnostics.String(), `Configuration scope "promptkit" (left):`) {
|
||||
if failure.Kind != commandkit.OutcomeUsage || !strings.Contains(diagnostics.String(), `Configuration scope "promptkit" (left):`) {
|
||||
t.Fatalf("installed load failure = %#v, diagnostics %q", failure, diagnostics.String())
|
||||
}
|
||||
var loadFailure *configkit.LoadError
|
||||
|
||||
100
integrations/ckprompt/configuration_composition_outcomes_test.go
Normal file
100
integrations/ckprompt/configuration_composition_outcomes_test.go
Normal file
@@ -0,0 +1,100 @@
|
||||
package ckprompt
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"go.maximumdirect.net/ckconfig"
|
||||
"go.maximumdirect.net/commandkit"
|
||||
"go.maximumdirect.net/configkit"
|
||||
"go.maximumdirect.net/promptkit"
|
||||
)
|
||||
|
||||
func TestComposedConfigurationInputOutcomes(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("prompt-invalid", []byte("broken: [")))
|
||||
engine := adapterEngine(t)
|
||||
calls := 0
|
||||
scope := ConfigScope(func(_ context.Context, selection ckconfig.Selection, _, _ struct{}) (*promptkit.Engine, error) {
|
||||
calls++
|
||||
if selection.Config.Value == "good" {
|
||||
return engine, nil
|
||||
}
|
||||
return nil, fmt.Errorf("wrapped: %w", loadErr)
|
||||
})
|
||||
app := newPromptTestApp(t, ckconfig.Command(ckconfig.Suite[struct{}, struct{}]{Scopes: []ckconfig.Scope[struct{}, struct{}]{scope}}))
|
||||
cases := []struct {
|
||||
args []string
|
||||
report string
|
||||
side string
|
||||
}{
|
||||
{[]string{"config", "show"}, "", ""},
|
||||
{[]string{"config", "sources", "--format=json"}, `"sources"`, ""},
|
||||
{[]string{"config", "validate", "--details", "--format=json"}, `"code": "yaml.invalid"`, ""},
|
||||
{[]string{"config", "explain", "--list"}, "", ""},
|
||||
{[]string{"config", "diff"}, "", "left"},
|
||||
{[]string{"config", "diff", "--config=good", "--against-config=bad"}, "", "right"},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(strings.Join(tc.args, "_"), func(t *testing.T) {
|
||||
var out, diag bytes.Buffer
|
||||
args := append(append([]string{}, tc.args...), "--scope=promptkit")
|
||||
result := app.Execute(context.Background(), args, commandkit.Streams{Out: &out, Err: &diag})
|
||||
var native *configkit.LoadError
|
||||
if result.Status != 2 || !errors.Is(result.Cause, loadErr) || !errors.As(result.Cause, &native) || !strings.Contains(diag.String(), "prompt-invalid") || (tc.report != "" && !strings.Contains(out.String(), tc.report)) || (tc.side != "" && !strings.Contains(diag.String(), "("+tc.side+")")) {
|
||||
t.Fatalf("result=%#v output=%q diagnostics=%q", result, out.String(), diag.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
for _, tc := range cases {
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
before := calls
|
||||
var out bytes.Buffer
|
||||
args := append(append([]string{}, tc.args...), "--scope=promptkit")
|
||||
result := app.Execute(ctx, args, commandkit.Streams{Out: &out, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, context.Canceled) || calls != before || out.Len() != 0 {
|
||||
t.Fatalf("canceled %v: %#v output=%q", tc.args, result, out.String())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestSmokeConfigurationFailureOutcomes(t *testing.T) {
|
||||
_, first := configkit.Load[map[string]any](configkit.Bytes("first", []byte("broken: [")))
|
||||
_, second := configkit.Load[map[string]any](configkit.Bytes("second", []byte("other: [")))
|
||||
operational := errors.New("provider failure")
|
||||
for _, tc := range []struct {
|
||||
name, command string
|
||||
failures []error
|
||||
cancel bool
|
||||
want int
|
||||
}{
|
||||
{"single", "reachability", []error{first}, false, 2},
|
||||
{"all input", "all", []error{first, second, first, second}, false, 2},
|
||||
{"mixed", "all", []error{first, operational, second, first}, false, 1},
|
||||
{"cancellation", "all", []error{first}, true, 1},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
defer cancel()
|
||||
calls := 0
|
||||
app := newPromptTestApp(t, Command(Suite[struct{}, struct{}]{SmokeTest: func(_ context.Context, req SmokeRequest, _, _ struct{}) (commandkit.Acquired[*promptkit.SmokeTestReport], error) {
|
||||
err := tc.failures[calls]
|
||||
calls++
|
||||
if tc.cancel {
|
||||
cancel()
|
||||
}
|
||||
return commandkit.Acquired[*promptkit.SmokeTestReport]{Value: &promptkit.SmokeTestReport{Kind: req.Request.Kind}, Explanation: commandkit.Explanation{Message: fmt.Sprintf("context-%d", calls)}}, err
|
||||
}}))
|
||||
var out, diag bytes.Buffer
|
||||
result := app.Execute(ctx, []string{"promptkit", "test", tc.command, "--format=json"}, commandkit.Streams{Out: &out, Err: &diag})
|
||||
if result.Status != tc.want || calls != len(tc.failures) || !errors.Is(result.Cause, first) || (tc.name == "all input" && !errors.Is(result.Cause, second)) || (tc.name == "mixed" && (!errors.Is(result.Cause, second) || !errors.Is(result.Cause, operational))) || (tc.cancel && !errors.Is(result.Cause, context.Canceled)) || out.Len() == 0 || !strings.Contains(diag.String(), "context-1") {
|
||||
t.Fatalf("outcome=%#v calls=%d report=%q diagnostics=%q", result, calls, out.String(), diag.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
209
integrations/ckprompt/configuration_outcomes_test.go
Normal file
209
integrations/ckprompt/configuration_outcomes_test.go
Normal file
@@ -0,0 +1,209 @@
|
||||
package ckprompt
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"go.maximumdirect.net/ckconfig"
|
||||
"go.maximumdirect.net/commandkit"
|
||||
"go.maximumdirect.net/configkit"
|
||||
"go.maximumdirect.net/promptkit"
|
||||
)
|
||||
|
||||
func TestPromptConfigurationFailureCallbacks(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("prompt-config", []byte("broken: [")))
|
||||
var native *configkit.LoadError
|
||||
if !errors.As(loadErr, &native) {
|
||||
t.Fatalf("fixture: %v", loadErr)
|
||||
}
|
||||
wrapped := fmt.Errorf("load: %w", loadErr)
|
||||
diag := commandkit.Explanation{Message: "configuration diagnostic"}
|
||||
suite := Suite[struct{}, struct{}]{
|
||||
ListPrompts: func(context.Context, CatalogRequest, struct{}, struct{}) (commandkit.Acquired[[]promptkit.PromptIdentity], error) {
|
||||
return commandkit.Acquired[[]promptkit.PromptIdentity]{Explanation: diag}, wrapped
|
||||
},
|
||||
ListProfiles: func(context.Context, CatalogRequest, struct{}, struct{}) (commandkit.Acquired[[]string], error) {
|
||||
return commandkit.Acquired[[]string]{Explanation: diag}, wrapped
|
||||
},
|
||||
ListBackends: func(context.Context, CatalogRequest, struct{}, struct{}) (commandkit.Acquired[[]string], error) {
|
||||
return commandkit.Acquired[[]string]{Explanation: diag}, wrapped
|
||||
},
|
||||
ListNamespaces: func(context.Context, NamespaceRequest, struct{}, struct{}) (commandkit.Acquired[[]string], error) {
|
||||
return commandkit.Acquired[[]string]{Explanation: diag}, wrapped
|
||||
},
|
||||
ListCollections: func(context.Context, ckconfig.Selection, struct{}, struct{}) (commandkit.Acquired[[]promptkit.CollectionInfo], error) {
|
||||
return commandkit.Acquired[[]promptkit.CollectionInfo]{Explanation: diag}, wrapped
|
||||
},
|
||||
InspectPrompt: func(context.Context, PromptRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.PromptInspection], error) {
|
||||
return commandkit.Acquired[*promptkit.PromptInspection]{Explanation: diag}, wrapped
|
||||
},
|
||||
InspectProfile: func(context.Context, ProfileRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.ProfileInspection], error) {
|
||||
return commandkit.Acquired[*promptkit.ProfileInspection]{Explanation: diag}, wrapped
|
||||
},
|
||||
InspectBackend: func(context.Context, BackendRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.BackendInspection], error) {
|
||||
return commandkit.Acquired[*promptkit.BackendInspection]{Explanation: diag}, wrapped
|
||||
},
|
||||
InspectRequirements: func(context.Context, RequirementsRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.RequirementInspection], error) {
|
||||
return commandkit.Acquired[*promptkit.RequirementInspection]{Explanation: diag}, wrapped
|
||||
},
|
||||
ValidateRequest: func(context.Context, ValidationRequest, struct{}, struct{}) (commandkit.Acquired[struct{}], error) {
|
||||
return commandkit.Acquired[struct{}]{Explanation: diag}, wrapped
|
||||
},
|
||||
PrepareRequest: func(context.Context, PreparationRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.PreparedRun], error) {
|
||||
return commandkit.Acquired[*promptkit.PreparedRun]{Explanation: diag}, wrapped
|
||||
},
|
||||
}
|
||||
app := newPromptTestApp(t, Command(suite))
|
||||
for _, args := range [][]string{{"promptkit", "list", "prompts"}, {"promptkit", "list", "profiles"}, {"promptkit", "list", "backends"}, {"promptkit", "list", "namespaces"}, {"promptkit", "list", "collections"}, {"promptkit", "show", "prompt", "example"}, {"promptkit", "show", "profile", "example"}, {"promptkit", "show", "backend", "example"}, {"promptkit", "requirements", "show", "example"}, {"promptkit", "requirements", "validate", "example"}, {"promptkit", "show", "prepared", "example"}} {
|
||||
t.Run(strings.Join(args, "_"), func(t *testing.T) {
|
||||
var out, diagnostic bytes.Buffer
|
||||
result := app.Execute(context.Background(), args, commandkit.Streams{Out: &out, Err: &diagnostic})
|
||||
var got *configkit.LoadError
|
||||
if result.Kind != commandkit.OutcomeUsage || result.Status != 2 || !errors.Is(result.Cause, loadErr) || !errors.As(result.Cause, &got) || got != native || !strings.Contains(diagnostic.String(), "configuration diagnostic") {
|
||||
t.Fatalf("outcome=%#v diagnostics=%q", result, diagnostic.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPromptNativeConfigurationFailures(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("native-config", []byte("broken: [")))
|
||||
load := func(context.Context, ckconfig.Selection, struct{}, struct{}) (*promptkit.Engine, error) {
|
||||
return nil, fmt.Errorf("wrapped: %w", loadErr)
|
||||
}
|
||||
suite := FromEngine[struct{}, struct{}](load)
|
||||
suite = WithRequestValidation(suite, load, nil)
|
||||
suite = WithRequestPreparation(suite, load, nil)
|
||||
app := newPromptTestApp(t, Command(suite))
|
||||
for _, args := range [][]string{{"promptkit", "list", "prompts"}, {"promptkit", "show", "prompt", "example"}, {"promptkit", "requirements", "show", "example"}, {"promptkit", "requirements", "validate", "example"}, {"promptkit", "show", "prepared", "example"}} {
|
||||
t.Run(strings.Join(args, "_"), func(t *testing.T) {
|
||||
var diag bytes.Buffer
|
||||
result := app.Execute(context.Background(), args, commandkit.Streams{Out: io.Discard, Err: &diag})
|
||||
var native *configkit.LoadError
|
||||
if result.Status != 2 || !errors.Is(result.Cause, loadErr) || !errors.As(result.Cause, &native) || !strings.Contains(diag.String(), "native-config") {
|
||||
t.Fatalf("outcome=%#v diagnostics=%q", result, diag.String())
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
func TestBuilderConfigurationFailureDiagnostics(t *testing.T) {
|
||||
_, malformed := configkit.Load[map[string]any](configkit.Bytes("builder-config", []byte("broken: [")))
|
||||
path := configkit.Keys("version")
|
||||
_, rejected := configkit.Load(configkit.Bytes("builder-config", []byte("version: 1\n")), configkit.Options[map[string]any]{
|
||||
Definition: configkit.Definition[map[string]any]{Version: &configkit.VersionRule{
|
||||
Path: path,
|
||||
Check: func(_ configkit.Version, validation *configkit.Validation) error {
|
||||
validation.Warning(path, "builder warning")
|
||||
validation.Error(path, "builder rejection")
|
||||
return nil
|
||||
},
|
||||
}},
|
||||
})
|
||||
for _, fixture := range []struct {
|
||||
name string
|
||||
cause error
|
||||
code string
|
||||
warning string
|
||||
status int
|
||||
}{
|
||||
{"malformed", malformed, "yaml.invalid", "", 2},
|
||||
{"rejected", rejected, "version.error", "builder warning", 2},
|
||||
{"application failure", errors.New("builder unavailable"), "", "", 1},
|
||||
} {
|
||||
if fixture.cause == nil {
|
||||
t.Fatalf("%s fixture succeeded", fixture.name)
|
||||
}
|
||||
for _, args := range [][]string{
|
||||
{"promptkit", "requirements", "validate", "example"},
|
||||
{"promptkit", "show", "prepared", "example"},
|
||||
{"promptkit", "test", "reachability"},
|
||||
{"promptkit", "test", "all"},
|
||||
} {
|
||||
for _, canceled := range []bool{false, true} {
|
||||
name := fmt.Sprintf("%s/%s/canceled=%t", fixture.name, strings.Join(args, "_"), canceled)
|
||||
t.Run(name, func(t *testing.T) {
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
defer cancel()
|
||||
loaderCalls, builderCalls := 0, 0
|
||||
load := func(context.Context, ckconfig.Selection, struct{}, struct{}) (*promptkit.Engine, error) {
|
||||
loaderCalls++
|
||||
return nil, errors.New("unexpected engine load")
|
||||
}
|
||||
wrapped := fmt.Errorf("builder load: %w", fixture.cause)
|
||||
buildError := func() error {
|
||||
builderCalls++
|
||||
if canceled {
|
||||
cancel()
|
||||
}
|
||||
return wrapped
|
||||
}
|
||||
suite := WithRequestValidation(Suite[struct{}, struct{}]{}, load, func(context.Context, ValidationRequest, struct{}, struct{}) (promptkit.RunRequest, error) {
|
||||
return promptkit.RunRequest{}, buildError()
|
||||
})
|
||||
suite = WithRequestPreparation(suite, load, func(context.Context, PreparationRequest, struct{}, struct{}) (promptkit.RunRequest, error) {
|
||||
return promptkit.RunRequest{}, buildError()
|
||||
})
|
||||
suite = WithSmokeTesting(suite, load, func(context.Context, SmokeRequest, struct{}, struct{}) (promptkit.SmokeTestRequest, error) {
|
||||
return promptkit.SmokeTestRequest{}, buildError()
|
||||
})
|
||||
app := newPromptTestApp(t, Command(suite))
|
||||
var out, diagnostic bytes.Buffer
|
||||
result := app.Execute(ctx, append(append([]string{}, args...), "--verbose"), commandkit.Streams{Out: &out, Err: &diagnostic})
|
||||
wantStatus, wantCalls := fixture.status, 1
|
||||
if args[len(args)-1] == "all" && !canceled {
|
||||
wantCalls = 4
|
||||
}
|
||||
if canceled {
|
||||
wantStatus = 1
|
||||
if !errors.Is(result.Cause, context.Canceled) {
|
||||
t.Fatalf("lost cancellation: %#v", result)
|
||||
}
|
||||
}
|
||||
if result.Status != wantStatus || !errors.Is(result.Cause, wrapped) || loaderCalls != 0 || builderCalls != wantCalls {
|
||||
t.Fatalf("result=%#v loader calls=%d builder calls=%d", result, loaderCalls, builderCalls)
|
||||
}
|
||||
if fixture.code != "" {
|
||||
var expected, retained *configkit.LoadError
|
||||
if !errors.As(fixture.cause, &expected) || !errors.As(result.Cause, &retained) || retained != expected {
|
||||
t.Fatalf("lost loading error: %#v", result)
|
||||
}
|
||||
if !strings.Contains(diagnostic.String(), fixture.code) || !strings.Contains(diagnostic.String(), "builder-config") || !strings.Contains(diagnostic.String(), fixture.warning) {
|
||||
t.Fatalf("diagnostics: %q", diagnostic.String())
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestPromptConfigurationFailureCancellation(t *testing.T) {
|
||||
_, loadErr := configkit.Load[map[string]any](configkit.Bytes("invalid", []byte("broken: [")))
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
calls := 0
|
||||
suite := Suite[struct{}, struct{}]{InspectPrompt: func(context.Context, PromptRequest, struct{}, struct{}) (commandkit.Acquired[*promptkit.PromptInspection], error) {
|
||||
calls++
|
||||
cancel()
|
||||
return commandkit.Acquired[*promptkit.PromptInspection]{}, loadErr
|
||||
}}
|
||||
app := newPromptTestApp(t, Command(suite))
|
||||
var out bytes.Buffer
|
||||
result := app.Execute(ctx, []string{"promptkit", "show", "prompt", "example"}, commandkit.Streams{Out: &out, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, context.Canceled) || !errors.Is(result.Cause, loadErr) || out.Len() != 0 || calls != 1 {
|
||||
t.Fatalf("outcome=%#v calls=%d output=%q", result, calls, out.String())
|
||||
}
|
||||
ctx, cancel = context.WithCancel(context.Background())
|
||||
cancel()
|
||||
calls = 0
|
||||
result = app.Execute(ctx, []string{"promptkit", "show", "prompt", "example"}, commandkit.Streams{Out: &out, Err: io.Discard})
|
||||
if result.Status != 1 || !errors.Is(result.Cause, context.Canceled) || calls != 0 || out.Len() != 0 {
|
||||
t.Fatalf("pre-canceled=%#v calls=%d", result, calls)
|
||||
}
|
||||
}
|
||||
25
integrations/ckprompt/docs/releases/v0.8.0.md
Normal file
25
integrations/ckprompt/docs/releases/v0.8.0.md
Normal file
@@ -0,0 +1,25 @@
|
||||
# CommandKit ckprompt v0.8.0
|
||||
|
||||
CommandKit ckprompt v0.8.0 adopts ckconfig v0.8.0's shared configuration-error
|
||||
classification across inspection, catalogs, requirements, request preparation,
|
||||
and smoke testing. ConfigKit loading errors returned by application request
|
||||
builders now provide their source context, warnings, and terminal diagnostics
|
||||
through the same adaptation used for engine-loader failures.
|
||||
|
||||
## Compatibility and upgrade
|
||||
|
||||
Pair `go.maximumdirect.net/ckprompt v0.8.0` with ckconfig v0.8.0 and CommandKit
|
||||
core v0.6.0. The selected upstream versions are ConfigKit v1.2.0 and PromptKit
|
||||
v0.21.0. The consumer minimum is Go 1.27.0.
|
||||
|
||||
Identifiable invalid configuration input now selects status `2`, including
|
||||
configuration errors returned by request builders. These failures previously
|
||||
selected status `1`. Update scripts that interpret those statuses. Operational
|
||||
failures, cancellation, and ambiguous or unknown failure evidence select status
|
||||
`1`. In aggregate smoke testing, operational failures take precedence over input
|
||||
failures. Typed causes and available reports are preserved through the shared
|
||||
reporting lifecycle. See the [CLI contract](../../../../docs/cli.md#configuration-failure-classification).
|
||||
|
||||
[COPYRIGHT](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckprompt/v0.8.0/integrations/ckprompt/COPYRIGHT) |
|
||||
[LICENSE](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckprompt/v0.8.0/integrations/ckprompt/LICENSE) |
|
||||
[ATTRIBUTION](https://forge.maximumdirect.net/base-layer/commandkit/src/tag/integrations/ckprompt/v0.8.0/integrations/ckprompt/docs/oss/attribution.md)
|
||||
@@ -170,7 +170,7 @@ func TestComposedIndependentOverridesAndFailureEvidence(t *testing.T) {
|
||||
}
|
||||
|
||||
outcome = app.Execute(context.Background(), []string{"config", "validate", "--scope", "app", "--campaign", "spring", "--limit=0", "--set", `/default_campaign="autumn"`}, commandkit.Streams{Out: io.Discard, Err: io.Discard})
|
||||
if outcome.Kind != commandkit.OutcomeOperational || outcome.Cause == nil {
|
||||
if outcome.Kind != commandkit.OutcomeUsage || outcome.Cause == nil {
|
||||
t.Fatalf("overlapping native overrides: %#v", outcome)
|
||||
}
|
||||
loads := 0
|
||||
|
||||
@@ -3,7 +3,7 @@ module go.maximumdirect.net/ckprompt
|
||||
go 1.27.0
|
||||
|
||||
require (
|
||||
go.maximumdirect.net/ckconfig v0.6.0
|
||||
go.maximumdirect.net/ckconfig v0.8.0
|
||||
go.maximumdirect.net/commandkit v0.6.0
|
||||
go.maximumdirect.net/configkit v1.2.0
|
||||
go.maximumdirect.net/promptkit v0.21.0
|
||||
|
||||
@@ -16,6 +16,10 @@ go.maximumdirect.net/ckconfig v0.5.0 h1:5YCPFySTFIFR+gzd0FjqkTPEVB7zkGa8kOEYh4aB
|
||||
go.maximumdirect.net/ckconfig v0.5.0/go.mod h1:BONXRSQlHdJvYVw9mN6lMV4G4ldlV/5fRO9EEApA99s=
|
||||
go.maximumdirect.net/ckconfig v0.6.0 h1:N7MJKJiXhv+tT4HA7dnINUxC0Uq8hzYmBTFjrpvkbvQ=
|
||||
go.maximumdirect.net/ckconfig v0.6.0/go.mod h1:69HOkR2Jbq7rJz3jlFAL6Oo5qorEiVrxQVLXoqav98s=
|
||||
go.maximumdirect.net/ckconfig v0.7.0 h1:jRmKqgReLYIRHJl7Pr4+TlucifFirGANcsoC+5WrW7A=
|
||||
go.maximumdirect.net/ckconfig v0.7.0/go.mod h1:ZBKCi0Z72+C6kQV+1HJHXFGcZTc11FYyaH1pQDSZFl8=
|
||||
go.maximumdirect.net/ckconfig v0.8.0 h1:ZhHlj2jGv2qXfbUJH/IwuSok/2hhopJEDqZ2fTJMbNU=
|
||||
go.maximumdirect.net/ckconfig v0.8.0/go.mod h1:ZBKCi0Z72+C6kQV+1HJHXFGcZTc11FYyaH1pQDSZFl8=
|
||||
go.maximumdirect.net/commandkit v0.4.0 h1:bWqflDWDn98FUCgh+0e+w6LGmvWIkaeJK519H7PjD2Y=
|
||||
go.maximumdirect.net/commandkit v0.4.0/go.mod h1:ZS98DewKNVBygKVDoh5MFD09CnPlP37dS9pVsID5Eoc=
|
||||
go.maximumdirect.net/commandkit v0.5.0 h1:Ln+bCp+FwCg4tZD3NaMKQXUDB3mPusgwsnRZmb0+3cM=
|
||||
|
||||
@@ -43,7 +43,8 @@ func WithRequestPreparation[I, S any](
|
||||
if build != nil {
|
||||
built, err := build(ctx, request, input, state)
|
||||
if err != nil {
|
||||
return commandkit.Acquired[*promptkit.PreparedRun]{}, err
|
||||
messages := promptKitLoadErrorDiagnostics(err, "")
|
||||
return commandkit.Acquired[*promptkit.PreparedRun]{Diagnostics: messages.diagnostics, Explanation: messages.explanation}, err
|
||||
}
|
||||
concrete = built
|
||||
}
|
||||
@@ -82,26 +83,26 @@ func newPreparationCommand[I, S any](suite Suite[I, S], aliases *[]commandkit.De
|
||||
|
||||
func runRequestPreparation[I, S any](invocation commandkit.Invocation, suite Suite[I, S], input *concreteRequestInput[I]) commandkit.Outcome {
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit request preparation was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit request preparation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var state S
|
||||
if suite.NewState != nil {
|
||||
state = suite.NewState()
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit request preparation was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit request preparation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
request := PreparationRequest{Selection: input.request.Selection, Request: input.request.Request, Namespaces: input.request.Namespaces}
|
||||
acquired, err := suite.PrepareRequest(invocation.Context, request, input.selected, state)
|
||||
queuePromptDiagnostics(invocation.Reporter(), acquired.Diagnostics)
|
||||
if err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Unable to prepare the PromptKit request for prompt %q.", input.promptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Unable to prepare the PromptKit request for prompt %q.", input.promptID), acquired.Explanation, err)
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Preparation of the PromptKit request for prompt %q was canceled.", input.promptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Preparation of the PromptKit request for prompt %q was canceled.", input.promptID), acquired.Explanation, err)
|
||||
}
|
||||
if acquired.Value == nil {
|
||||
return definitionFailure("PromptKit request preparation returned no result.", acquired.Explanation, nil)
|
||||
return definitionFailure(invocation.Context, "PromptKit request preparation returned no result.", acquired.Explanation, nil)
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: acquired.Value})
|
||||
return commandkit.Success()
|
||||
|
||||
@@ -51,7 +51,8 @@ func WithSmokeTesting[I, S any](
|
||||
if build != nil {
|
||||
built, err := build(ctx, request, input, state)
|
||||
if err != nil {
|
||||
return commandkit.Acquired[*promptkit.SmokeTestReport]{}, err
|
||||
messages := promptKitLoadErrorDiagnostics(err, "")
|
||||
return commandkit.Acquired[*promptkit.SmokeTestReport]{Diagnostics: messages.diagnostics, Explanation: messages.explanation}, err
|
||||
}
|
||||
concreteRequest = built
|
||||
}
|
||||
|
||||
@@ -91,14 +91,14 @@ func newSmokeTestCommand[I, S any](suite Suite[I, S], aliases *[]commandkit.Decl
|
||||
|
||||
func runSmokeTest[I, S any](invocation commandkit.Invocation, suite Suite[I, S], input *smokeCommandInput[I]) commandkit.Outcome {
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var state S
|
||||
if suite.NewState != nil {
|
||||
state = suite.NewState()
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
if input.kind == "all" {
|
||||
return runSmokeAggregate(invocation, suite, input, state)
|
||||
@@ -118,12 +118,12 @@ func runSmokeTest[I, S any](invocation commandkit.Invocation, suite Suite[I, S],
|
||||
}
|
||||
}
|
||||
if acquired.Value == nil {
|
||||
return definitionFailure(smokeFailureMessage(input.kind), acquired.Explanation, operationErr)
|
||||
return definitionFailure(invocation.Context, smokeFailureMessage(input.kind), acquired.Explanation, operationErr)
|
||||
}
|
||||
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: smokeReportFromNative(acquired.Value)})
|
||||
if operationErr != nil {
|
||||
return definitionFailure(smokeFailureMessage(input.kind), acquired.Explanation, operationErr)
|
||||
return definitionFailure(invocation.Context, smokeFailureMessage(input.kind), acquired.Explanation, operationErr)
|
||||
}
|
||||
return commandkit.Success()
|
||||
}
|
||||
@@ -146,7 +146,7 @@ func runSmokeAggregate[I, S any](invocation commandkit.Invocation, suite Suite[I
|
||||
for _, kind := range kinds {
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
if len(results) == 0 {
|
||||
return definitionFailure("PromptKit aggregate smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit aggregate smoke testing was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
operationErrors = append(operationErrors, err)
|
||||
break
|
||||
@@ -182,11 +182,11 @@ func runSmokeAggregate[I, S any](invocation commandkit.Invocation, suite Suite[I
|
||||
}
|
||||
|
||||
if len(results) == 0 {
|
||||
return definitionFailure("PromptKit aggregate smoke testing did not produce any results.", combineSmokeExplanations(explanations), errors.Join(operationErrors...))
|
||||
return definitionFailure(invocation.Context, "PromptKit aggregate smoke testing did not produce any results.", combineSmokeExplanations(explanations), errors.Join(operationErrors...))
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: smokeResultsReport(results)})
|
||||
if len(operationErrors) > 0 {
|
||||
return definitionFailure("One or more PromptKit smoke tests failed.", combineSmokeExplanations(explanations), errors.Join(operationErrors...))
|
||||
return definitionFailure(invocation.Context, "One or more PromptKit smoke tests failed.", combineSmokeExplanations(explanations), errors.Join(operationErrors...))
|
||||
}
|
||||
return commandkit.Success()
|
||||
}
|
||||
|
||||
@@ -102,23 +102,23 @@ func newValidationCommand[I, S any](suite Suite[I, S], aliases *[]commandkit.Dec
|
||||
|
||||
func runRequestValidation[I, S any](invocation commandkit.Invocation, suite Suite[I, S], input *concreteRequestInput[I]) commandkit.Outcome {
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit request validation was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit request validation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
var state S
|
||||
if suite.NewState != nil {
|
||||
state = suite.NewState()
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure("PromptKit request validation was canceled.", commandkit.Explanation{}, err)
|
||||
return definitionFailure(invocation.Context, "PromptKit request validation was canceled.", commandkit.Explanation{}, err)
|
||||
}
|
||||
|
||||
acquired, err := suite.ValidateRequest(invocation.Context, input.request, input.selected, state)
|
||||
queuePromptDiagnostics(invocation.Reporter(), acquired.Diagnostics)
|
||||
if err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Unable to validate the PromptKit request for prompt %q.", input.promptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Unable to validate the PromptKit request for prompt %q.", input.promptID), acquired.Explanation, err)
|
||||
}
|
||||
if err := promptKitContextError(invocation.Context); err != nil {
|
||||
return definitionFailure(fmt.Sprintf("Validation of the PromptKit request for prompt %q was canceled.", input.promptID), acquired.Explanation, err)
|
||||
return definitionFailure(invocation.Context, fmt.Sprintf("Validation of the PromptKit request for prompt %q was canceled.", input.promptID), acquired.Explanation, err)
|
||||
}
|
||||
_ = invocation.Reporter().Report(commandkit.Report{Value: requestValidationReport{PromptID: input.promptID, Valid: true}})
|
||||
return commandkit.Success()
|
||||
|
||||
@@ -409,7 +409,7 @@ func TestValidationCommandRetainsProviderDiagnosticsAndClassifiesFailures(t *tes
|
||||
}, nil)))
|
||||
outcome = loadApp.Execute(context.Background(), []string{"promptkit", "requirements", "validate", "briefing"}, commandkit.Streams{Out: io.Discard, Err: io.Discard})
|
||||
var retained *configkit.LoadError
|
||||
if outcome.Kind != commandkit.OutcomeOperational || outcome.Status != 1 || !errors.Is(outcome.Cause, loadErr) || !errors.As(outcome.Cause, &retained) || retained != loadErr || outcome.Explanation.Message == "" && len(outcome.Explanation.Details) == 0 {
|
||||
if outcome.Kind != commandkit.OutcomeUsage || outcome.Status != 2 || !errors.Is(outcome.Cause, loadErr) || !errors.As(outcome.Cause, &retained) || retained != loadErr || outcome.Explanation.Message == "" && len(outcome.Explanation.Details) == 0 {
|
||||
t.Fatalf("loader failure = %#v, want retained ConfigKit error and diagnostics", outcome)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user