base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Capture PromptKit selectors before retaining callbacks

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-11 13:02:54 +00:00
parent 6d660585d1
commit fba917f5bd
3 changed files with 59 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
docs/roadmap/remediation.md
View File

@@ -3,7 +3,7 @@
Reviewed on 2026-10-11, against committed implementation
`cc574915ee17e2d738f27874d2c8857aa1f51a47`. The implementation sprint starts
after planning commit `0d23676144ab1ce5047924e98f1ab6a2a9d6aeb6`.
All issues below are open. P1 identifies a functional contract violation; P2
Completion status and evidence are recorded per issue below. P1 identifies a functional contract violation; P2
identifies architecture or documentation corrections; P3 identifies smaller
maintenance corrections. These priorities do not add publication gates.
@@ -38,7 +38,14 @@ provider caches, or permanent validation gates to resolve these issues.
## R1: Capture PromptKit selector handles before retaining the suite
**Status:** Open. **Priority:** P1.
**Status:** Completed (2026-10-11). **Priority:** P1.
**Completed work:** the enabled family copies its selector-handle collection
once, preserving original identities for both generated commands and retained
callbacks. Empty-suite behavior is unchanged. The public consumer regression
replaces a source element after capture and exercises prompt/profile inspection
in two apps reusing the declaration. It failed before the fix and passes after
it; the complete ckprompt suite passes offline with Go 1.26.8.
**Evidence:** [ckprompt/command.go](../../integrations/ckprompt/command.go),
`Command`, `newDefinitionCommand`, and `prepareDefinitionInput`.