base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Record shell completion interaction finding

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-03 12:50:29 +00:00
parent d3d40acea0
commit c87bba3d2e
1 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
docs/roadmap/remediation.md
View File

@@ -1,6 +1,6 @@
# Shell completion audit remediation # Shell completion audit remediation
Status: five findings open. The completed invocation reporting audit is retained Status: six findings open. The completed invocation reporting audit is retained
below as historical evidence. below as historical evidence.
## Completion review scope ## Completion review scope
@@ -113,6 +113,36 @@ Document how to initialize the Bash completion package before sourcing the
script, and align the maintained examples and validation instructions. There script, and align the maintained examples and validation instructions. There
is no need to bundle a replacement Bash completion library. is no need to bundle a replacement Bash completion library.
## Completion interaction review
The follow-up reviewed the new completion path against registration snapshots,
command and scoped flag aliases, ordinary argument allocation, reporting, and
the maintained integration declarations. A local build of the composed example
returned `text` and `yaml` through the existing `pk` and `--fmt` aliases,
even with `--quiet --debug` in the target words. The equivalent ordinary
inspection with `--quiet` stayed silent. ConfigKit completion included
`app` and `promptkit` for diff, and additionally `all` for validate, matching
the installed capabilities. No new discrepancy was found in these paths.
The transport and public metadata findings above remain open.
### 6. Supply the existing PromptKit smoke kinds as operand hints
Priority: P3. Status: open.
The [smoke command](../../integrations/ckprompt/smoke_command.go#L141) still
declares `KIND` without a hint. In the maintained composed consumer, queries
after `promptkit test ` and the existing `smoke ` alias return only the no-file
directive, including for the partial word `re`. The same consumer successfully
runs `smoke reachability --campaign spring --prompt briefing --profile spring`
using its local fixture. Operators get static format suggestions on the command
but none for its required, documented selector.
Attach a static operand hint using the existing native kind constants and
CommandKit's `all` aggregate selector. Preserve upstream ownership of accepted
kinds and existing execution behavior; the hint must not become an allowlist.
Cover the canonical command and the maintained alias without starting a smoke
test or loading an engine for completion.
--- ---
## Historical invocation reporting audit remediation ## Historical invocation reporting audit remediation