Test comparison preparation through provider behavior

This commit is contained in:
2026-10-12 00:16:47 +00:00
parent 251d3adeee
commit c7fb5a27bb
2 changed files with 58 additions and 35 deletions

View File

@@ -1,6 +1,6 @@
# Configuration comparison review remediation
Status: two findings complete; two open. This document tracks required
Status: three findings complete; one open. This document tracks required
follow-up work and its completion evidence.
## Review baseline and scope
@@ -122,7 +122,7 @@ No runtime enforcement or consumer requirement was added.
## R-3: Make preparation tests reject failure without freezing private storage
**Status:** Open. **Priority:** Medium. **Category:** Test quality /
**Status:** Complete. **Priority:** Medium. **Category:** Test quality /
inadvertently strengthened implementation invariants.
**Evidence:** In
@@ -151,6 +151,17 @@ rejected by the test. Tests protect the paired provider/lifecycle contract
without requiring a particular private plan layout. Reuse existing behavioral
coverage where it already proves the relevant fact.
**Completed 2026-10-12:** The valid equal-selection test now requires
`OutcomeSuccess`, so an operational failure cannot pass. The storage-layout test
was replaced with an assembled invocation that observes the provider request,
correlates each input with its checked selection, verifies both checks precede
shared state and provider execution, and verifies ordinary acquisition is unused.
It does not inspect the private plan or assign particular factory IDs to sides.
Existing presence, conversion, collection ownership, zero-value, alias, and
failure-classification cases remain. `go test ./...` passed in
`integrations/ckconfig`, including the simple consumer; formatting, diff, and
whitespace review passed.
## R-4: Reconcile the feature roadmap's completion status
**Status:** Open. **Priority:** Low. **Category:** Documentation divergence.