base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Share reporter detail rendering

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-07 15:45:37 +00:00
parent 8dbb25aba9
commit ac113291fc
3 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/roadmap/audit/catalog.md
View File

@@ -1,6 +1,6 @@
# Consolidated audit catalog
Status: **19 distinct open findings: 19 P3**, consolidated from 30
Status: **18 distinct open findings: 18 P3**, consolidated from 30
numbered entries in seven audit documents. Reviewed audit state:
`db732e3a1de55c844f77870e1c6db683c2685d5d`.
@@ -390,6 +390,10 @@ are selected.
## F20 — P3: Reporter message paths duplicate detail-rendering bookkeeping
**Complete.** Both message paths share detail callback and error bookkeeping;
focused reporter tests cover visibility, ordering, closed handles, and joined
render/write evidence.
Terminal and ordinary message paths repeat callback invocation, managed-writer
setup, render-versus-write error classification, and first-error retention.
Maintaining the same presentation policy in two branches increases the chance of
@@ -406,7 +410,7 @@ fix deferred-message loss or writer retention. After correctness repairs, favor
F20, then F18 and F17, while keeping F19 modest. All four use private functions
and existing types, with no intended public API or CLI behavior change. The
[F17–F20 analysis](remediation-analysis.md#f17f20--proportionate-private-extractions)
records the accepted scope; implementation remains pending.
records the accepted scope.
**Original:** [03-complexity M7](03-complexity.md#m7--p3-terminal-and-ordinary-messages-duplicate-detail-rendering-mechanics).

6
docs/roadmap/implementation.md
View File

@@ -1,6 +1,6 @@
# Audit remediation implementation plan
Status: in progress; Stages 1–7 complete.
Status: in progress; Stages 1–8 complete.
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Before this sprint,
intervening changes recorded decisions and retired the completed older
@@ -304,6 +304,10 @@ without promising immediate garbage collection or taking ownership of closers.
## Stage 8 — Share reporter detail-rendering bookkeeping
**Complete.** Terminal and ordinary reporting share detail-rendering and error
classification under the existing lock. Focused reporter and hidden-deferred
tests passed in the offline aligned Go 1.27.0 workspace with `-mod=readonly`.
Findings: F20. Source: `reporter.go`; follows lifecycle fixes in stages 3 and 7.
1. Extract a private helper running under the existing reporting lock to invoke