base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Expose current configuration source evidence

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-04 15:00:04 +00:00
parent 2904eadf4f
commit 72099958d1
2 changed files with 53 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/roadmap/implementation.md
View File

@@ -1,6 +1,6 @@
# ConfigKit v1.1.0 adoption implementation plan # ConfigKit v1.1.0 adoption implementation plan
Status: Stage 1 complete; Stages 2–6 are not started. Status: Stages 1–2 complete; Stages 3–6 are not started.
This plan is for a Luna coding agent implementing the selected This plan is for a Luna coding agent implementing the selected
[ConfigKit adoption target](configkit-v1.1.0.md). Follow Stage 1 through Stage 6 [ConfigKit adoption target](configkit-v1.1.0.md). Follow Stage 1 through Stage 6
@@ -108,6 +108,10 @@ there is no requirement to keep this intermediate state independently usable.
## Stage 2: Align source-report vocabulary and add empty-import evidence ## Stage 2: Align source-report vocabulary and add empty-import evidence
**Completed.** Text and YAML projections use the new vocabulary and include
ordered empty-import selections, including empty lists and nil version evidence.
The packages compile offline with Go 1.27.0; focused behavioral tests follow.
Work in `integrations/ckconfig/sources.go`. Keep its existing report preparation Work in `integrations/ckconfig/sources.go`. Keep its existing report preparation
and delivery path; no new provider capability or operation is needed. and delivery path; no new provider capability or operation is needed.

77
integrations/ckconfig/sources.go
View File

@@ -17,17 +17,24 @@ type sourceReport struct {
} }
type sourceDTO struct { type sourceDTO struct {
ID string `yaml:"id"` ID string `yaml:"id"`
Label string `yaml:"label"` Label string `yaml:"label"`
Path string `yaml:"path"` Path string `yaml:"path"`
Destination string `yaml:"destination"` Destination string `yaml:"destination"`
Placement string `yaml:"placement"` Placement string `yaml:"placement"`
DestinationUnresolved bool `yaml:"destination_unresolved"` DestinationIsFallback bool `yaml:"destination_is_fallback"`
Layer string `yaml:"layer"` Layer string `yaml:"layer"`
Kind string `yaml:"kind"` Kind string `yaml:"kind"`
UnderlayIndex int `yaml:"underlay_index"` UnderlayIndex int `yaml:"underlay_index"`
ImportedFrom *locationDTO `yaml:"imported_from"` ImportedFrom *locationDTO `yaml:"imported_from"`
VersionCheck *sourceVersionCheckDTO `yaml:"version_check"` VersionEvidence *sourceVersionEvidenceDTO `yaml:"version_evidence"`
EmptyImportSelections []emptyImportSelectionDTO `yaml:"empty_import_selections"`
}
type emptyImportSelectionDTO struct {
Path string `yaml:"path"`
Location locationDTO `yaml:"location"`
Selector string `yaml:"selector"`
} }
type locationDTO struct { type locationDTO struct {
@@ -36,7 +43,7 @@ type locationDTO struct {
Column int `yaml:"column"` Column int `yaml:"column"`
} }
type sourceVersionCheckDTO struct { type sourceVersionEvidenceDTO struct {
Path string `yaml:"path"` Path string `yaml:"path"`
Version versionDTO `yaml:"version"` Version versionDTO `yaml:"version"`
Location *locationDTO `yaml:"location"` Location *locationDTO `yaml:"location"`
@@ -89,17 +96,18 @@ func runConfigSources[I, S any](invocation commandkit.Invocation, plan *configOp
Path: source.Path, Path: source.Path,
Destination: source.Destination.String(), Destination: source.Destination.String(),
Placement: placement, Placement: placement,
DestinationUnresolved: source.DestinationIsFallback, DestinationIsFallback: source.DestinationIsFallback,
Layer: string(source.Layer), Layer: string(source.Layer),
Kind: string(source.Kind), Kind: string(source.Kind),
UnderlayIndex: source.UnderlayIndex, UnderlayIndex: source.UnderlayIndex,
EmptyImportSelections: make([]emptyImportSelectionDTO, 0, len(source.EmptyImportSelections)),
} }
if source.ImportedFrom != nil { if source.ImportedFrom != nil {
item.ImportedFrom = &locationDTO{SourceID: source.ImportedFrom.SourceID, Line: source.ImportedFrom.Line, Column: source.ImportedFrom.Column} item.ImportedFrom = &locationDTO{SourceID: source.ImportedFrom.SourceID, Line: source.ImportedFrom.Line, Column: source.ImportedFrom.Column}
} }
if source.VersionEvidence != nil { if source.VersionEvidence != nil {
check := source.VersionEvidence check := source.VersionEvidence
item.VersionCheck = &sourceVersionCheckDTO{ item.VersionEvidence = &sourceVersionEvidenceDTO{
Path: check.Path.String(), Path: check.Path.String(),
Version: versionDTO{ Version: versionDTO{
Present: check.Version.Present, Present: check.Version.Present,
@@ -109,9 +117,12 @@ func runConfigSources[I, S any](invocation commandkit.Invocation, plan *configOp
Redacted: check.Redacted, Redacted: check.Redacted,
} }
if check.Location != nil { if check.Location != nil {
item.VersionCheck.Location = &locationDTO{SourceID: check.Location.SourceID, Line: check.Location.Line, Column: check.Location.Column} item.VersionEvidence.Location = &locationDTO{SourceID: check.Location.SourceID, Line: check.Location.Line, Column: check.Location.Column}
} }
} }
for _, selection := range source.EmptyImportSelections {
item.EmptyImportSelections = append(item.EmptyImportSelections, emptyImportSelectionDTO{Path: selection.Path.String(), Location: locationDTO{SourceID: selection.Location.SourceID, Line: selection.Location.Line, Column: selection.Location.Column}, Selector: string(selection.Selector)})
}
document.Sources = append(document.Sources, item) document.Sources = append(document.Sources, item)
} }
if err := invocation.Context.Err(); err != nil { if err := invocation.Context.Err(); err != nil {
@@ -143,7 +154,7 @@ func writeSourceReportText(writer *bytes.Buffer, document sourceReport) {
_, _ = fmt.Fprintf(writer, " path: %s\n", strconv.Quote(source.Path)) _, _ = fmt.Fprintf(writer, " path: %s\n", strconv.Quote(source.Path))
_, _ = fmt.Fprintf(writer, " destination: %s\n", strconv.Quote(source.Destination)) _, _ = fmt.Fprintf(writer, " destination: %s\n", strconv.Quote(source.Destination))
_, _ = fmt.Fprintf(writer, " placement: %s\n", strconv.Quote(source.Placement)) _, _ = fmt.Fprintf(writer, " placement: %s\n", strconv.Quote(source.Placement))
_, _ = fmt.Fprintf(writer, " destination_unresolved: %t\n", source.DestinationUnresolved) _, _ = fmt.Fprintf(writer, " destination_is_fallback: %t\n", source.DestinationIsFallback)
_, _ = fmt.Fprintf(writer, " layer: %s\n", strconv.Quote(source.Layer)) _, _ = fmt.Fprintf(writer, " layer: %s\n", strconv.Quote(source.Layer))
_, _ = fmt.Fprintf(writer, " kind: %s\n", strconv.Quote(source.Kind)) _, _ = fmt.Fprintf(writer, " kind: %s\n", strconv.Quote(source.Kind))
_, _ = fmt.Fprintf(writer, " underlay_index: %d\n", source.UnderlayIndex) _, _ = fmt.Fprintf(writer, " underlay_index: %d\n", source.UnderlayIndex)
@@ -153,21 +164,29 @@ func writeSourceReportText(writer *bytes.Buffer, document sourceReport) {
_, _ = fmt.Fprintf(writer, " imported_from: {source_id: %s, line: %d, column: %d}\n", _, _ = fmt.Fprintf(writer, " imported_from: {source_id: %s, line: %d, column: %d}\n",
strconv.Quote(source.ImportedFrom.SourceID), source.ImportedFrom.Line, source.ImportedFrom.Column) strconv.Quote(source.ImportedFrom.SourceID), source.ImportedFrom.Line, source.ImportedFrom.Column)
} }
if source.VersionCheck == nil { if source.VersionEvidence == nil {
_, _ = writer.WriteString(" version_check: null\n") _, _ = writer.WriteString(" version_evidence: null\n")
continue
}
check := source.VersionCheck
_, _ = fmt.Fprintf(writer, " version_check:\n path: %s\n", strconv.Quote(check.Path))
_, _ = fmt.Fprintf(writer, " version:\n present: %t\n null: %t\n text: %s\n",
check.Version.Present, check.Version.Null, strconv.Quote(check.Version.Text))
if check.Location == nil {
_, _ = writer.WriteString(" location: null\n")
} else { } else {
_, _ = fmt.Fprintf(writer, " location: {source_id: %s, line: %d, column: %d}\n", check := source.VersionEvidence
strconv.Quote(check.Location.SourceID), check.Location.Line, check.Location.Column) _, _ = fmt.Fprintf(writer, " version_evidence:\n path: %s\n", strconv.Quote(check.Path))
_, _ = fmt.Fprintf(writer, " version:\n present: %t\n null: %t\n text: %s\n",
check.Version.Present, check.Version.Null, strconv.Quote(check.Version.Text))
if check.Location == nil {
_, _ = writer.WriteString(" location: null\n")
} else {
_, _ = fmt.Fprintf(writer, " location: {source_id: %s, line: %d, column: %d}\n",
strconv.Quote(check.Location.SourceID), check.Location.Line, check.Location.Column)
}
_, _ = fmt.Fprintf(writer, " redacted: %t\n", check.Redacted)
}
if len(source.EmptyImportSelections) == 0 {
_, _ = writer.WriteString(" empty_import_selections: []\n")
} else {
_, _ = writer.WriteString(" empty_import_selections:\n")
for _, selection := range source.EmptyImportSelections {
_, _ = fmt.Fprintf(writer, " - path: %s\n location: {source_id: %s, line: %d, column: %d}\n selector: %s\n", strconv.Quote(selection.Path), strconv.Quote(selection.Location.SourceID), selection.Location.Line, selection.Location.Column, strconv.Quote(selection.Selector))
}
} }
_, _ = fmt.Fprintf(writer, " redacted: %t\n", check.Redacted)
} }
} }