base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use the declared YAML dependency in comparison tests

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-12 15:08:44 +00:00
parent b9d5ea4b1b
commit 61f0d8806d
3 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
docs/roadmap/remediation.md
View File

@@ -1,6 +1,6 @@
# CommandKit implementation review remediation
Status: R-1 through R-4 are complete; R-5 and R-6 are open. This document
Status: R-1 through R-5 are complete; R-6 is open. This document
tracks required follow-up work and its completion evidence.
## ConfigKit review baseline and scope
@@ -224,11 +224,12 @@ acknowledged validation limitation, not a reason to add test-only public hooks.
## R-5: Validate the committed ckprompt manifest without an extra test-only YAML API
**Status:** Open. **Priority:** Medium. **Category:** Distribution validation gap /
**Status:** Complete. **Priority:** Medium. **Category:** Distribution validation gap /
dependency consistency.
**Evidence:** [comparison_composition_test.go](../../integrations/ckprompt/comparison_composition_test.go)
imports `gopkg.in/yaml.v3` at line 17. This import was introduced by `f7b1d2c`;
**Evidence:** At the review baseline,
[comparison_composition_test.go](../../integrations/ckprompt/comparison_composition_test.go)
imported `gopkg.in/yaml.v3` at line 17. This import was introduced by `f7b1d2c`;
the [ckprompt manifest](../../integrations/ckprompt/go.mod) declares the existing
`go.yaml.in/yaml/v4` dependency instead. The other ckprompt reports and tests use
that existing API. The new comparison test needs only ordinary YAML decoding,
@@ -279,6 +280,18 @@ replacements pass `go list -deps -test ./...` and the ckprompt suite in
workspace-off read-only mode. The test uses the existing YAML API, and any
necessary metadata changes are tracked with accurate validation evidence.
**Completed 2026-10-12:** The comparison consumer test now uses the already
declared `go.yaml.in/yaml/v4` API. Fresh copies of the distributed ckprompt
`go.mod` and `go.sum`, augmented only with replacements for unpublished core and
ckconfig prerequisites, passed `go list -m all`, `go list -deps -test ./...`, and
`go test -count=1 ./...` with `GOWORK=off GOTOOLCHAIN=local` and `-mod=readonly`
on Go 1.26.8. The suite includes the composed consumer. Validation performed no
tidy; both disposable files remained byte-for-byte unchanged after the checks.
Distributed manifests, sums, and legitimate transitive YAML v3 notices needed
no changes. Stage 12 now records this corrected committed-metadata evidence;
local replacements establish source compatibility, not unpublished tag
availability. Formatting and documentation checks passed.
## R-6: Test comparison capability membership rather than its slice position
**Status:** Open. **Priority:** Low. **Category:** Inadvertently strengthened