Preserve empty smoke error messages in aggregate reports
This commit is contained in:
@@ -141,7 +141,7 @@ func (err *smokeTypedError) Error() string { return err.text }
|
||||
|
||||
func TestSmokeAggregatePreservesMultipleTypedCauses(t *testing.T) {
|
||||
firstErr := &smokeTypedError{text: "reachability failed"}
|
||||
secondErr := &smokeTypedError{text: "authentication failed"}
|
||||
secondErr := &smokeTypedError{text: ""}
|
||||
app := newPromptTestApp(t, Command(Suite[struct{}, struct{}]{
|
||||
SmokeTest: func(_ context.Context, request SmokeRequest, _ struct{}, _ struct{}) (commandkit.Acquired[*promptkit.SmokeTestReport], error) {
|
||||
var err error
|
||||
@@ -162,14 +162,14 @@ func TestSmokeAggregatePreservesMultipleTypedCauses(t *testing.T) {
|
||||
}
|
||||
var document struct {
|
||||
Tests []struct {
|
||||
Kind string `yaml:"kind"`
|
||||
Error string `yaml:"error"`
|
||||
Kind string `yaml:"kind"`
|
||||
Error *string `yaml:"error"`
|
||||
} `yaml:"tests"`
|
||||
}
|
||||
if err := yaml.Unmarshal(output.Bytes(), &document); err != nil {
|
||||
t.Fatalf("decode aggregate errors %q: %v", output.String(), err)
|
||||
}
|
||||
if len(document.Tests) != 4 || document.Tests[0].Kind != string(promptkit.SmokeTestReachability) || document.Tests[0].Error != firstErr.Error() || document.Tests[1].Kind != string(promptkit.SmokeTestAuthentication) || document.Tests[1].Error != secondErr.Error() || document.Tests[2].Error != "" || document.Tests[3].Error != "" {
|
||||
if len(document.Tests) != 4 || document.Tests[0].Kind != string(promptkit.SmokeTestReachability) || document.Tests[0].Error == nil || *document.Tests[0].Error != firstErr.Error() || document.Tests[1].Kind != string(promptkit.SmokeTestAuthentication) || document.Tests[1].Error == nil || *document.Tests[1].Error != secondErr.Error() || document.Tests[2].Error != nil || document.Tests[3].Error != nil {
|
||||
t.Fatalf("aggregate error entries = %#v", document.Tests)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user