base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

Keep aggregate smoke tests focused on behavior

Browse Source
This commit is contained in:
Eric Rakestraw
2026-10-18 13:30:02 +00:00
parent 94c352dbd6
commit 114c7da7be
3 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
integrations/ckprompt/smoke_aggregate_test.go
View File

@@ -28,9 +28,6 @@ func TestSmokeAggregateCoordinatesConcreteRequestsAndRetainsErrors(t *testing.T)
nativeErr := errors.New("authentication smoke failed")
newInputCalls, checkCalls, newStateCalls := 0, 0, 0
var gotKinds []promptkit.SmokeTestKind
var executionPointers []*promptkit.ExecutionTargetOverride
var temperaturePointers []*float64
var retryPointers []*int
var firstInput *input
var sharedState *state
suite := Suite[*input, *state]{
@@ -60,9 +57,6 @@ func TestSmokeAggregateCoordinatesConcreteRequestsAndRetainsErrors(t *testing.T)
if request.Request.Execution == nil || request.Request.Execution.Model != "base-model" || request.Request.Execution.Temperature == nil || *request.Request.Execution.Temperature != 0.25 || request.Request.TransientRetries == nil || *request.Request.TransientRetries != 3 {
t.Errorf("seed for %s = %#v", request.Request.Kind, request.Request)
}
executionPointers = append(executionPointers, request.Request.Execution)
temperaturePointers = append(temperaturePointers, request.Request.Execution.Temperature)
retryPointers = append(retryPointers, request.Request.TransientRetries)
if len(gotKinds) == 1 {
request.Request.Execution.Model = "builder mutation"
*request.Request.Execution.Temperature = 0.9
@@ -86,13 +80,6 @@ func TestSmokeAggregateCoordinatesConcreteRequestsAndRetainsErrors(t *testing.T)
if newInputCalls != 1 || checkCalls != 1 || newStateCalls != 1 || !reflect.DeepEqual(gotKinds, wantKinds) {
t.Fatalf("invocation calls = input %d, check %d, state %d, kinds %#v", newInputCalls, checkCalls, newStateCalls, gotKinds)
}
for index := range executionPointers {
for other := index + 1; other < len(executionPointers); other++ {
if executionPointers[index] == executionPointers[other] || temperaturePointers[index] == temperaturePointers[other] || retryPointers[index] == retryPointers[other] {
t.Fatalf("request pointers were reused between operations %d and %d", index, other)
}
}
}
var document struct {
Tests []struct {