Keep aggregate smoke tests focused on behavior

This commit is contained in:
2026-10-18 13:30:02 +00:00
parent 94c352dbd6
commit 114c7da7be
3 changed files with 12 additions and 19 deletions

View File

@@ -1,6 +1,6 @@
# Dependency upgrade and PromptKit smoke review remediation
Status: in progress; R-1 and R-2 complete; R-3 and R-4 remain open.
Status: in progress; R-1 through R-3 complete; R-4 remains open.
## Review scope and evidence
@@ -127,7 +127,7 @@ Production code is unchanged.
## R-3: Remove incidental loader-count and pointer-identity contracts
Status: open. Priority: P3. Category: unnecessary implementation constraints.
Status: complete. Priority: P3. Category: unnecessary implementation constraints.
**Locations:**
@@ -167,6 +167,14 @@ pass. The tests continue to detect cross-test value contamination and missing
operations, while accepting equivalent acquisition and storage implementations.
No production-code change is required.
**Completed:** 2026-10-18. Removed the aggregate loader counter and pairwise
pointer-address assertions/bookkeeping. The tests retain ordered concrete
builder/callback inputs, shared input/state, mutation-isolated seed values,
continuation, cancellation, reports, and error identity. Focused aggregate,
builder, help/version, and builder-failure tests and the complete ckprompt suite,
including the composed consumer, passed with Go 1.26.8 and offline dependency
resolution. Production code is unchanged.
## R-4: Reconcile the feature roadmap with completed implementation
Status: open. Priority: P3. Category: stale implementation status.